From 640ab94712483457b99bd1039b52821c510b28a7 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Wed, 27 Nov 2019 21:18:38 +0000 Subject: gdb/testsuite: Fix race condition compiling fortran test The Fortran test gdb.fortran/info-modules compiles the files info-types.f90 and info-types-2.f90 in that order. Unfortunately info-types.f90 makes use of a module defined in info-types-2.f90. This currently doesn't cause a problem if you run all of the Fortran tests as the info-types.exp test already compiles info-types-2.f90 and so the module description file 'mod2.mod' will be created, and can then be found by info-modules.exp during its compile. If however you try to run just info-modules.exp in a clean build directory, the test will fail to compile. Fix this by compiling the source files in the reverse order so that the module is compiled first, then the test program that uses the module. gdb/testsuite/ChangeLog: * gdb.fortran/info-modules.exp: Compile source files in correct order. Change-Id: Ic3a1eded0486f6264ebe3066cf1beafbd2534a91 --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.fortran/info-modules.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) (limited to 'gdb/testsuite') diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3a6e925..86f2130 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-11-27 Andrew Burgess + + * gdb.fortran/info-modules.exp: Compile source files in correct + order. + 2019-11-27 Kevin Buettner * gdb.dwarf2/imported-unit.exp: New file. diff --git a/gdb/testsuite/gdb.fortran/info-modules.exp b/gdb/testsuite/gdb.fortran/info-modules.exp index 4357006..c57ac3f 100644 --- a/gdb/testsuite/gdb.fortran/info-modules.exp +++ b/gdb/testsuite/gdb.fortran/info-modules.exp @@ -23,7 +23,7 @@ if { [skip_fortran_tests] } { continue } standard_testfile info-types.f90 info-types-2.f90 if { [prepare_for_testing "failed to prepare" $testfile \ - [list $srcfile $srcfile2] {debug f90}] } { + [list $srcfile2 $srcfile] {debug f90}] } { return -1 } -- cgit v1.1