From bf6d8a91eac025c21b03d604bdb2e4b901c4c6bc Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 7 Aug 2013 20:03:52 +0000 Subject: use language of the main symbol With "dwz -m", "main" appears in both the PU and the importing CU when running anon-struct.exp. However, the PU does not have a file name. So, find_main_filename returns the empty string, making deduce_language_from_filename return language_unknown. This patch fixes this problem by changing gdb to use the ordinary symbol-lookup functions to find "main"'s symbol. Then, it examines the symbol's language. I think this is cleaner than the current approach. For one thing it avoids trying to guess the language based on the source file name, instead deferring to the presumably more reliable debuginfo. Another possible fix would have been to change how the file name is found via the "qf" methods. However, I think the approach given is preferable for the reason outlined above. This required a minor test suite change, as now a symtab is expanded during the search for "main". Built and regtested (both ways) on x86-64 Fedora 18. * symfile.c (set_initial_language): Look up "main" symbol and use its language. * symtab.c (find_main_filename): Remove. * symtab.h (find_main_filename): Remove. * gdb.base/maint.exp: Allow zero symtabs to be expanded. --- gdb/testsuite/ChangeLog | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'gdb/testsuite/ChangeLog') diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 160a27a..fb21761 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,9 @@ 2013-08-07 Tom Tromey + * gdb.base/maint.exp: Allow zero symtabs to be expanded. + +2013-08-07 Tom Tromey + * gdb.dwarf2/dwz.exp: New file. 2013-08-02 Tom Tromey -- cgit v1.1