From d3ce09f5bf7a7e8f97c3f1c9888e886ee267c2f2 Mon Sep 17 00:00:00 2001
From: Stan Shebs <shebs@codesourcery.com>
Date: Mon, 2 Jul 2012 15:29:39 +0000
Subject: 	Add target-side support for dynamic printf. 	* NEWS:
 Mention the additional style. 	* breakpoint.h (struct bp_target_info): New
 fields tcommands, persist. 	(struct bp_location): New field cmd_bytecode. 
 * breakpoint.c: Include format.h. 	(disconnected_dprintf): New global. 
 (parse_cmd_to_aexpr): New function. 	(build_target_command_list): New
 function. 	(insert_bp_location): Call it. 	(remove_breakpoints_pid): Skip
 dprintf breakpoints. 	(print_one_breakpoint_location): Ditto. 
 (dprintf_style_agent): New global. 	(dprintf_style_enums): Add
 dprintf_style_agent. 	(update_dprintf_command_list): Add agent case. 
 (agent_printf_command): New function. 	(_initialize_breakpoint): Add new
 commands. 	* common/ax.def (printf): New bytecode. 	* ax.h
 (ax_string): Declare. 	* ax-gdb.h (gen_printf): Declare. 	* ax-gdb.c:
 Include cli-utils.h, format.h. 	(gen_printf): New function. 
 (maint_agent_print_command): New function. 	(_initialize_ax_gdb): Add
 maint agent-printf command. 	* ax-general.c (ax_string): New function. 
 (ax_print): Add printf disassembly. 	* Makefile.in (SFILES): Add format.c 
 (COMMON_OBS): Add format.o. 	* common/format.h: New file. 	*
 common/format.c: New file. 	* printcmd.c: Include format.h. 
 (ui_printf): Call parse_format_string. 	* remote.c (remote_state): New
 field breakpoint_commands. 	(PACKET_BreakpointCommands): New enum. 
 (remote_breakpoint_commands_feature): New function. 
 (remote_protocol_features): Add new BreakpointCommands entry. 
 (remote_can_run_breakpoint_commands): New function. 
 (remote_add_target_side_commands): New function. 
 (remote_insert_breakpoint): Call it. 	(remote_insert_hw_breakpoint): Ditto. 
 (_initialize_remote): Add new packet configuration for 	target-side
 breakpoint commands. 	* target.h (struct target_ops): New field 
 to_can_run_breakpoint_commands. 	(target_can_run_breakpoint_commands):
 New macro. 	* target.c (update_current_target): Handle 
 to_can_run_breakpoint_commands.

	[gdbserver]
	* Makefile.in (WARN_CFLAGS_NO_FORMAT): Define.
	(ax.o): Add it to build rule.
	(ax-ipa.o): Ditto.
	(OBS): Add format.o.
	(IPA_OBS): Add format.o.
	* server.c (handle_query): Claim support for breakpoint commands.
	(process_point_options): Add command case.
	(process_serial_event): Leave running if there are printfs in
	effect.
	* mem-break.h (any_persistent_commands): Declare.
	(add_breakpoint_commands): Declare.
	(gdb_no_commands_at_breakpoint): Declare.
	(run_breakpoint_commands): Declare.
	* mem-break.c (struct point_command_list): New struct.
	(struct breakpoint): New field command_list.
	(any_persistent_commands): New function.
	(add_commands_to_breakpoint): New function.
	(add_breakpoint_commands): New function.
	(gdb_no_commands_at_breakpoint): New function.
	(run_breakpoint_commands): New function.
	* linux-low.c (linux_wait_1): Test for and run breakpoint commands
	locally.
	* ax.c: Include format.h.
	(ax_printf): New function.
	(gdb_eval_agent_expr): Add printf opcode.

	[doc]
	* gdb.texinfo (Dynamic Printf): Mention agent style and
	disconnected dprintf.
	(Maintenance Commands): Describe maint agent-printf.
	(General Query Packets): Mention BreakpointCommands feature.
	(Packets): Document commands extension to Z0 packet.
	* agentexpr.texi (Bytecode Descriptions): Document printf
	bytecode.

	[testsuite]
	* gdb.base/dprintf.exp: Add agent style tests.
---
 gdb/target.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

(limited to 'gdb/target.h')

diff --git a/gdb/target.h b/gdb/target.h
index e5bdf4d..54c58d6 100644
--- a/gdb/target.h
+++ b/gdb/target.h
@@ -672,6 +672,10 @@ struct target_ops
        end?  */
     int (*to_supports_evaluation_of_breakpoint_conditions) (void);
 
+    /* Does this target support evaluation of breakpoint commands on its
+       end?  */
+    int (*to_can_run_breakpoint_commands) (void);
+
     /* Determine current architecture of thread PTID.
 
        The target is supposed to determine the architecture of the code where
@@ -997,6 +1001,12 @@ int target_supports_disable_randomization (void);
 #define target_supports_evaluation_of_breakpoint_conditions() \
   (*current_target.to_supports_evaluation_of_breakpoint_conditions) ()
 
+/* Returns true if this target can handle breakpoint commands
+   on its end.  */
+
+#define target_can_run_breakpoint_commands() \
+  (*current_target.to_can_run_breakpoint_commands) ()
+
 /* Invalidate all target dcaches.  */
 extern void target_dcache_invalidate (void);
 
-- 
cgit v1.1