From de9bef49be9432334e7806405b33cd0d0a69d754 Mon Sep 17 00:00:00 2001 From: John Gilmore Date: Thu, 17 Dec 1992 09:15:10 +0000 Subject: Eliminate uses of NAMES_HAVE_UNDERSCORE, using bfd_get_symbol_leading_char instead. * coffread.c (EXTERNAL_NAME): New macro for removing possible leading character from names. (read_coff_symtab): Use BFD's FILE *, don't open a second one. (read_coff_symtab): Complain() about .bb/.eb mismatch, don't error(). (process_coff_symbol, coff_read_struct_type, coff_read_enum_type): Replace NAMES_HAVE_UNDERSCORE with EXTERNAL_NAME. * kdb-start.c (main): Remove NAMES_HAVE_UNDERSCORE. * minsyms.c (install_minimal_symbols): Replace NAMES_HAVE_UNDERSCORE. Remove SOME_NAMES_HAVE_DOT support (apparently unused). * partial-stab.h: Replace NAMES_HAVE_UNDERSCORE. * solib.c: Replace NAMES_HAVE_UNDERSCORE. * stabsread.h: Remove NAMES_HAVE_UNDERSCORE and HASH_OFFSET. * symfile.c (syms_from_objfile): Insert debugging check to test NAMES_HAVE_UNDERSCORE setting against the BFD support. FIXME, remove this (and all tm-*.h NAMES_HAVE_UNDERSCORE) soon. * doc/gdbint.texinfo (Host Conditionals): Remove NAMES_HAVE_UNDERSCORE, SOME_NAMES_HAVE_DOT, document MEM_FNS_DECLARED. (Target Conditionals): Remove all of the above. --- gdb/symfile.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) (limited to 'gdb/symfile.c') diff --git a/gdb/symfile.c b/gdb/symfile.c index 908ff09..f01ae36 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -439,6 +439,22 @@ syms_from_objfile (objfile, addr, mainline, verbo) addr -= bfd_section_vma (objfile->obfd, lowest_sect); } + /* Debugging check inserted for testing elimination of NAMES_HAVE_UNDERSCORE. + Complain if the dynamic setting of NAMES_HAVE_UNDERSCORE from BFD + doesn't match the static setting from the GDB config files. + FIXME: Remove this check after a round of testing. + -- gnu@cygnus.com, 16dec92 */ +#ifdef NAMES_HAVE_UNDERSCORE + if (bfd_get_symbol_leading_char(objfile->obfd) != '_') +#else + if (bfd_get_symbol_leading_char(objfile->obfd) != 0) +#endif + fprintf (stderr, + "GDB internal error! NAMES_HAVE_UNDERSCORE set wrong for %s BFD:\n%s\n", + objfile->obfd->xvec->name, + objfile->obfd->filename); + /* End of debugging check. FIXME. */ + /* Initialize symbol reading routines for this objfile, allow complaints to appear for this new file, and record how verbose to be, then do the initial symbol reading for this file. */ -- cgit v1.1