From 210477268d4ac5cad937e811888a5c932206794c Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Mon, 27 Mar 2017 12:28:03 +0100 Subject: Fix gdb_xml_debug/gdb_xml_error ATTRIBUTE_PRINTF use The declarations of gdb_xml_debug and gdb_xml_error are passing "0" as "first-to-check" argument to ATTRIBUTE_PRINTF, as if they were va_args functions. Consequently, the arguments to gdb_xml_debug / gdb_xml_error aren't being checked against the format strings. With that fixed, a couple obvious bugs are exposed, both fixed by this commit. gdb/ChangeLog: 2017-03-27 Pedro Alves * xml-support.h (gdb_xml_debug): Pass a "first-to-check" argument to ATTRIBUTE_PRINTF. * solib-target.c (library_list_start_list): Print "string" not "version". * xml-tdesc.c (tdesc_start_field): Pass "field_name" to gdb_xml_error call. --- gdb/solib-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/solib-target.c') diff --git a/gdb/solib-target.c b/gdb/solib-target.c index 1577e31..1b10e4e 100644 --- a/gdb/solib-target.c +++ b/gdb/solib-target.c @@ -159,7 +159,7 @@ library_list_start_list (struct gdb_xml_parser *parser, if (strcmp (string, "1.0") != 0) gdb_xml_error (parser, _("Library list has unsupported version \"%s\""), - version); + string); } } -- cgit v1.1