From 326a5c7e368d49251ad48b2091388d8f424bfc54 Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Tue, 14 Apr 2015 12:35:30 +0100 Subject: Zero supplied stat buffers in functions that pretend to stat GDB has five places where it pretends to stat for bfd_openr_iovec. Four of these only set the incoming buffer's st_size, leaving the other fields unchanged, which is to say very likely populated with random values from the stack. remote_bfd_iovec_stat was fixed in 0a93529c56714b1da3d7106d3e0300764f8bb81c; this commit fixes the other four. gdb/ChangeLog: * jit.c (mem_bfd_iovec_stat): Zero supplied buffer. * minidebug.c (lzma_stat): Likewise. * solib-spu.c (spu_bfd_iovec_stat): Likewise. * spu-linux-nat.c (spu_bfd_iovec_stat): Likewise. --- gdb/solib-spu.c | 1 + 1 file changed, 1 insertion(+) (limited to 'gdb/solib-spu.c') diff --git a/gdb/solib-spu.c b/gdb/solib-spu.c index 250cf21..44fbf91 100644 --- a/gdb/solib-spu.c +++ b/gdb/solib-spu.c @@ -313,6 +313,7 @@ spu_bfd_iovec_stat (bfd *abfd, void *stream, struct stat *sb) table to find the extent of the last section but that seems pointless when the size is needed only for checks of other parsed values in dbxread.c. */ + memset (sb, 0, sizeof (struct stat)); sb->st_size = INT_MAX; return 0; } -- cgit v1.1