From 940dace9cff6f44e051632e12b51cef23f19de1f Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Fri, 5 Jun 2020 21:07:58 +0100 Subject: Revert "gdb/python: Avoid use after free in py-tui.c" This reverts commit 982a38f60b0ece9385556cff45567e06710478cb. I missed that the title being assigned too was a std::string, and so there is no leak. --- gdb/python/py-tui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/python') diff --git a/gdb/python/py-tui.c b/gdb/python/py-tui.c index f2c0339..ca88f85 100644 --- a/gdb/python/py-tui.c +++ b/gdb/python/py-tui.c @@ -433,7 +433,7 @@ gdbpy_tui_set_title (PyObject *self, PyObject *newvalue, void *closure) if (value == nullptr) return -1; - win->window->title = value.release (); + win->window->title = value.get (); return 0; } -- cgit v1.1