From 14b8ef758c634e0c1460010f2125799d0588a194 Mon Sep 17 00:00:00 2001 From: Jan Vrany Date: Wed, 19 Mar 2025 21:12:53 +0000 Subject: gdb/python: preserve identity for gdb.Symtab objects This commit changes symtab_to_symtab_object() so that each it is called with a particular struct symtab * it returns the very same gdb.Symtab object. This is done by searching per-objfile linked list of instances and - if found - return it rather than creating new gdb.Symtab. Approved-By: Tom Tromey --- gdb/python/py-symtab.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) (limited to 'gdb/python') diff --git a/gdb/python/py-symtab.c b/gdb/python/py-symtab.c index 99a5094..7b51e21 100644 --- a/gdb/python/py-symtab.c +++ b/gdb/python/py-symtab.c @@ -449,7 +449,7 @@ set_symtab (symtab_object *obj, struct symtab *symtab) { obj->symtab = symtab; obj->prev = NULL; - if (symtab) + if (symtab != nullptr) { obj->next = stpy_objfile_data_key.get (symtab->compunit ()->objfile ()); if (obj->next) @@ -467,6 +467,22 @@ symtab_to_symtab_object (struct symtab *symtab) { symtab_object *symtab_obj; + /* Look if there's already a gdb.Symtab object for given SYMTAB + and if so, return it. */ + if (symtab != nullptr) + { + symtab_obj = stpy_objfile_data_key.get (symtab->compunit ()->objfile ()); + while (symtab_obj != nullptr) + { + if (symtab_obj->symtab == symtab) + { + Py_INCREF (symtab_obj); + return (PyObject*)symtab_obj; + } + symtab_obj = symtab_obj->next; + } + } + symtab_obj = PyObject_New (symtab_object, &symtab_object_type); if (symtab_obj) set_symtab (symtab_obj, symtab); -- cgit v1.1