From abf5651e47c0396df58a37951bc03a349169c5f2 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 6 Nov 2016 20:42:32 -0700 Subject: Change event code to use gdbpy_ref This changes the event code in the Python layer to use gdbpy_ref, simplifying the logic in many places. It also changes evpy_emit_event not to steal a reference to its argument. This is simpler to do now that gdbpy_ref is in use; it's also a reasonable cleanup in its own right. While doing this I realized that evpy_emit_event should not be calling gdbpy_print_stack (all the outermost callers do this if needed), so I removed this as well. 2017-01-10 Tom Tromey * python/py-threadevent.c (create_thread_event_object): Use gdbpy_ref. * python/py-stopevent.c (create_stop_event_object): Simplify. (emit_stop_event): Use gdbpy_ref. * python/py-signalevent.c (create_signal_event_object): Use gdbpy_ref. * python/py-newobjfileevent.c (create_new_objfile_event_object) (emit_new_objfile_event, create_clear_objfiles_event_object) (emit_clear_objfiles_event): Use gdbpy_ref. * python/py-infevents.c (create_inferior_call_event_object) (create_register_changed_event_object) (create_memory_changed_event_object, emit_inferior_call_event) (emit_memory_changed_event, emit_register_changed_event): Use gdbpy_ref. * python/py-exitedevent.c (create_exited_event_object) (emit_exited_event): Use gdbpy_ref. * python/py-event.h (evpy_emit_event): Remove CPYCHECKER_STEALS_REFERENCE_TO_ARG annotation. * python/py-event.c (evpy_emit_event): Use gdbpy_ref. * python/py-continueevent.c (emit_continue_event): Use gdbpy_ref. * python/py-breakpoint.c (gdbpy_breakpoint_created) (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use gdbpy_ref. * python/py-bpevent.c (create_breakpoint_event_object): Use gdbpy_ref. --- gdb/python/py-breakpoint.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'gdb/python/py-breakpoint.c') diff --git a/gdb/python/py-breakpoint.c b/gdb/python/py-breakpoint.c index 7c7099b..c8847ff 100644 --- a/gdb/python/py-breakpoint.c +++ b/gdb/python/py-breakpoint.c @@ -918,7 +918,6 @@ gdbpy_breakpoint_created (struct breakpoint *bp) if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_created)) { - Py_INCREF (newbp); if (evpy_emit_event ((PyObject *) newbp, gdb_py_events.breakpoint_created) < 0) gdbpy_print_stack (); @@ -946,10 +945,7 @@ gdbpy_breakpoint_deleted (struct breakpoint *b) { if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_deleted)) { - PyObject *bp_obj_alias = (PyObject *) bp_obj; - - Py_INCREF (bp_obj_alias); - if (evpy_emit_event (bp_obj_alias, + if (evpy_emit_event ((PyObject *) bp_obj, gdb_py_events.breakpoint_deleted) < 0) gdbpy_print_stack (); } @@ -981,7 +977,6 @@ gdbpy_breakpoint_modified (struct breakpoint *b) { if (!evregpy_no_listeners_p (gdb_py_events.breakpoint_modified)) { - Py_INCREF (bp_obj); if (evpy_emit_event (bp_obj, gdb_py_events.breakpoint_modified) < 0) gdbpy_print_stack (); -- cgit v1.1