From 3947f654eabb1b6ccf8aad11ece46dc4b027f0f0 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 27 May 2021 13:59:01 -0400 Subject: gdb: make add_com_alias accept target as a cmd_list_element The alias creation functions currently accept a name to specify the target command. They pass this to add_alias_cmd, which needs to lookup the target command by name. Given that: - We don't support creating an alias for a command before that command exists. - We always use add_info_alias just after creating that target command, and therefore have access to the target command's cmd_list_element. ... change add_com_alias to accept the target command as a cmd_list_element (other functions are done in subsequent patches). This ensures we don't create the alias before the target command, because you need to get the cmd_list_element from somewhere when you call the alias creation function. And it avoids an unecessary command lookup. So it seems better to me in every aspect. gdb/ChangeLog: * command.h (add_com_alias): Accept target as cmd_list_element. Update callers. Change-Id: I24bed7da57221cc77606034de3023fedac015150 --- gdb/objc-lang.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'gdb/objc-lang.c') diff --git a/gdb/objc-lang.c b/gdb/objc-lang.c index 1d44012..077ac77 100644 --- a/gdb/objc-lang.c +++ b/gdb/objc-lang.c @@ -1319,9 +1319,10 @@ _initialize_objc_language () _("All Objective-C selectors, or those matching REGEXP.")); add_info ("classes", info_classes_command, _("All Objective-C classes, or those matching REGEXP.")); - add_com ("print-object", class_vars, print_object_command, - _("Ask an Objective-C object to print itself.")); - add_com_alias ("po", "print-object", class_vars, 1); + cmd_list_element *print_object_cmd + = add_com ("print-object", class_vars, print_object_command, + _("Ask an Objective-C object to print itself.")); + add_com_alias ("po", print_object_cmd, class_vars, 1); } static void -- cgit v1.1