From 5d10a2041eb843fd321ce1d850cf3e0df7648bc7 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 24 Jan 2022 20:00:46 -0500 Subject: gdb: add string_file::release method A common pattern for string_file is to want to move out the internal string buffer, because it is the result of the computation that we want to return. It is the reason why string_file::string returns a non-const reference, as explained in the comment. I think it would make sense to have a dedicated method for that instead and make string_file::string return a const reference. This allows removing the explicit std::move in the typical case. Note that compile_program::compute was missing a move, meaning that the resulting string was copied. With the new version, it's not possible to forget to move. Change-Id: Ieaefa35b73daa7930b2f3a26988b6e3b4121bb79 --- gdb/location.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gdb/location.c') diff --git a/gdb/location.c b/gdb/location.c index d4dfc3b..299ef7e 100644 --- a/gdb/location.c +++ b/gdb/location.c @@ -447,7 +447,7 @@ explicit_to_string_internal (bool as_linespec, explicit_loc->line_offset.offset); } - return std::move (buf.string ()); + return buf.release (); } /* See description in location.h. */ -- cgit v1.1