From b447dd03c16d51c7b41c9af0756fc9db4ad95f0d Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Mon, 28 Jun 2021 11:49:22 -0400 Subject: gdb: remove gdbarch_info_init While reviewing another patch, I realized that gdbarch_info_init could easily be removed in favor of initializing gdbarch_info fields directly in the struct declaration. The only odd part is the union. I don't know if it's actually important for it to be zero-initialized, but I presume it is. I added a constructor to gdbarch_info to take care of that. A proper solution would be to use std::variant. Or, these could also be separate fields, the little extra space required wouldn't matter. gdb/ChangeLog: * gdbarch.sh (struct gdbarch_info): Initialize fields, add constructor. * gdbarch.h: Re-generate. * arch-utils.h (gdbarch_info_init): Remove, delete all usages. * arch-utils.c (gdbarch_info_init): Remove. Change-Id: I7502e08fe0f278d84eef1667a072e8a97bda5ab5 --- gdb/inferior.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'gdb/inferior.c') diff --git a/gdb/inferior.c b/gdb/inferior.c index 059839e..e1c70d5 100644 --- a/gdb/inferior.c +++ b/gdb/inferior.c @@ -747,7 +747,6 @@ add_inferior_with_spaces (void) struct address_space *aspace; struct program_space *pspace; struct inferior *inf; - struct gdbarch_info info; /* If all inferiors share an address space on this system, this doesn't really return a new address space; otherwise, it @@ -760,7 +759,7 @@ add_inferior_with_spaces (void) /* Setup the inferior's initial arch, based on information obtained from the global "set ..." options. */ - gdbarch_info_init (&info); + gdbarch_info info; inf->gdbarch = gdbarch_find_by_info (info); /* The "set ..." options reject invalid settings, so we should always have a valid arch by now. */ -- cgit v1.1