From 9c0fb73485cb2c90bb10cb4d3cf1d27e36f9ff01 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 19 Apr 2023 09:40:20 -0600 Subject: Add dynamic_prop::is_constant I noticed many spots checking whether a dynamic property's kind is PROP_CONST. Some spots, I think, are doing a slightly incorrect check -- checking for != PROP_UNDEFINED where == PROP_CONST is actually required, the key thing being that const_val may only be called for PROP_CONST properties. This patch adds dynamic::is_constant and then updates these checks to use it. Regression tested on x86-64 Fedora 36. --- gdb/guile/scm-type.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gdb/guile') diff --git a/gdb/guile/scm-type.c b/gdb/guile/scm-type.c index 008e792..033b800 100644 --- a/gdb/guile/scm-type.c +++ b/gdb/guile/scm-type.c @@ -827,12 +827,12 @@ gdbscm_type_range (SCM self) case TYPE_CODE_ARRAY: case TYPE_CODE_STRING: case TYPE_CODE_RANGE: - if (type->bounds ()->low.kind () == PROP_CONST) + if (type->bounds ()->low.is_constant ()) low = type->bounds ()->low.const_val (); else low = 0; - if (type->bounds ()->high.kind () == PROP_CONST) + if (type->bounds ()->high.is_constant ()) high = type->bounds ()->high.const_val (); else high = 0; -- cgit v1.1