From 5cc0917c387350c47c350843e3b7a16059345529 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Thu, 19 Nov 2020 17:52:00 +0000 Subject: gdb: remove some uses of LA_PRINT_STRING This commit removes some, but not all, uses of LA_PRINT_STRING. In this commit I've removed those uses where there is an obvious language object on which I can instead call the printstr method. In the remaining 3 uses it is harder to know if the correct thing is to call printstr on the current language, or on a specific language. Currently obviously, we always call on the current language (as that's what LA_PRINT_STRING does), and clearly this behaviour is good enough right now, but is it "right"? I've left them for now and will give them more thought in the future. gdb/ChangeLog: * expprint.c (print_subexp_standard): Replace uses of LA_PRINT_STRING. * f-valprint.c (f_language::value_print_inner): Likewise. * guile/scm-pretty-print.c (ppscm_print_string_repr): Likewise. * p-valprint.c (pascal_language::value_print_inner): Likewise. * python/py-prettyprint.c (print_string_repr): Likewise. --- gdb/guile/scm-pretty-print.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gdb/guile') diff --git a/gdb/guile/scm-pretty-print.c b/gdb/guile/scm-pretty-print.c index 0bbcc4d..e08202c 100644 --- a/gdb/guile/scm-pretty-print.c +++ b/gdb/guile/scm-pretty-print.c @@ -675,8 +675,8 @@ ppscm_print_string_repr (SCM printer, enum display_hint hint, { struct type *type = builtin_type (gdbarch)->builtin_char; - LA_PRINT_STRING (stream, type, (gdb_byte *) string.get (), - length, NULL, 0, options); + language->printstr (stream, type, (gdb_byte *) string.get (), + length, NULL, 0, options); } else { -- cgit v1.1