From 80fd2826411c1033ec403658c5f3187bf9c1740a Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Tue, 1 Oct 2019 06:52:44 -0600 Subject: Fix type of startup_with_shell in gdbserver startup_with_shell was changed to be of "bool" type, but I noticed that the definition in gdbserver disagreed. This disagreement caused some regressions on a big-endian machine. This patch removes the redundant declaration and definition of startup_with_shell and ensures that such clashes will be diagnosed. This moves the declaration to common-inferior.h, and introduces a new common-inferior.c, as suggested by Pedro. gdb/ChangeLog 2019-10-02 Tom Tromey * Makefile.in (COMMON_SFILES): Add common-inferior.c. * gdbsupport/common-inferior.c: New file. * infcmd.c (startup_with_shell): Don't define. * nat/fork-inferior.h (startup_with_shell): Don't declare. * gdbsupport/common-inferior.h (startup_with_shell): Declare. * inferior.h (startup_with_shell): Don't declare. gdb/gdbserver/ChangeLog 2019-10-02 Tom Tromey * Makefile.in (SFILES): Add common-inferior.c. (OBS): Add common-inferior.o. * server.c (startup_with_shell): Don't define. --- gdb/gdbserver/ChangeLog | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'gdb/gdbserver/ChangeLog') diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 7eef2c5..0108d6d 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,9 @@ +2019-10-02 Tom Tromey + + * Makefile.in (SFILES): Add common-inferior.c. + (OBS): Add common-inferior.o. + * server.c (startup_with_shell): Don't define. + 2019-10-02 Andrew Burgess * linux-low.c (linux_low_read_btrace): Update for change to -- cgit v1.1