From a73c128df6e149c36940240f2b2198f9732ab6c7 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 9 Mar 2022 14:35:10 -0700 Subject: Remove eval_op_concat eval_op_concat has code to search for an operator overload of BINOP_CONCAT. However, the operator overloading code is specific to C++, which does not have this operator. And, binop_types_user_defined_p rejects this case right at the start, and value_x_binop does not handle this case. I think this code has been dead for a very long time. This patch removes it and hoists the remaining call into concatenation::evaluate, removing eval_op_concat entirely. --- gdb/expop.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'gdb/expop.h') diff --git a/gdb/expop.h b/gdb/expop.h index 1592568..d903ab0 100644 --- a/gdb/expop.h +++ b/gdb/expop.h @@ -83,10 +83,6 @@ extern struct value *eval_op_member (struct type *expect_type, struct expression *exp, enum noside noside, struct value *arg1, struct value *arg2); -extern struct value *eval_op_concat (struct type *expect_type, - struct expression *exp, - enum noside noside, - struct value *arg1, struct value *arg2); extern struct value *eval_op_add (struct type *expect_type, struct expression *exp, enum noside noside, @@ -1158,7 +1154,7 @@ public: = std::get<0> (m_storage)->evaluate_with_coercion (exp, noside); value *rhs = std::get<1> (m_storage)->evaluate_with_coercion (exp, noside); - return eval_op_concat (expect_type, exp, noside, lhs, rhs); + return value_concat (lhs, rhs); } enum exp_opcode opcode () const override -- cgit v1.1