From 7ebaa5f7821682c40e79ee1fdfe43528b7d87376 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 26 Aug 2021 18:17:40 -0600 Subject: Move value_true to value.h I noticed that value_true is declared in language.h and defined in language.c. However, as part of the value API, I think it would be better in one of those files. And, because it is very short, I changed it to be an inline function in value.h. I've also removed a comment from the implementation, on the basis that it seems obsolete -- if the change it suggests was needed, it probably would have been done by now; and if it is needed in the future, odds are it would be done differently anyway. Finally, this patch also changes value_true and value_logical_not to return a bool, and updates some uses. --- gdb/eval.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gdb/eval.c') diff --git a/gdb/eval.c b/gdb/eval.c index 1c5c8cf..bfab6d8 100644 --- a/gdb/eval.c +++ b/gdb/eval.c @@ -2204,7 +2204,7 @@ logical_and_operation::evaluate (struct type *expect_type, } else { - int tem = value_logical_not (arg1); + bool tem = value_logical_not (arg1); if (!tem) { arg2 = std::get<1> (m_storage)->evaluate (nullptr, exp, noside); @@ -2233,7 +2233,7 @@ logical_or_operation::evaluate (struct type *expect_type, } else { - int tem = value_logical_not (arg1); + bool tem = value_logical_not (arg1); if (tem) { arg2 = std::get<1> (m_storage)->evaluate (nullptr, exp, noside); -- cgit v1.1