From 4c9066e322f46faf9d753be6ff3e6a09ae668f86 Mon Sep 17 00:00:00 2001 From: Philippe Blain Date: Sun, 19 Feb 2023 17:37:35 -0500 Subject: gdb: add --with-curses to --configuration output 'gdb --configuration' does not mention if GDB was built with curses. Since b5075fb68d4 (Rename to allow_tui_tests, 2023-01-08) it does show --enable-tui (or --disable-tui), but one might want to know if GDB was built with curses independently of the availability of the TUI. Since configure.ac uses AC_SEARCH_LIBS to check for the curses library, we do not get an automatically defined HAVE_LIBCURSES symbol in config.in. We do have symbols defined by AC_CHECK_HEADERS (HAVE_CURSES_H, etc.) but it would be cumbersome to use those in print_gdb_configuration because we would have to check for all 6 symbols corresponding the 6 headers listed. This would also increase the maintenance burden if support for other variations of curses are added. Instead, define 'HAVE_LIBCURSES' ourselves by adding an 'action-if-found' argument to AC_SEARCH_LIBS, and use it in print_gdb_configuration. While at it, remove the condition on 'ac_cv_search_waddstr' and set 'curses_found' directly in 'action-if-found'. Change-Id: Id90e3d73990e169cee51bcc3e1d52072cfacd5b8 Approved-By: Simon Marchi --- gdb/configure | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'gdb/configure') diff --git a/gdb/configure b/gdb/configure index cfdaf59..6bce5c7 100755 --- a/gdb/configure +++ b/gdb/configure @@ -20624,13 +20624,13 @@ $as_echo "$ac_cv_search_waddstr" >&6; } ac_res=$ac_cv_search_waddstr if test "$ac_res" != no; then : test "$ac_res" = "none required" || LIBS="$ac_res $LIBS" + curses_found=yes -fi +$as_echo "#define HAVE_LIBCURSES 1" >>confdefs.h - if test "$ac_cv_search_waddstr" != no; then - curses_found=yes - fi +fi + fi # Check whether we should enable the TUI, but only do so if we really -- cgit v1.1