From 84d53fa9d281f057af5916f8663bc9a2872c5f6e Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 21 May 2020 13:12:29 -0400 Subject: gdb: remove unnecessary NULL checks before xfree I was inspired by a series of patches merged by Alan Modra in the other projects, so I did the same in GDB with a bit of Coccinelle and grep. This patch removes the unnecessary NULL checks before calls to xfree. They are unnecessary because xfree already does a NULL check. Since free is supposed to handle NULL values correctly, the NULL check in xfree itself is also questionable, but I've left it there for now. gdb/ChangeLog: * coffread.c (patch_type): Remove NULL check before xfree. * corefile.c (set_gnutarget): Likewise. * cp-abi.c (set_cp_abi_as_auto_default): Likewise. * exec.c (build_section_table): Likewise. * remote.c (remote_target::pass_signals): Likewise. * utils.c (n_spaces): Likewise. * cli/cli-script.c (document_command): Likewise. * i386-windows-tdep.c (core_process_module_section): Likewise. * linux-fork.c (struct fork_info) <~fork_info>: Likewise. --- gdb/cli/cli-script.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'gdb/cli') diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c index c9d2378..90ee67a 100644 --- a/gdb/cli/cli-script.c +++ b/gdb/cli/cli-script.c @@ -1528,8 +1528,7 @@ document_command (const char *comname, int from_tty) counted_command_line doclines = read_command_lines (prompt.c_str (), from_tty, 0, 0); - if (c->doc) - xfree ((char *) c->doc); + xfree ((char *) c->doc); { struct command_line *cl1; -- cgit v1.1