From df3ee9ca894f7e831713c332aa7820a6463c2435 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 2 Dec 2016 19:17:14 +0000 Subject: Support an "unlimited" number of user-defined arguments New in v2: - A few adjustments / simplifications were possible now that we require C++11: . Use std::unique_ptr to make the user_args_stack std::vector own its elements: static std::vector> user_args_stack; . use vector::emplace_back to construct elements directly in the corresponding vectors. . use std::to_string instead of adding a gdb::to_string replacement. - Now includes a test. Docs/NEWS are unchanged from v1 and have already been approved. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I recently wrote a user-defined command that could benefit from supporting an unlimited number of arguments: http://palves.net/list-active-signal-handlers-with-gdb/ E.g., 'info signal-dispositions 1 2 3 4 5 6 7 8 9 10 11' However, we currently only support up to 10 arguments passed to user-defined commands ($arg0..$arg9). I can't find a good reason for that, other than "old code with hard coded limits". This patch removes that limit and modernizes the code along the way: - Makes the user_args struct a real C++ class that uses std::vector for storage. - Removes the "next" pointer from within user_args and uses a std::vector to maintain a stack instead. - Adds a new RAII-based scoped_user_args_level class to help push/pop user args in the stack instead of using a cleanup. gdb/ChangeLog: 2016-12-02 Pedro Alves * NEWS: Mention that user commands now accept an unlimited number of arguments. * cli/cli-script.c: Include . (struct string_view): New type. (MAXUSERARGS): Delete. (struct user_args): Now a C++ class. (user_args_stack): New. (struct scoped_user_args_level): New type. (execute_user_command): Use scoped_user_args_level. (arg_cleanup): Delete. (setup_user_args): Deleted, and refactored as ... (user_args::user_args): ... this new constructor. Limit of number of arguments removed. (insert_user_defined_cmd_args): Defer to user_args_stack. (user_args::insert_args): New, bits based on old insert_user_defined_cmd_args with limit of number of arguments eliminated. gdb/doc/ChangeLog: 2016-12-02 Pedro Alves * gdb.texinfo (User-defined Commands): Limit on number of arguments passed to user-defined commands removed; update. gdb/testsuite/ChangeLog: 2016-12-02 Pedro Alves * gdb.base/commands.exp (user_defined_command_manyargs_test): New procedure. (top level): Call it. --- gdb/ChangeLog | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) (limited to 'gdb/ChangeLog') diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 2066268..777abc7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,25 @@ 2016-12-02 Pedro Alves + * NEWS: Mention that user commands now accept an unlimited number + of arguments. + * cli/cli-script.c: Include . + (struct string_view): New type. + (MAXUSERARGS): Delete. + (struct user_args): Now a C++ class. + (user_args_stack): New. + (struct scoped_user_args_level): New type. + (execute_user_command): Use scoped_user_args_level. + (arg_cleanup): Delete. + (setup_user_args): Deleted, and refactored as ... + (user_args::user_args): ... this new constructor. Limit of number + of arguments removed. + (insert_user_defined_cmd_args): Defer to user_args_stack. + (user_args::insert_args): New, bits based on old + insert_user_defined_cmd_args with limit of number of arguments + eliminated. + +2016-12-02 Pedro Alves + PR cli/20559 * NEWS: Mention "eval" expands user-defined command arguments. * cli/cli-script.c (execute_control_command): Adjust to rename. -- cgit v1.1