From bc3b087de2401c65c02730d346e8bea4dc0504ae Mon Sep 17 00:00:00 2001 From: Sergio Durigan Junior Date: Wed, 20 Sep 2017 19:15:40 -0400 Subject: Extend "set cwd" to work on gdbserver This is the "natural" extension necessary for the "set cwd" command (and the whole "set the inferior's cwd" logic) to work on gdbserver. The idea here is to have a new remote packet, QSetWorkingDir (name adopted from LLDB's extension to the RSP, as can be seen at ), which sends an hex-encoded string representing the working directory that the remote inferior will use. There is a slight difference from the packet proposed by LLDB: GDB's version will accept empty arguments, meaning that the user wants to clear the previously set working directory for the inferior (i.e., "set cwd" without arguments on GDB). For UNIX-like targets this feature is already implemented on nat/fork-inferior.c, and all gdbserver has to do is to basically implement "set_inferior_cwd" and call it whenever such packet arrives. For other targets, like Windows, it is possible to use the existing "get_inferior_cwd" function and do the necessary steps to make sure that the inferior will use the specified working directory. Aside from that, the patch consists basically of updates to the testcase (making it available on remote targets) and the documentation. No regressions found. gdb/ChangeLog: 2017-10-04 Sergio Durigan Junior * NEWS (Changes since GDB 8.0): Add entry about new 'set-cwd-on-gdbserver' feature. (New remote packets): Add entry for QSetWorkingDir. * common/common-inferior.h (set_inferior_cwd): New prototype. * infcmd.c (set_inferior_cwd): Remove "static". (show_cwd_command): Expand text to include remote debugging. * remote.c: Add PACKET_QSetWorkingDir. (remote_protocol_features) : New entry for PACKET_QSetWorkingDir. (extended_remote_set_inferior_cwd): New function. (extended_remote_create_inferior): Call "extended_remote_set_inferior_cwd". (_initialize_remote): Call "add_packet_config_cmd" for QSetWorkingDir. gdb/gdbserver/ChangeLog: 2017-10-04 Sergio Durigan Junior * inferiors.c (set_inferior_cwd): New function. * server.c (handle_general_set): Handle QSetWorkingDir packet. (handle_query): Inform that QSetWorkingDir is supported. * win32-low.c (create_process): Pass the inferior's cwd to CreateProcess. gdb/testsuite/ChangeLog: 2017-10-04 Sergio Durigan Junior * gdb.base/set-cwd.exp: Make it available on native-extended-gdbserver. gdb/doc/ChangeLog: 2017-10-04 Sergio Durigan Junior * gdb.texinfo (Starting your Program) : Mention remote debugging. (Working Directory) : Likewise. (Connecting) : Add "set-working-dir" and "QSetWorkingDir" to the table. (Remote Protocol) : New item, explaining the packet. --- gdb/ChangeLog | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'gdb/ChangeLog') diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ea4fc62..e113e2f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,22 @@ 2017-10-04 Sergio Durigan Junior + * NEWS (Changes since GDB 8.0): Add entry about new + 'set-cwd-on-gdbserver' feature. + (New remote packets): Add entry for QSetWorkingDir. + * common/common-inferior.h (set_inferior_cwd): New prototype. + * infcmd.c (set_inferior_cwd): Remove "static". + (show_cwd_command): Expand text to include remote debugging. + * remote.c: Add PACKET_QSetWorkingDir. + (remote_protocol_features) : New entry for + PACKET_QSetWorkingDir. + (extended_remote_set_inferior_cwd): New function. + (extended_remote_create_inferior): Call + "extended_remote_set_inferior_cwd". + (_initialize_remote): Call "add_packet_config_cmd" for + QSetWorkingDir. + +2017-10-04 Sergio Durigan Junior + * NEWS (New commands): Mention "set/show cwd". * cli/cli-cmds.c (_initialize_cli_cmds): Mention "set cwd" on "cd" command's help text. -- cgit v1.1