From 9ef9e6a6a0dd8f948708cb67c9afcfd0be40cb0a Mon Sep 17 00:00:00 2001 From: Keith Seitz Date: Mon, 8 Feb 2016 12:57:22 -0800 Subject: breakpoints/19546: Fix crash after updating breakpoints One of the last checks update_breakpoints_after_exec does while looping over the list of breakpoints is check that the breakpoint has a valid location spec. It uses event_location_empty_p to check if the location spec is "empty", and if it is, the breakpoint is deleted. momentary_breakpoint types rely on setting the breakpoint structure's location spec to NULL, thereby causing an update to delete the breakpoint. However, event_location_empty_p assumed that locations were never NULL. As a result, GDB would crash dereferencing a NULL pointer whenever update_breakpoints_after_exec would encounter a momentary_breakpoint. This patch creates a new wrapper/helper function which tests that the given breakpoint's location spec is non-NULL and if it is not "empty" or "unspecified." gdb/ChangeLog PR breakpoints/19546 * breakpoint.c (breakpoint_event_location_empty_p): New function. (update_breakpoints_after_exec, bkpt_re_set): Use this new function instead of event_location_empty_p. gdb/testsuite/ChangeLog PR breakpoints/19546 * gdb.base/infcall-exec.c: New file. * gdb.base/infcall-exec2.c: New file. * gdb.base/infcall-exec.exp: New file. --- gdb/ChangeLog | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'gdb/ChangeLog') diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 04daf07..e10f54b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,12 @@ 2016-02-09 Keith Seitz + PR breakpoints/19546 + * breakpoint.c (breakpoint_event_location_empty_p): New function. + (update_breakpoints_after_exec, bkpt_re_set): Use this new function + instead of event_location_empty_p. + +2016-02-09 Keith Seitz + * mi/mi-cmd-break.c (mi_cmd_break_insert_1): Use string_to_event_location_basic instead of string_to_event_location. -- cgit v1.1