From 535b785fb0c97220dea23a18f07baad6b5d77ae5 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Thu, 18 May 2017 14:47:40 +0930 Subject: Don't compare boolean values against TRUE or FALSE bfd/ * arc-got.h: Don't compare boolean values against TRUE or FALSE. * elf-m10300.c: Likewise. * elf.c: Likewise. * elf32-arc.c: Likewise. * elf32-bfin.c: Likewise. * elf32-m68k.c: Likewise. * elf32-nds32.c: Likewise. * elf32-tilepro.c: Likewise. * elflink.c: Likewise. * elfnn-aarch64.c: Likewise. * elfnn-riscv.c: Likewise. * elfxx-tilegx.c: Likewise. * mach-o.c: Likewise. * peXXigen.c: Likewise. * vms-alpha.c: Likewise. * vms-lib.c: Likewise. opcodes/ * aarch64-asm.c: Don't compare boolean values against TRUE or FALSE. * aarch64-dis.c: Likewise. * aarch64-gen.c: Likewise. * aarch64-opc.c: Likewise. binutils/ * strings.c: Don't compare boolean values against TRUE or FALSE. gas/ * config/tc-aarch64.c: Don't compare booleans against TRUE or FALSE. * config/tc-hppa.c: Likewise. * config/tc-mips.c: Likewise. * config/tc-score7.c: Likewise. ld/ * emultempl/elf32.em: Don't compare boolean values against TRUE or FALSE. * emultempl/pe.em: Likewise. * emultempl/pep.em: Likewise. * emultempl/xtensaelf.em: Likewise. --- gas/ChangeLog | 7 +++++++ gas/config/tc-aarch64.c | 10 +++++----- gas/config/tc-hppa.c | 2 +- gas/config/tc-mips.c | 2 +- gas/config/tc-score7.c | 2 +- 5 files changed, 15 insertions(+), 8 deletions(-) (limited to 'gas') diff --git a/gas/ChangeLog b/gas/ChangeLog index 9b0ea23..8605e59 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,10 @@ +2017-05-18 Alan Modra + + * config/tc-aarch64.c: Don't compare booleans against TRUE or FALSE. + * config/tc-hppa.c: Likewise. + * config/tc-mips.c: Likewise. + * config/tc-score7.c: Likewise. + 2017-05-16 Alan Modra * write.c (GENERIC_FORCE_RELOCATION_LOCAL): Define. diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index a9dbd54..72b98fd 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -992,7 +992,7 @@ parse_typed_reg (char **ccp, aarch64_reg_type type, aarch64_reg_type *rtype, return PARSE_FAIL; } - if (in_reg_list == TRUE) + if (in_reg_list) { first_error (_("index not allowed inside register list")); return PARSE_FAIL; @@ -3001,7 +3001,7 @@ parse_shift (char **str, aarch64_opnd_info *operand, enum parse_shift_mode mode) switch (mode) { case SHIFTED_LOGIC_IMM: - if (aarch64_extend_operator_p (kind) == TRUE) + if (aarch64_extend_operator_p (kind)) { set_syntax_error (_("extending shift is not permitted")); return FALSE; @@ -3092,7 +3092,7 @@ parse_shift (char **str, aarch64_opnd_info *operand, enum parse_shift_mode mode) operand->shifter.amount = 1; else if (exp.X_op == O_absent) { - if (aarch64_extend_operator_p (kind) == FALSE || exp_has_prefix) + if (!aarch64_extend_operator_p (kind) || exp_has_prefix) { set_syntax_error (_("missing shift amount")); return FALSE; @@ -4413,7 +4413,7 @@ find_best_match (const aarch64_inst *instr, const aarch64_opnd_qualifier_t *qualifiers = *qualifiers_list; /* Most opcodes has much fewer patterns in the list. */ - if (empty_qualifier_sequence_p (qualifiers) == TRUE) + if (empty_qualifier_sequence_p (qualifiers)) { DEBUG_TRACE_IF (i == 0, "empty list of qualifier sequence"); break; @@ -4621,7 +4621,7 @@ output_operand_error_record (const operand_error_record *record, char *str) { /* Most opcodes has much fewer patterns in the list. First NIL qualifier indicates the end in the list. */ - if (empty_qualifier_sequence_p (*qualifiers_list) == TRUE) + if (empty_qualifier_sequence_p (*qualifiers_list)) break; if (i != qlf_idx) diff --git a/gas/config/tc-hppa.c b/gas/config/tc-hppa.c index 1dbc097..724b48b 100644 --- a/gas/config/tc-hppa.c +++ b/gas/config/tc-hppa.c @@ -5687,7 +5687,7 @@ pa_ip (char *str) /* If this instruction is specific to a particular architecture, then set a new architecture. This automatic promotion crud is for compatibility with HP's old assemblers only. */ - if (match == TRUE + if (match && bfd_get_mach (stdoutput) < insn->arch && !bfd_set_arch_mach (stdoutput, bfd_arch_hppa, insn->arch)) { diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c index 7e927b2..ecd3c8e 100644 --- a/gas/config/tc-mips.c +++ b/gas/config/tc-mips.c @@ -6911,7 +6911,7 @@ can_swap_branch_p (struct mips_cl_insn *ip, expressionS *address_expr, break; } } - if (rv == FALSE) + if (!rv) { /* Insert nop after branch to fix short loop. */ return FALSE; diff --git a/gas/config/tc-score7.c b/gas/config/tc-score7.c index 758fac9..1c73110 100644 --- a/gas/config/tc-score7.c +++ b/gas/config/tc-score7.c @@ -6500,7 +6500,7 @@ s7_relax_frag (asection * sec ATTRIBUTE_UNUSED, else { /* Here, try best to do relax regardless fragp->fr_next->fr_type. */ - if (word_align_p == FALSE) + if (!word_align_p) { if (insn_size % 4 == 0) { -- cgit v1.1