From 2b804145796e948fa4c025c07eb201e700281e6b Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Wed, 5 Oct 2016 16:52:24 +1030 Subject: -Wimplicit-fallthrough error fixes Well, not all are errors, but a little more substantive than just fiddling with comments. bfd/ * coffcode.h (coff_slurp_symbol_table): Revert accidental commit made 2015-01-08. * elf32-nds32.c (nds32_elf_grok_psinfo): Add missing break. * reloc.c (bfd_default_reloc_type_lookup): Add missing breaks. opcodes/ * arc-ext.c (create_map): Add missing break. * msp430-decode.opc (encode_as): Likewise. * msp430-decode.c: Regenerate. binutils/ * coffdump.c (dump_coff_where): Add missing break. * stabs.c (stab_xcoff_builtin_type): Likewise. gas/ * config/tc-arc.c (find_opcode_match): Add missing break. * config/tc-i960.c (get_cdisp): Likewise. * config/tc-metag.c (parse_swap, md_apply_fix): Likewise. * config/tc-mt.c (md_parse_option): Likewise. * config/tc-nds32.c (nds32_apply_fix): Likewise. * config/tc-hppa.c (pa_ip): Assert rather than testing last condition of multiple if statements. * config/tc-s390.c (s390_exp_compare): Return 0 on error. * config/tc-tic4x.c (tic4x_operand_parse): Add as_bad and break out of case rather than falling into next case. Formatting. ld/ * plugin.c (asymbol_from_plugin_symbol): Avoid compiler warning by adding return. --- gas/config/tc-hppa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'gas/config/tc-hppa.c') diff --git a/gas/config/tc-hppa.c b/gas/config/tc-hppa.c index aea78dc..f5cdc2c 100644 --- a/gas/config/tc-hppa.c +++ b/gas/config/tc-hppa.c @@ -3505,8 +3505,9 @@ pa_ip (char *str) /* M bit is explicit in the major opcode. */ INSERT_FIELD_AND_CONTINUE (opcode, a, 2); } - else if (*args == 'e') + else { + gas_assert (*args == 'e'); /* Stash the ma/mb flag temporarily in the instruction. We will use (and remove it) later when handling 'J', 'K', '<' & '>'. */ -- cgit v1.1