From 9e223787a474c672c5f1cfd4574857241ae4eafa Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 14 Mar 2018 04:23:24 -0700 Subject: GC: Also check the local debug definition section Extend commit b7c871edcd83ccdc5fcd8148a7f433efd6b52255 Author: H.J. Lu Date: Wed May 17 07:57:15 2017 -0700 Mark debug sections referenced by kept debug sections to handle the local debug definition section. bfd/ PR ld/20882 * elflink.c (elf_gc_mark_debug_section): Also check the local debug definition section. ld/ PR ld/20882 * testsuite/ld-gc/pr20882.d: Also dump and check .debug_abbrev section. * testsuite/ld-gc/pr20882b.s: Add .debug_abbrev section. --- bfd/ChangeLog | 6 ++++++ bfd/elflink.c | 25 ++++++++++++++++++------- 2 files changed, 24 insertions(+), 7 deletions(-) (limited to 'bfd') diff --git a/bfd/ChangeLog b/bfd/ChangeLog index ddf0d04..ad971fc 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2018-03-14 H.J. Lu + + PR ld/20882 + * elflink.c (elf_gc_mark_debug_section): Also check the local + debug definition section. + 2018-03-13 Nick Clifton PR 22113 diff --git a/bfd/elflink.c b/bfd/elflink.c index 092edae..6a3d516 100644 --- a/bfd/elflink.c +++ b/bfd/elflink.c @@ -12802,20 +12802,31 @@ _bfd_elf_gc_mark_hook (asection *sec, return NULL; } -/* Return the global debug definition section. */ +/* Return the debug definition section. */ static asection * elf_gc_mark_debug_section (asection *sec ATTRIBUTE_UNUSED, struct bfd_link_info *info ATTRIBUTE_UNUSED, Elf_Internal_Rela *rel ATTRIBUTE_UNUSED, struct elf_link_hash_entry *h, - Elf_Internal_Sym *sym ATTRIBUTE_UNUSED) + Elf_Internal_Sym *sym) { - if (h != NULL - && (h->root.type == bfd_link_hash_defined - || h->root.type == bfd_link_hash_defweak) - && (h->root.u.def.section->flags & SEC_DEBUGGING) != 0) - return h->root.u.def.section; + if (h != NULL) + { + /* Return the global debug definition section. */ + if ((h->root.type == bfd_link_hash_defined + || h->root.type == bfd_link_hash_defweak) + && (h->root.u.def.section->flags & SEC_DEBUGGING) != 0) + return h->root.u.def.section; + } + else + { + /* Return the local debug definition section. */ + asection *isec = bfd_section_from_elf_index (sec->owner, + sym->st_shndx); + if ((isec->flags & SEC_DEBUGGING) != 0) + return isec; + } return NULL; } -- cgit v1.1