From 97373b2eba6077d5059370a95931b93a8b118813 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Fri, 18 May 2018 14:23:41 -0700 Subject: x86: Don't set eh->local_ref to 1 for versioned symbol bfd_hide_sym_by_version can't be used to check if a versioned symbol is hidden. It has to be synced with _bfd_elf_link_assign_sym_version to get the correct answer. bfd/ PR ld/23194 * elfxx-x86.c (_bfd_x86_elf_link_symbol_references_local): Don't set eh->local_ref to 1 if a symbol is versioned and there is a version script. ld/ PR ld/23194 * testsuite/ld-i386/i386.exp: Run pr23194. * testsuite/ld-x86-64/x86-64.exp: Likewise. * testsuite/ld-i386/pr23194.d: New file. * testsuite/ld-i386/pr23194.map: Likewise. * testsuite/ld-i386/pr23194.s: Likewise. * testsuite/ld-x86-64/pr23194.d: Likewise. * testsuite/ld-x86-64/pr23194.map: Likewise. * testsuite/ld-x86-64/pr23194.s: Likewise. --- bfd/elfxx-x86.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'bfd/elfxx-x86.c') diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c index f4dbddf..29d92d2 100644 --- a/bfd/elfxx-x86.c +++ b/bfd/elfxx-x86.c @@ -2048,8 +2048,11 @@ _bfd_x86_elf_link_symbol_references_local (struct bfd_link_info *info, } /* Symbols created by HIDDEN and PROVIDE_HIDDEN assignments in linker - script aren't forced local here yet. */ - if (!h->root.ldscript_def) + script aren't forced local here yet. bfd_hide_sym_by_version + can't be used to check if a versioned symbol is hidden. It has to + be syncd with _bfd_elf_link_assign_sym_version to get the correct + answer. */ + if (!h->root.ldscript_def && h->versioned == unversioned) eh->local_ref = 1; return FALSE; -- cgit v1.1