From ebd2263ba9a9124d93bbc0ece63d7e0fae89b40e Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Fri, 8 Mar 2019 22:41:55 +1030 Subject: PR24311, FAIL: S-records with constructors Not padding string merge section output to its alignment can cause failures of the S-record tests when input string merge sections are padded, since the ELF linker output for the single string section would shrink compared to the SREC linker output. That might result in following sections having different addresses. On the other hand, padding string merge section output when input string merge sections are *not* padded can also cause failures, in this case due to the ELF linker output for the string section being larger (due to padding) than the SREC linker output. It would be better to write a more robust test, but it is also nice to leave input unchanged when no string merges occur. PR 24311 * merge.c (merge_strings): Return secinfo. Don't pad section to alignment here. (_bfd_merge_sections): Pad section to alignment here, if input sections contributing to merged output all pad to alignment. Formatting. --- bfd/ChangeLog | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'bfd/ChangeLog') diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 15a5a99..18f1804 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,12 @@ +2019-03-08 Alan Modra + + PR 24311 + * merge.c (merge_strings): Return secinfo. Don't pad section + to alignment here. + (_bfd_merge_sections): Pad section to alignment here, if input + sections contributing to merged output all pad to alignment. + Formatting. + 2019-03-06 Nick Clifton * dwarf2.c (_bfd_dwarf2_find_symbol_bias): Check for a NULL symbol -- cgit v1.1