From af96cdd410deaf4869f4bc8e5889c6f382dd4335 Mon Sep 17 00:00:00 2001 From: Indu Bhagat Date: Sat, 29 Jun 2024 14:06:11 -0700 Subject: include: opcodes: aarch64: define new subclasses [New in V4] The existing iclass information tells us the general shape and purpose of the instructions. In some cases, however, we need to further disect the iclass on the basis of other finer-grain information. E.g., for the purpose of SCFI, we need to know whether a given insn with iclass of ldst_* is a load or a store. Similarly, whether a particular arithmetic insn is an add or sub or mov, etc. This patch defines new flags to demarcate the insns. Also provide an access function for subclass lookup. Later, we will enforce (in aarch64-gen.c) that if an iclass has at least one instruction with a non-zero subclass, all instructions of the iclass must have a non-zero subclass information. If none of the defined subclasses are applicable (or not required for SCFI purposes), F_SUBCLASS_OTHER can be used for such instructions. include/ * opcode/aarch64.h (F_SUBCLASS): New flag. (F_SUBCLASS_OTHER): Likewise. (F_LDST_LOAD): Likewise. (F_LDST_STORE): Likewise. (F_LDST_SWAP): Likewise. (F_ARITH_ADD): Likewise. (F_ARITH_SUB): Likewise. (F_ARITH_MOV): Likewise. (F_BRANCH_CALL): Likewise. (F_BRANCH_RET): Likewise. (F_MAX_SUBCLASS): Likewise. (aarch64_opcode_subclass_p): New definition. --- include/opcode/aarch64.h | 32 +++++++++++++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/include/opcode/aarch64.h b/include/opcode/aarch64.h index 9daa911..56ded7c 100644 --- a/include/opcode/aarch64.h +++ b/include/opcode/aarch64.h @@ -1367,7 +1367,31 @@ extern const aarch64_opcode aarch64_opcode_table[]; #define F_OPD_SIZE (1ULL << 34) /* RCPC3 instruction has the field of 'size'. */ #define F_RCPC3_SIZE (1ULL << 35) -/* Next bit is 36. */ + +/* 4-bit flag field to indicate subclass of instructions. + The available 14 nonzero values are consecutive, with room for + more subclasses in future. */ +#define F_SUBCLASS (15ULL << 36) + +#define F_SUBCLASS_OTHER (F_SUBCLASS) + +#define F_LDST_LOAD (1ULL << 36) +#define F_LDST_STORE (2ULL << 36) +/* A load followed by a store (using the same address). */ +#define F_LDST_SWAP (3ULL << 36) +/* Subclasses to denote add, sub and mov insns. */ +#define F_ARITH_ADD (4ULL << 36) +#define F_ARITH_SUB (5ULL << 36) +#define F_ARITH_MOV (6ULL << 36) +/* Subclasses to denote call and ret insns. */ +#define F_BRANCH_CALL (7ULL << 36) +#define F_BRANCH_RET (8ULL << 36) + +#define F_SUBCLASS_OTHER (F_SUBCLASS) +/* PS: To perform some sanity checks, the last declared subclass flag is used. + Keep F_MAX_SUBCLASS updated when declaring new subclasses. */ +#define F_MAX_SUBCLASS (F_BRANCH_RET) +/* Next bit is 40. */ /* Instruction constraints. */ /* This instruction has a predication constraint on the instruction at PC+4. */ @@ -1406,6 +1430,12 @@ pseudo_opcode_p (const aarch64_opcode *opcode) return (opcode->flags & F_PSEUDO) != 0lu; } +static inline bool +aarch64_opcode_subclass_p (const aarch64_opcode* opcode, uint64_t flag) +{ + return ((opcode->flags & F_SUBCLASS) == flag); +} + /* Deal with two possible scenarios: If F_OP_PAIR_OPT not set, as is the case by default, F_OPDn_OPT must equal IDX + 1, else F_OPDn_OPT must be in range [IDX, IDX + 1]. */ -- cgit v1.1