From a16034bf6417dc2259fef43fd5bcc2dd1dac562f Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Tue, 13 Feb 2024 15:53:28 +0100 Subject: [gdb/testsuite] Fix fail in gdb.dap/sources.exp With test-case gdb.dap/sources.exp, I run into: ... {"request_seq": 4, "type": "response", "command": "source", \ "success": false, "message": "notStopped", \ "seq": 11}FAIL: gdb.dap/sources.exp: get source success ... The fail happens because the request races with the stopping at main as requested by: ... if {[dap_launch $testfile stop_at_main 1] == ""} { ... Fix this by waiting for the stop, in the same way that is done in other test-cases that use stop_at_main. Tested on x86_64-linux. Approved-By: Tom Tromey PR testsuite/31374 https://sourceware.org/bugzilla/show_bug.cgi?id=31374 --- gdb/testsuite/gdb.dap/sources.exp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gdb/testsuite/gdb.dap/sources.exp b/gdb/testsuite/gdb.dap/sources.exp index f601190..9b56337 100644 --- a/gdb/testsuite/gdb.dap/sources.exp +++ b/gdb/testsuite/gdb.dap/sources.exp @@ -46,6 +46,9 @@ if {$path == ""} { } else { pass "sources.c in loadedSources" + dap_wait_for_event_and_check "stopped at function breakpoint" stopped \ + "body reason" breakpoint + set obj [dap_check_request_and_response "get source" source \ [format {o source [o path [s %s]] \ sourceReference [i 0]} $path]] -- cgit v1.1