From 1b493192488ccb9886ffe709864e5f5c0588b004 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Tue, 26 Mar 2013 20:19:31 +0000 Subject: Make "set/show remoteaddresssize" a zuinteger command instead of uinteger. It makes no sense to talk about an "unlimited" address size in this context. (gdb) show remoteaddresssize The maximum size of the address (in bits) in a memory packet is 0. (gdb) set remoteaddresssize 0 (gdb) show remoteaddresssize The maximum size of the address (in bits) in a memory packet is unlimited. "set remoteaddresssize 0" mapping to UINT_MAX means you can't force gdb through this path twice in the same GDB run: static CORE_ADDR remote_address_masked (CORE_ADDR addr) { unsigned int address_size = remote_address_size; /* If "remoteaddresssize" was not set, default to target address size. */ if (!address_size) address_size = gdbarch_addr_bit (target_gdbarch ()); gdb/ 2013-03-26 Pedro Alves * remote.c (_initialize_remote): Make "set remoteaddresssize" a zuinteger command instead of uinteger. --- gdb/ChangeLog | 5 +++++ gdb/remote.c | 10 +++++----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e181242..eef0a25 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2013-03-26 Pedro Alves + * remote.c (_initialize_remote): Make "set remoteaddresssize" + a zuinteger command instead of uinteger. + +2013-03-26 Pedro Alves + * record-full.c (record_full_insn_num): Make it unsigned. (record_full_check_insn_num, record_full_message) (record_full_registers_change, record_full_xfer_partial): Remove diff --git a/gdb/remote.c b/gdb/remote.c index c66618e..ce477cf 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -11773,13 +11773,13 @@ Specify a negative limit for unlimited."), breakpoints is %s. */ &remote_set_cmdlist, &remote_show_cmdlist); - add_setshow_uinteger_cmd ("remoteaddresssize", class_obscure, - &remote_address_size, _("\ + add_setshow_zuinteger_cmd ("remoteaddresssize", class_obscure, + &remote_address_size, _("\ Set the maximum size of the address (in bits) in a memory packet."), _("\ Show the maximum size of the address (in bits) in a memory packet."), NULL, - NULL, - NULL, /* FIXME: i18n: */ - &setlist, &showlist); + NULL, + NULL, /* FIXME: i18n: */ + &setlist, &showlist); add_packet_config_cmd (&remote_protocol_packets[PACKET_X], "X", "binary-download", 1); -- cgit v1.1