aboutsummaryrefslogtreecommitdiff
path: root/gdb
AgeCommit message (Collapse)AuthorFilesLines
2013-07-05gdb/testsuite/Yao Qi5-24/+7
* boards/local-remote-host.exp: Remove obsolete comments. * boards/native-extended-gdbserver.exp: Likewise. * boards/native-gdbserver.exp: Likewise. * boards/native-stdio-gdbserver.exp: Likewise.
2013-07-04Use allocate_optimized_out_value instead of set_value_optimized_out.Pedro Alves3-6/+16
Allocate the value as optimized out from the start rather than allocating a value with contents, and then marking it optimized out. gdb/ 2013-07-04 Pedro Alves <palves@redhat.com> * findvar.c (value_of_register): Use allocate_optimized_out_value if the register has been optimized out, instead of set_value_optimized_out. * frame-unwind.c (frame_unwind_got_optimized): Use allocate_optimized_out_value.
2013-07-04value_bits_valid: Fix latent bug.Pedro Alves2-1/+7
Doing something else, I factored out the bits of the value_bits_valid function that actually handle the check_validity hook, and surprisingly found out that the result was misbehaving. Turns out value_bits_valid has a latent bug. If the value is not lval_computed, or doesn't have a check_validity hook, then we should assume the value is entirely valid, not invalid. This is currently masked by the value->optimized_out check -- I ran the testsuite with a gdb_assert(0) inserted in place of that return being touched by the patch, and it never triggers. Tested on x86_64 Fedora 17. gdb/ 2013-07-04 Pedro Alves <palves@redhat.com> * value.c (value_bits_valid): If the value is not lval_computed, or doesn't have a check_validity hook, assume the value is entirely valid.
2013-07-04http://sourceware.org/ml/gdb-patches/2013-07/msg00059.htmlAndrew Burgess7-41/+694
gdb/ChangeLog * stack.c (read_frame_arg): No longer fetch lazy values. * value.c (value_optimized_out): If the value is not already marked optimized out, and is lazy then fetch it. (value_primitive_field): Move optimized out check to later in the function, after we have loaded any lazy values. (value_fetch_lazy): Use optimized out flag directly rather than calling optimized_out method. gdb/testsuite/ChangeLog * gdb.dwarf2/dw2-reg-undefined.exp: New file. * gdb.dwarf2/dw2-reg-undefined.c: Likewise. * gdb.dwarf2/dw2-reg-undefined.S: Likewise.
2013-07-04http://sourceware.org/ml/gdb-patches/2013-07/msg00056.htmlAndrew Burgess3-162/+169
* valops.c: Don't include "user-regs.h". (value_fetch_lazy): Moved to value.c. * value.c: Include "user-regs.h". (value_fetch_lazy): Moved from valops.c.
2013-07-04gdb/Yao Qi6-36/+56
2013-07-04 Yao Qi <yao@codesourcery.com> Revert: 2013-06-27 Yao Qi <yao@codesourcery.com> * common/create-version.sh: Update comments. Handle the case that TARGET_ALIAS is empty. gdb/gdbserver/ 2013-07-04 Yao Qi <yao@codesourcery.com> * Makefile.in (host_alias): Use @host_noncanonical@. (target_alias): Use @target_noncanonical@. * configure.ac: Use ACX_NONCANONICAL_TARGET and ACX_NONCANONICAL_HOST. * configure: Regenerated. Revert: 2013-06-28 Mircea Gherzan <mircea.gherzan@intel.com> * configure.ac (version_host, version_target): Set and AC_SUBST them. * configure: Rebuild. * Makefile.in (version_host, version_target): Get from configure. (version.c): Use $(version_host) and $(version_target).
2013-07-03On mainline/development, also link GDBserver with -lmcheck.Pedro Alves12-56/+216
This factors --enable-libmcheck related bits from GDB's configure.ac and makes GDBserver use them too. Specifically, the 'development' global is moved to a separate script to it can be sourced by both GDB and GDBserver, and the --enable-libmcheck/--disable-libmcheck bits proper are moved to a new m4 file. I started out by defining 'development' in the m4 file, but in the end decided against it, as a separate script has the advantage that changing it in release branches does not require regenerating configure, unlike today. I had also started out by making the new GDB_AC_LIBMCHECK itself handle the yes/no default fallback depending on release/developement, but since I had split out 'development' to a separate script, and, GDB needs the python checks anyway (hence we'd need to do the python checks in gdb's configure.ac, and pass in a 'default lmcheck yes/no' parameter to GDB_AC_LIBMCHECK anyway), I ended up keeping GDB_AC_LIBMCHECK isolated from the 'development' global. IOW, it's the caller's business to handle it. Tested on x86_64 Fedora 17. Built GDB and GDBserver with and without --enable-libmcheck, and observed --enable-libmcheck overrides the disablement of -lmcheck caused by python supporting threads, and that GDBserver links with -lmcheck when expected. Also observed that changing the 'development' global, and issuing "make" triggers a relink, and '-lmcheck' is included or not from the link accordingly. gdb/ 2013-07-03 Pedro Alves <palves@redhat.com> * Makefile.in (config.status): Depend on development.sh. (aclocal_m4_deps): Add libmcheck.m4. * acinclude.m4: Include libmcheck.m4. * configure.ac: Source development.sh instead of setting 'development' here. --enable-libmcheck/--disable-libmcheck code factored out to GDB_AC_LIBMCHECK. Run it. * development.sh: New file. * libmcheck.m4: New file. * configure: Regenerate. gdb/gdbserver/ 2013-07-03 Pedro Alves <palves@redhat.com> * Makefile.in (config.status): Depend on development.sh. * acinclude.m4: Include libmcheck.m4. * configure: Regenerate.
2013-07-02gdb/testsuite/Jan Kratochvil2-2/+10
* gdb.base/break-on-linker-gcd-function.exp: Replace prepare_for_testing by build_executable_from_specs and clean_restart.
2013-07-02 * contrib/ari/update-web-ari.sh: Update for version.in change.Tom Tromey2-1/+6
2013-07-02 * common/ptid.h: Comment fixes.Tom Tromey2-2/+6
2013-07-02remove mention of "target nrom"Tom Tromey2-10/+4
The documentation refers to "target nrom", but this target doesn't appear in the tree. It was zapped here: 2002-12-16 Andrew Cagney <ac131313@redhat.com> [...] * remote-nrom.c, remote-os9k.c, remote-vx960.c: Delete. This patch removes the reference from the documentation. * gdb.texinfo (Target Commands): Don't mention "target nrom".
2013-07-02gdbserver, win32: fix some function typedefsMircea Gherzan2-4/+12
2013-05-25 Mircea Gherzan <mircea.gherzan@intel.com> gdbserver/ * win32-low.c (winapi_DebugActiveProcessStop): Move the WINAPI attribute inside the parentheses. (winapi_DebugSetProcessKillOnExit): Ditto. (winapi_DebugBreakProcess): Ditto. (winapi_GenerateConsoleCtrlEvent): Ditto. Change-Id: I3aab72f2a1725a46b9da0e41a4ba08d7886284b9 Signed-off-by: Mircea Gherzan <mircea.gherzan@intel.com>
2013-07-02gdbserver: avoid empty structsMircea Gherzan2-0/+7
2013-06-25 Mircea Gherzan <mircea.gherzan@intel.com> gdbserver/ * notif.h (notif_event): Add a dummy member to avoid compiler errors. Change-Id: I490dbdb70a24f52b3947371f7c0397bf7a18423c Signed-off-by: Mircea Gherzan <mircea.gherzan@intel.com>
2013-07-01change gdb to use BFD's "dwz" functionsTom Tromey2-22/+31
BFD recently got a few functions related to "dwz" files. This patch changes gdb to use them, just to share a bit more code. This changes dwarf2_get_dwz_file to possibly return NULL. This simplified a bit of code elsewhere. Built and regtested on x86-64 Fedora 18. I specifically regtested it using my pending dwz test case. * dwarf2read.c (dwarf2_get_dwz_file): Return NULL if .gnu_debugaltlink not found. Use bfd_get_alt_debug_link_info. (dwarf2_read_index, create_all_comp_units): Update.
2013-07-01add -Wold-style-definitionTom Tromey5-4/+13
This adds -Wold-style-definition to gdb's list of warnings. This found a couple of spots where "()" was used where "(void)" is more correct. Tested by rebuilding on x86-64 Fedora 18. * configure.ac (build_warnings): Add -Wold-style-definition. * configure: Rebuild. * machoread.c (_initialize_machoread): Use "(void)". * macrocmd.c (macro_inform_no_debuginfo): Fix formatting; use "(void)".
2013-07-01add -Wold-style-declarationTom Tromey11-16/+39
This adds -Wold-style-declaration to gdb's list of warnings. It turns out that a few places use "const static" rather than "static const". The former is deprecated according to the C standard. Tested by rebuilding with --enable-targets=all on x86-64 Fedora 18. * configure.ac (build_warnings): Add -Wold-style-declaration. * configure: Rebuild. * dsrec.c (make_srec): Use "static const", not "const static". * h8300-tdep.c (h8300_breakpoint_from_pc): Use "static const", not "const static". * mi/mi-parse.c (mi_no_values, mi_simple_values, mi_all_values): Use "static const", not "const static". * mn10300-tdep.c (mn10300_breakpoint_from_pc): Use "static const", not "const static". * moxie-tdep.c (moxie_breakpoint_from_pc): Use "static const", not "const static". * rs6000-tdep.c (rs6000_breakpoint_from_pc): Use "static const", not "const static". * v850-tdep.c (v850_breakpoint_from_pc): Use "static const", not "const static". (v850_dbtrap_breakpoint_from_pc): Likewise. * xstormy16-tdep.c (xstormy16_breakpoint_from_pc): Use "static const", not "const static".
2013-07-01add -Wmissing-parameter-typeTom Tromey3-2/+7
This adds -Wmissing-parameter-type to gdb's list of warnings. This one doesn't happen to trigger for a --enable-targets=all build on x86-64 Fedora 18. * configure.ac (build_warnings): Add -Wmissing-parameter-type. * configure: Rebuild.
2013-07-01[GDBserver] hostio.c: Fallback to packet buffer size if PATH_MAX is not ↵Pedro Alves2-4/+18
available. PATH_MAX is not defined on systems which have no limit on filename length, such as GNU/Hurd. As designed, the hostio RSP packets carry the paths as parameters in the request/reply packets, which themselves have an upper size limit, so lifting the filename limit completely would require a redesign with new hostio packets. While that doesn't happen, we can at least support filename lengths as long as the packet buffer can fit. gdb/gdbserver/ 2013-07-01 Pedro Alves <palves@redhat.com> * hostio.c (HOSTIO_PATH_MAX): Define. (require_filename, handle_open, handle_unlink, handle_readlink): Use it.
2013-07-01Normalize on PATH_MAX instead of MAXPATHLEN throughout.Pedro Alves26-59/+72
With the pathmax gnulib module in place, we can use PATH_MAX consistently throughout, instead of the current mixbag of PATH_MAX and MAXPATHLEN uses. It's no longer necessary to include sys/param.h (supposedly, I can't check all ports touched here) for MAXPATHLEN. Don't remove sys/param.h from GDB's configure.ac, as later tests in the file use HAVE_SYS_PARAM_H checks. Tested on x86_64 Fedora 17. Also cross-built for --host=i686-w64-mingw32, and --host=i586-pc-msdosdjgpp. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> * defs.h: Include "pathmax.h". * utils.c: Don't include sys/param.h. (gdb_realpath): Remove code that checks for MAXPATHLEN. * solib-ia64-hpux.c (ia64_hpux_handle_load_event): Use PATH_MAX instead of MAXPATHLEN. * solib-sunos.c: Don't include sys/param.h. * xcoffread.c: Don't include sys/param.h. * bsd-kvm.c: Don't include sys/param.h. * darwin-nat.c: Don't include sys/param.h. (darwin_pid_to_exec_file): Use PATH_MAX instead of MAXPATHLEN. * darwin-nat-info.c: Don't include sys/param.h. * fbsd-nat.c (fbsd_pid_to_exec_file): Use PATH_MAX instead of MAXPATHLEN. * i386obsd-nat.c: Don't include sys/param.h. * inf-child.c: Don't include sys/param.h. (inf_child_fileio_readlink): Use PATH_MAX instead of MAXPATHLEN. * linux-fork.c: Don't include sys/param.h. (fork_save_infrun_state): Use PATH_MAX instead of MAXPATHLEN. * linux-nat.c: Don't include sys/param.h. (linux_child_pid_to_exec_file, linux_proc_pending_signals) (linux_proc_pending_signals): Use PATH_MAX instead of MAXPATHLEN. * m68klinux-nat.c: Don't include sys/param.h. * nbsd-nat.c: Don't include sys/param.h. (nbsd_pid_to_exec_file): Use PATH_MAX instead of MAXPATHLEN. * ppc-linux-nat.c: Don't include sys/param.h. * rs6000-nat.c: Don't include sys/param.h. * spu-linux-nat.c. Don't include sys/param.h. * windows-nat.c: Don't include sys/param.h. * xtensa-linux-nat.c: Don't include sys/param.h. * config/i386/nm-fbsd.h: Don't include sys/param.h. gdb/gdbserver/ 2013-07-01 Pedro Alves <palves@redhat.com> * server.h: Include "pathmax.h". * linux-low.c: Don't include sys/param.h. (linux_pid_exe_is_elf_64_file): Use PATH_MAX instead of MAXPATHLEN. * win32-low.c: Don't include sys/param.h. (win32_create_inferior): Use PATH_MAX instead of MAXPATHLEN.
2013-07-01Import the "pathmax" gnulib module.Pedro Alves12-5/+169
This imports the "pathmax" gnulib module, making PATH_MAX always available on systems that have the notion of a constant max path limit (i.e., practically everywhere except the Hurd), along with fixing a couple broken systems --- see pathmax.h in the patch. This means we can normalize on PATH_MAX throughout the tree (instead of some places using MAXPATHLEN, or defining fallback constants ourselves). This is the just the importing step. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add pathmax. * gnulib/Makefile.in (aclocal_m4_deps): Add import/m4/pathmax.m4. * gnulib/aclocal.m4: Regenerate. * gnulib/config.in: Regenerate. * gnulib/configure: Regenerate. * gnulib/import/pathmax.h: New file. * gnulib/import/Makefile.am: Regenerate. * gnulib/import/Makefile.in: Regenerate. * gnulib/import/m4/gnulib-cache.m4: Regenerate. * gnulib/import/m4/gnulib-comp.m4: Regenerate. * gnulib/import/m4/pathmax.m4: New file.
2013-07-01Reimplement DJGPP's .gdbinit -> gdb.ini renaming.Pedro Alves7-17/+42
This simplifies the .gdbinit filename selection logic. We have a GDBINIT_FILENAME define that supposedly configurations would override, but none do so. Instead, the only configuration that wants a different file name instead of ".gdbinit", djgpp, does a strcpy over the gdbinit global array. This means the array needs to be sized, and the code that does that is doing the usual 'PATH_MAX/FILENAME_MAX/fallback constant/etc.' mess. Instead of all that, it's much simpler to have configure specificy the .gdbinit filename. As bonus, we can then make the "gdbinit" global array const. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> * configure.ac (GDBINIT): Define, depending on host. * go32-nat.c (init_go32_ops): Don't override gdbinit here. * top.c (PATH_MAX): Delete fallback definition. (GDBINIT_FILENAME): Delete. (gdbinit): Reimplement as const char array set to the GDBINIT string constant. * top.h (gdbinit): Make const.
2013-07-01Constify main.c:get_init_files.Pedro Alves6-21/+58
A following patch will want to make the "gdbinit" global array const. As usual, that forces in a cascading series of const additions. This patch preemptively does those. I went all the way up to constifying catch_command_errors, but then that would require constifying execute_command as well (which is a much more significant effort). So as stop point, I found the cleanest would be to add a variant of catch_command_errors that takes const args, and use that in the few spots that needed it due to the the get_init_files constification. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> * cli/cli-cmds.c (source_script): Make 'file' parameter const. * cli/cli-cmds.h (source_script): Likewise. * exceptions.c (catch_command_errors_const): New function. * exceptions.h (catch_command_errors_const): Declare. * main.c (get_init_files): Make parameters const, and adjust. (captured_main): Make 'system_gdbinit', 'home_gdbinit' and 'local_gdbinit' locals const. Adjust to use catch_command_errors_const. (print_gdb_help): Make 'system_gdbinit', 'home_gdbinit' and 'local_gdbinit' locals const.
2013-07-01Rely on gnulib's unistd.h replacement.Pedro Alves10-26/+19
With gnulib's unistd module, we can assume unistd.h is always present, and that STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO are always defined. Don't remove unistd.h from GDB's configure.ac, as later tests in the file use HAVE_UNISTD_H checks. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> * defs.h: Don't check HAVE_UNISTD_H before including <unistd.h>. (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO): Delete. * tracepoint.c: Don't check HAVE_UNISTD_H before including <unistd.h>. gdb/gdbserver/ 2013-07-01 Pedro Alves <palves@redhat.com> * event-loop.c: Don't check HAVE_UNISTD_H before including <unistd.h>. * gdbreplay.c: Likewise. * remote-utils.c: Likewise. * server.c: Likewise. * configure.ac: Don't check for unistd.h. * configure: Regenerate.
2013-07-01Import the "unistd" gnulib module.Pedro Alves17-56/+3091
I wanted to import the pathmax module, and that pulls in the unistd module as dependency. The unistd module is actually bigger than the pathmax module. If we're going to end up with it, might as well import it explicitly, and make use of it throughout. The "unistd" module makes a GNU-like <unistd.h> always available. This means we no longer need to do: +#ifdef HAVE_UNISTD_H #include <unistd.h> +#endif and we can remove a few constants from defs.h. This is just the importing step. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> Import the "unistd" gnulib module. * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add "unistd". * gnulib/Makefile.in (aclocal_m4_deps): Add import/m4/off_t.m4, import/m4/ssize_t.m4, import/m4/sys_types_h.m4 and import/m4/unistd_h.m4. * gnulib/aclocal.m4: Renenerate. * gnulib/config.in: Renenerate. * gnulib/configure: Renenerate. * gnulib/import/Makefile.am: Renenerate. * gnulib/import/Makefile.in: Renenerate. * gnulib/import/m4/gnulib-cache.m4: Renenerate. * gnulib/import/m4/gnulib-comp.m4: Renenerate. * gnulib/import/m4/off_t.m4: New file. * gnulib/import/m4/ssize_t.m4: New file. * gnulib/import/m4/sys_types_h.m4: New file. * gnulib/import/m4/unistd_h.m4: New file. * gnulib/import/sys_types.in.h: New file. * gnulib/import/unistd.c: New file. * gnulib/import/unistd.in.h: New file.
2013-07-01utils.c: pathconf call, check for _PC_PATH_MAX instead of HAVE_UNISTD_H.Pedro Alves2-1/+6
This check in utils.c for HAVE_UNISTD_H is being used as proxy for "HAVE_PATHCONF", as pathconf is supposed to be declared in unistd.h. It's possible that there are systems out there that have realpath, unistd.h and alloca, but not pathconf+_PC_PATH_MAX. I don't know of any by heart, but if we import gnulib's unistd module (which a following patch will do), then unistd.h ends up always available, so the check ends up incorrect. As pathconf is being called with _PC_PATH_MAX, check for that instead. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> * utils.c <pathconf/_PC_PATH_MAX use>: Check if _PC_PATH_MAX is defined instead of checking HAVE_UNISTD_H.
2013-07-01Reimport gnulib from scratch.Pedro Alves7-442/+56
Moving aside gnulib/import/, and re-running our gnulib/update-gnulib.sh script, surprisingly, one gets a different result compared to what's in the tree. This is with pristine FSF autoconf and FSF automake, at the versions required by update-gnulib.sh. However, if one just runs the update-gnulib.sh scripts against the _existing_ tree, then nothing changes... I suspect gnulib-tool's merge logic might be preserving some things by design. This gets rid of cruft that might have accumulated over gnulib updates. onceonly.m4 seems to fit in that category. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> Reimport gnulib from scratch. * gnulib/Makefile.in (aclocal_m4_deps): Remove reference to import/m4/onceonly.m4. * gnulib/aclocal.m4: Renegerate. * gnulib/config.in: Renegerate. * gnulib/configure: Renegerate. * gnulib/import/Makefile.in: Renegerate. * gnulib/import/extra/update-copyright: Renegerate. * gnulib/import/m4/onceonly.m4: Delete.
2013-07-01Delete pagination_enabled extern declaration in tui/tui-regs.c.Pedro Alves2-2/+4
It's declared in utils.h. gdb/ 2013-07-01 Pedro Alves <palves@redhat.com> * tui/tui-regs.c (pagination_enabled): Delete declaration.
2013-06-30gdb/Jan Kratochvil3-4/+8
Code cleanup. * remote.c (async_remote_interrupt_twice): Make it static. * remote.h (async_remote_interrupt_twice): Remove the declaration.
2013-06-30This patch implements the support for SystemTap SDT probes on IA-64.Sergio Durigan Junior2-0/+27
Joel Brobecker reported a bug which was happening because of the "Improved linker-debugger interface", by Gary Benson, when tested on IA-64 with rhES5. The message is: <http://sourceware.org/ml/gdb-patches/2013-06/msg00745.html> The failure happened because GDB was trying to parse the probes' operands using only the generic parser (implemented on stap-probe.c), because the arch-specific parser was not implemented. Thus, I am committing the following changes which solve the bug. 2013-06-29 Sergio Durigan Junior <sergiodj@redhat.com> * ia64-linux-tdep.c: Include <ctype.h>. (ia64_linux_stap_is_single_operand): New function. (ia64_linux_init_abi): Initialize SystemTap related attributes.
2013-06-28move version.in from gdb/common back to gdbTom Tromey9-22/+42
This reverts part of the earlier version.in change. It moves version.in back to the gdb directory. This works around the CVS bug we've found. gdb * Makefile.in (version.c): Use version.in, not common/version.in. * common/create-version.sh: Likewise. * common/version.in: Move... * version.in: ...here. gdb/doc * Makefile.in (version.subst): Use version.in, not common/version.in. * gdbint.texinfo (Versions and Branches, Releasing GDB): Likewise. gdb/gdbserver * Makefile.in (version.c): Use version.in, not common/version.in. sim/common * Make-common.in (version.c): Use version.in, not common/version.in. * create-version.sh: Likewise. sim/ppc: * Make-common.in (version.c): Use version.in, not common/version.in.
2013-06-28Move pagination_enabled declaration to a proper place.Pedro Alves3-2/+8
Declare it close to other related declarations in utils.h, and remove local extern declaration hack. gdb/ 2013-06-28 Pedro Alves <palves@redhat.com> * infrun.c (set_observer_mode): Don't declare pagination_enabled here. * utils.h (pagination_enabled): Declare.
2013-06-28infrun.c: Move non_stop_1 etc., higher up in file.Pedro Alves2-28/+32
The "non_stop_1" global is out of place, mixed with the observer bits. This moves all the non-stop user-interface-related bits together. gdb/ 2013-06-28 Pedro Alves <palves@redhat.com> * infrun.c (non_stop, non_stop_1, set_non_stop, show_non_stop): Move higher up in file.
2013-06-28 * tracepoint.c (deprecated_readline_begin_hook)Tom Tromey2-4/+6
(deprecated_readline_hook, deprecated_readline_end_hook): Don't declare.
2013-06-28[PR tui/14880] Fetch values before comparing their contents.Pedro Alves4-4/+22
PR tui/14880 shows a reproducer that triggers this assertion: int value_available_contents_eq (const struct value *val1, int offset1, const struct value *val2, int offset2, int length) { int idx1 = 0, idx2 = 0; /* This routine is used by printing routines, where we should already have read the value. Note that we only know whether a value chunk is available if we've tried to read it. */ gdb_assert (!val1->lazy && !val2->lazy); (top-gdb) bt #0 internal_error (file=0x88a26c "../../src/gdb/value.c", line=549, string=0x88a220 "%s: Assertion `%s' failed.") at ../../src/gdb/utils.c:844 #1 0x000000000057b9cd in value_available_contents_eq (val1=0x10fa900, offset1=0, val2=0x10f9e10, offset2=0, length=8) at ../../src/gdb/value.c:549 #2 0x00000000004fd756 in tui_get_register (frame=0xd5c430, data=0x109a548, regnum=0, changedp=0x109a560) at ../../src/gdb/tui/tui-regs.c:736 #3 0x00000000004fd111 in tui_check_register_values (frame=0xd5c430) at ../../src/gdb/tui/tui-regs.c:521 #4 0x0000000000501884 in tui_check_data_values (frame=0xd5c430) at ../../src/gdb/tui/tui-windata.c:234 #5 0x00000000004f976f in tui_selected_frame_level_changed_hook (level=1) at ../../src/gdb/tui/tui-hooks.c:222 #6 0x00000000006f0681 in select_frame (fi=0xd5c430) at ../../src/gdb/frame.c:1490 #7 0x00000000005dd94b in up_silently_base (count_exp=0x0) at ../../src/gdb/stack.c:2268 #8 0x00000000005dd985 in up_command (count_exp=0x0, from_tty=1) at ../../src/gdb/stack.c:2280 #9 0x00000000004dc5cf in do_cfunc (c=0xd3f720, args=0x0, from_tty=1) at ../../src/gdb/cli/cli-decode.c:113 #10 0x00000000004df664 in cmd_func (cmd=0xd3f720, args=0x0, from_tty=1) at ../../src/gdb/cli/cli-decode.c:1888 #11 0x00000000006e43e1 in execute_command (p=0xc7e6c2 "", from_tty=1) at ../../src/gdb/top.c:489 The fix is to fetch the value before comparing the contents. The comment additions to value.h explain why it can't be value_available_contents_eq itself that fetches the contents. Tested on x86_64 Fedora 17. gdb/ 2013-06-28 Pedro Alves <palves@redhat.com> PR tui/14880 * tui/tui-regs.c (tui_get_register): Fetch register value contents before checking whether they're available. * value.c (value_available_contents_eq): Change comment. * value.h (value_available_contents_eq): Expand comment.
2013-06-28gdbserver: fix the standalone buildMircea Gherzan4-1/+28
When directly invoking gdb/gdbserver/configure && make, the build will fail because the $(host_alias) is empty and thus create-version.sh does not get enough parameters. The output of gdbserver --version without this patch (built like above): [...] This gdbserver was configured as "" After applying this patch: [...] This gdbserver was configured as "x86_64-unknown-linux-gnu" 2013-06-28 Mircea Gherzan <mircea.gherzan@intel.com> gdbserver: * configure.ac (version_host, version_target): Set and AC_SUBST them. * configure: Rebuild. * Makefile.in (version_host, version_target): Get from configure. (version.c): Use $(version_host) and $(version_target). Change-Id: Id48240532ad3d624ec78867a6db5ebd4c09583ff Signed-off-by: Mircea Gherzan <mircea.gherzan@intel.com>
2013-06-27 * target.c (find_run_target): Remove.Tom Tromey3-26/+5
* target.h (find_run_target): Remove.
2013-06-27 * corelow.c (core_gdbarch): Now static.Tom Tromey2-1/+5
2013-06-27 * target.c (target_struct_index): Remove.Tom Tromey2-1/+4
2013-06-27Move comment on the 'stepping over resolver' mechanism to the internals manual.Pedro Alves4-40/+57
This whole comment is now a bit out of place. I looked into moving it to handle_inferior_event, close to where in_solib_dynsym_resolve_code is used, but then there are 3 such places. I then looked at fragmenting it, pushing bits closer to the definitions of in_solib_dynsym_resolve_code and gdbarch_skip_solib_resolver, but then we'd lose the main advantage which is the overview. In the end, I realized this can fit nicely as internals manual material. This could possibly be a subsection of a new "run control", or "source stepping" or "stepping" or some such a bit more general section, but we can do that when we have more related content... Even the "single stepping" section is presently empty... gdb/doc/ 2013-06-27 Pedro Alves <palves@redhat.com> * gdbint.texinfo (Algorithms) <Stepping over runtime loader dynamic symbol resolution code>: New section, based on infrun.c comment. gdb/ 2013-06-27 Pedro Alves <palves@redhat.com> * infrun.c: Remove comment describing the 'stepping over runtime loader dynamic symbol resolution code' mechanism; moved to gdbint.texinfo.
2013-06-27Fix up broken ChangeLog entries.Tom Tromey1-34/+58
In some previous commits I forgot to prefix the file names with "gdb.base". This fixes the ChangeLog entries to be correct.
2013-06-27test suite update - gdb.base/[t-z]Tom Tromey25-143/+81
Convert files gdb.base/[t-z]*.exp to use standard_output_file et al. * gdb.base/testenv.exp, gdb.base/tui-layout.exp, gdb.base/twice.exp, gdb.base/type-opaque.exp, gdb.base/unload.exp, gdb.base/unwindonsignal.exp, gdb.base/valgrind-db-attach.exp, gdb.base/valgrind-infcall.exp, gdb.base/value-double-free.exp, gdb.base/varargs.exp, gdb.base/watch-cond-infcall.exp, gdb.base/watch-cond.exp, gdb.base/watch-non-mem.exp, gdb.base/watch-read.exp, gdb.base/watch-vfork.exp, gdb.base/watch_thread_num.exp, gdb.base/watchpoint-cond-gone.exp, gdb.base/watchpoint-delete.exp, gdb.base/watchpoint-hw.exp, gdb.base/watchpoint-solib.exp, gdb.base/watchpoint.exp, gdb.base/watchpoints.exp, gdb.base/wchar.exp, gdb.base/whatis.exp: Use standard_testfile, standard_output_file, prepare_for_testing, clean_restart.
2013-06-27test suite update - gdb.base/s*Tom Tromey46-340/+174
Convert files gdb.base/s*.exp to use standard_output_file et al. * gdb.base/save-bp.exp, gdb.base/savedregs.exp, gdb.base/scope.exp, gdb.base/sep.exp, gdb.base/sepsymtab.exp, gdb.base/set-lang-auto.exp, gdb.base/setshow.exp, gdb.base/setvar.exp, gdb.base/shlib-call.exp, gdb.base/shreloc.exp, gdb.base/sigall.exp, gdb.base/sigaltstack.exp, gdb.base/sigbpt.exp, gdb.base/sigchld.exp, gdb.base/siginfo-addr.exp, gdb.base/siginfo-infcall.exp, gdb.base/siginfo-obj.exp, gdb.base/siginfo.exp, gdb.base/signals.exp, gdb.base/signest.exp, gdb.base/signull.exp, gdb.base/sigrepeat.exp, gdb.base/sigstep.exp, gdb.base/sizeof.exp, gdb.base/skip-solib.exp, gdb.base/so-impl-ld.exp, gdb.base/solib-display.exp, gdb.base/solib-nodir.exp, gdb.base/solib-overlap.exp, gdb.base/solib-symbol.exp, gdb.base/solib-weak.exp, gdb.base/source.exp, gdb.base/stack-checking.exp, gdb.base/stale-infcall.exp, gdb.base/stap-probe.exp, gdb.base/start.exp, gdb.base/step-break.exp, gdb.base/step-bt.exp, gdb.base/step-line.exp, gdb.base/step-resume-infcall.exp, gdb.base/step-test.exp, gdb.base/structs.exp, gdb.base/structs2.exp, gdb.base/structs3.exp, gdb.base/symbol-without-target_section.exp: Use standard_testfile, standard_output_file, prepare_for_testing, clean_restart.
2013-06-27test suite update - gdb.base/[n-r]Tom Tromey29-258/+109
Convert files gdb.base/[n-r]*.exp to use standard_output_file et al. * gdb.base/nextoverexit.exp, gdb.base/nextoverexit.exp, gdb.base/nodebug.exp, gdb.base/nofield.exp, gdb.base/nostdlib.exp, gdb.base/opaque.exp, gdb.base/overlays.exp, gdb.base/pc-fp.exp, gdb.base/pending.exp, gdb.base/permissions.exp, gdb.base/pie-execl.exp, gdb.base/pointers.exp, gdb.base/pr11022.exp, gdb.base/print-file-var.exp, gdb.base/printcmds.exp, gdb.base/prologue.exp, gdb.base/psymtab.exp, gdb.base/ptr-typedef.exp, gdb.base/ptype.exp, gdb.base/randomize.exp, gdb.base/readline-ask.exp, gdb.base/recpar.exp, gdb.base/recurse.exp, gdb.base/relativedebug.exp, gdb.base/relocate.exp, gdb.base/remote.exp, gdb.base/reread.exp, gdb.base/return-nodebug.exp, gdb.base/return2.exp: Use standard_testfile, standard_output_file, prepare_for_testing, clean_restart.
2013-06-27test suite update - gdb.base/[h-m]Tom Tromey34-282/+131
Convert files gdb.base/[h-m]*.exp to use standard_output_file et al. * hook-stop-continue.exp, hook-stop-frame.exp, huge.exp, included.exp, inferior-died.exp, infnan.exp, info-fun.exp, info-macros.exp, info-os.exp, info-proc.exp, info-target.exp, infoline.exp, interp.exp, interrupt.exp, jit-simple.exp, jit-so.exp, jump.exp, kill-after-signal.exp, label.exp, langs.exp, lineinc.exp, list.exp, logical.exp, long_long.exp, longjmp.exp, macscp.exp, maint.exp, memattr.exp, mips_pro.exp, miscexprs.exp, morestack.exp, moribund-step.exp, multi-forks.exp: Use standard_testfile, standard_output_file, prepare_for_testing, clean_restart.
2013-06-27test suite update - gdb.base/[efg]Tom Tromey32-273/+125
Convert files gdb.base/[efg]*.exp to use standard_output_file et al. * ena-dis-br.exp, enum_cond.exp, enumval.exp, environ.exp, eu-strip-infcall.exp, eval-skip.exp, exe-lock.exp, expand-psymtabs.exp, exprs.exp, fileio.exp, find.exp, fixsection.exp, foll-exec.exp, foll-fork.exp, fortran-sym-case.exp, frame-args.exp, freebpcmd.exp, fullname.exp, funcargs.exp, gcore-buffer-overflow.exp, gcore.exp, gdb1090.exp, gdb11530.exp, gdb11531.exp, gdb1250.exp, gdb1555.exp, gdb1821.exp, gdbindex-stabs.exp, gdbvars.exp, gnu-ifunc.exp, gnu_vector.exp: Use standard_testfile, standard_output_file, prepare_for_testing, clean_restart.
2013-06-27test suite update - gdb.base/[cd]Tom Tromey36-337/+172
Convert files gdb.base/[cd]*.exp to use standard_output_file et al. * call-ar-st.exp, call-rt-st.exp, call-sc.exp, call-signal-resume.exp, call-strs.exp, callexit.exp, callfuncs.exp, catch-load.exp, catch-syscall.exp, charset.exp, checkpoint.exp, chng-syms.exp, code-expr.exp, code_elim.exp, commands.exp, completion.exp, complex.exp, cond-expr.exp, condbreak.exp, consecutive.exp, constvars.exp, corefile.exp, ctxobj.exp, cursal.exp, cvexpr.exp, dbx.exp, default.exp, define.exp, del.exp, detach.exp, dfp-test.exp, display.exp, dmsym.exp, dump.exp, dup-sect.exp: Use standard_testfile, standard_output_file, prepare_for_testing, clean_restart.
2013-06-27test suite update - gdb.base/[ab]Tom Tromey26-175/+98
Convert files gdb.base/[ab]*.exp to use standard_output_file et al. * a2-run.exp, all-bin.exp, annota1.exp, annota3.exp, anon.exp, args.exp, arithmet.exp, arrayidx.exp, assign.exp, async-shell.exp, async.exp, attach-pie-misread.exp, attach-pie-noexec.exp, attach-twice.exp, attach.exp, auxv.exp, bang.exp, bfp-test.exp, bigcore.exp, bitfields.exp, bitfields2.exp, break-entry.exp, break-interp.exp, break-on-linker-gcd-function.exp, breakpoint-shadow.exp: Use standard_testfile, standard_output_file, prepare_for_testing, clean_restart.
2013-06-27Fix catch_command_errors's prototype.Pedro Alves3-2/+8
gdb/ 2013-06-27 Pedro Alves <palves@redhat.com> * exceptions.c (catch_command_errors): Remove spurious space. * exceptions.h (catch_command_errors): Second parameter is "arg", not "command".
2013-06-27gdb/Yao Qi2-4/+18
* common/create-version.sh: Update comments. Handle the case that TARGET_ALIAS is empty.
2013-06-26Garbage collect SOLIB_IN_DYNAMIC_LINKER.Pedro Alves2-12/+5
This hasn't been used for years. gdb/ 2013-06-26 Pedro Alves <palves@redhat.com> * infrun.c (SOLIB_IN_DYNAMIC_LINKER): Delete macro and describing comment.