aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-07-21[gdb/symtab] Use task size in parallel for in process_queueusers/vries/process-queue-parallelTom de Vries1-1/+9
2022-07-21[gdb/symtab] Fix data race in lookup_die_typeTom de Vries1-1/+14
Data race between: ... Write of size 8 at 0x7b8009b483f8 by main thread: #0 read_tag_pointer_type gdb/dwarf2/read.c:16171 (gdb+0x8580b3) #1 read_type_die_1 gdb/dwarf2/read.c:21508 (gdb+0x869b69) #2 read_type_die gdb/dwarf2/read.c:21474 (gdb+0x869a53) #3 lookup_die_type gdb/dwarf2/read.c:21446 (gdb+0x8699ad) #4 die_type gdb/dwarf2/read.c:21300 (gdb+0x869286) #5 dwarf2_add_field gdb/dwarf2/read.c:13535 (gdb+0x84aabd) #6 handle_struct_member_die gdb/dwarf2/read.c:14803 (gdb+0x851ad2) #7 process_structure_scope gdb/dwarf2/read.c:14865 (gdb+0x851e70) #8 process_die gdb/dwarf2/read.c:8649 (gdb+0x83a048) #9 read_file_scope gdb/dwarf2/read.c:9616 (gdb+0x83cb81) #10 process_die gdb/dwarf2/read.c:8620 (gdb+0x839f43) #11 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839509) #12 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... and: ... Previous read of size 8 at 0x7b8009b483f8 by thread T3: #0 dwarf2_cu::addr_type() const gdb/dwarf2/cu.c:99 (gdb+0x7b8d42) #1 set_die_type gdb/dwarf2/read.c:23850 (gdb+0x871e4e) #2 read_subroutine_type gdb/dwarf2/read.c:16539 (gdb+0x8591c8) #3 read_type_die_1 gdb/dwarf2/read.c:21499 (gdb+0x869b15) #4 read_type_die gdb/dwarf2/read.c:21474 (gdb+0x869a53) #5 lookup_die_type gdb/dwarf2/read.c:21446 (gdb+0x8699ad) #6 die_type gdb/dwarf2/read.c:21300 (gdb+0x869286) #7 read_tag_pointer_type gdb/dwarf2/read.c:16114 (gdb+0x857d91) #8 read_type_die_1 gdb/dwarf2/read.c:21508 (gdb+0x869b69) #9 read_type_die gdb/dwarf2/read.c:21474 (gdb+0x869a53) #10 lookup_die_type gdb/dwarf2/read.c:21446 (gdb+0x8699ad) #11 die_type gdb/dwarf2/read.c:21300 (gdb+0x869286) #12 new_symbol gdb/dwarf2/read.c:20742 (gdb+0x8671fe) #13 read_variable gdb/dwarf2/read.c:12623 (gdb+0x848823) #14 process_die gdb/dwarf2/read.c:8716 (gdb+0x83a28c) #15 read_file_scope gdb/dwarf2/read.c:9616 (gdb+0x83cb81) #16 process_die gdb/dwarf2/read.c:8620 (gdb+0x839f43) #17 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839509) #18 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... Fix this by adding a lock in lookup_die_type. Also in read_type_die and set_die_type. Hmm, we already use another lock in set_die_type. This needs more work.
2022-07-21[gdb/symtab] Fix data race on objfile->template_symbolsTom de Vries1-0/+4
Data race between: ... Read of size 8 at 0x7b4000006dd8 by thread T4: #0 new_symbol gdb/dwarf2/read.c:21085 (gdb+0x868212) #1 handle_struct_member_die gdb/dwarf2/read.c:14828 (gdb+0x851be8) #2 process_structure_scope gdb/dwarf2/read.c:14865 (gdb+0x851e70) #3 process_die gdb/dwarf2/read.c:8649 (gdb+0x83a048) #4 read_namespace gdb/dwarf2/read.c:16026 (gdb+0x857a32) #5 process_die gdb/dwarf2/read.c:8689 (gdb+0x83a100) #6 read_file_scope gdb/dwarf2/read.c:9616 (gdb+0x83cb81) #7 process_die gdb/dwarf2/read.c:8620 (gdb+0x839f43) #8 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839509) #9 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... and: ... Previous write of size 8 at 0x7b4000006dd8 by main thread: #0 new_symbol gdb/dwarf2/read.c:21086 (gdb+0x868247) #1 handle_struct_member_die gdb/dwarf2/read.c:14828 (gdb+0x851be8) #2 process_structure_scope gdb/dwarf2/read.c:14865 (gdb+0x851e70) #3 process_die gdb/dwarf2/read.c:8649 (gdb+0x83a048) #4 read_namespace gdb/dwarf2/read.c:16026 (gdb+0x857a32) #5 process_die gdb/dwarf2/read.c:8689 (gdb+0x83a100) #6 read_file_scope gdb/dwarf2/read.c:9616 (gdb+0x83cb81) #7 process_die gdb/dwarf2/read.c:8620 (gdb+0x839f43) #8 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839509) #9 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... Fix this by adding a lock in new_symbol for adding to objfile->template_symbols.
2022-07-21[gdb/symtab] Fix data race in add_compunit_symtab_to_objfileTom de Vries1-0/+4
Data race bewteen: ... Read of size 8 at 0x7b4000006d20 by thread T3: #0 add_compunit_symtab_to_objfile(compunit_symtab*) gdb/symfile.c:2852 (gdb+0xe89cff) #1 buildsym_compunit::end_compunit_symtab_with_blockvector(block*, int, int) gdb/buildsym.c:1018 (gdb+0x63e857) #2 buildsym_compunit::end_compunit_symtab_from_static_block(block*, int, int) gdb/buildsym.c:1052 (gdb+0x63e8cd) #3 process_full_comp_unit gdb/dwarf2/read.c:8414 (gdb+0x8396b6) #4 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... and: ... Previous write of size 8 at 0x7b4000006d20 by thread T4: #0 add_compunit_symtab_to_objfile(compunit_symtab*) gdb/symfile.c:2853 (gdb+0xe89d35) #1 buildsym_compunit::end_compunit_symtab_with_blockvector(block*, int, int) gdb/buildsym.c:1018 (gdb+0x63e857) #2 buildsym_compunit::end_compunit_symtab_from_static_block(block*, int, int) gdb/buildsym.c:1052 (gdb+0x63e8cd) #3 process_full_comp_unit gdb/dwarf2/read.c:8414 (gdb+0x8396b6) #4 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... Fix this by adding a lock in add_compunit_symtab_to_objfile.
2022-07-21[gdb] Fix data race in cleanup_undefined_stabs_typesTom de Vries1-0/+5
Data race for: ... Read of size 4 at 0x00000324db04 by thread T1: #0 cleanup_undefined_types_1 /home/vries/gdb_versions/devel/src/gdb/stabsread.c:4437 (gdb+0xe60bdd) #1 cleanup_undefined_stabs_types(objfile*) /home/vries/gdb_versions/devel/src/gdb/stabsread.c:4500 (gdb+0xe60c48) #2 buildsym_compunit::end_compunit_symtab_get_static_block(unsigned long, int, int) /home/vries/gdb_versions/devel/src/gdb/buildsym.c:837 (gdb+0x63dbba) #3 process_full_comp_unit /home/vries/gdb_versions/devel/src/gdb/dwarf2/read.c:8404 (gdb+0x8395f4) #4 process_queue_item /home/vries/gdb_versions/devel/src/gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... and location: ... Location is global 'undef_types_length' of size 4 at 0x00000324db04 ... Likewise for: ... WARNING: ThreadSanitizer: data race (pid=12737) Read of size 4 at 0x00000324db1c by thread T4: #0 cleanup_undefined_types_noname /home/vries/gdb_versions/devel/src/gdb/stabsread.c:4383 (gdb+0xe608b2) #1 cleanup_undefined_stabs_types(objfile*) /home/vries/gdb_versions/devel/src/gdb/stabsread.c:4501 (gdb+0xe60c54) #2 buildsym_compunit::end_compunit_symtab_get_static_block(unsigned long, int, int) /home/vries/gdb_versions/devel/src/gdb/buildsym.c:837 (gdb+0x63dbba) #3 process_full_comp_unit /home/vries/gdb_versions/devel/src/gdb/dwarf2/read.c:8404 (gdb+0x8395f4) #4 process_queue_item /home/vries/gdb_versions/devel/src/gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... and location: ... Location is global 'noname_undefs_length' of size 4 at 0x00000324db1c ... Fix this by adding a lock in cleanup_undefined_stabs_types.
2022-07-21[gdb/symtab] Fix race condition in just_read_cusTom de Vries1-2/+8
Race condition between: ... Read of size 8 at 0x7b640001f2c8 by thread T1: #0 std::vector<dwarf2_per_cu_data*, std::allocator<dwarf2_per_cu_data*> >::push_back(dwarf2_per_cu_data* const&) /usr/include/c++/12/bits/stl_vector.h:1278 (gdb+0x888ad6) #1 process_full_comp_unit gdb/dwarf2/read.c:8451 (gdb+0x8397d0) #2 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... and: ... Previous write of size 8 at 0x7b640001f2c8 by main thread: #0 std::vector<dwarf2_per_cu_data*, std::allocator<dwarf2_per_cu_data*> >::push_back(dwarf2_per_cu_data* const&) /usr/include/c++/12/bits/stl_vector.h:1283 (gdb+0x888b52) #1 process_full_comp_unit gdb/dwarf2/read.c:8451 (gdb+0x8397d0) #2 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x8359f5) ... Fix this by doing the just_read_cus push_back in a lock.
2022-07-21[gdb] Fix data race in bitfieldTom de Vries1-2/+6
Data race between: ... Write of size 4 at 0x7b8009b483f0 by thread T2: #0 set_type_align(type*, unsigned long) /home/vries/gdb_versions/devel/src/gdb/gdbtypes.c:3751 (gdb+0x961e08) ... and: ... Previous read of size 1 at 0x7b8009b483f1 by thread T4: #0 type::instance_flags() const /home/vries/gdb_versions/devel/src/gdb/gdbtypes.h:1092 (gdb+0x59e74b) ... corresponding to: ... unsigned align_log2 : TYPE_ALIGN_BITS; unsigned m_instance_flags : 9; ... Fix this by wrapping them using "struct { ... };". For now, don't worry about size increase, we might have to address this later using packed. Still, is this a correct fix? Maybe the problem is modifying a type from different thread. If so, having this patch for now may expose that problem.
2022-07-21[gdb] Fix data race in bcache::insertTom de Vries1-0/+11
Data race between: ... Read of size 8 at 0x7bb4000000d0 by thread T4: #0 gdb::bcache::insert(void const*, int, bool*) gdb/bcache.c:155 #1 objfile_per_bfd_storage::intern(char const*) gdb/objfiles.h:250 #2 objfile::intern(char const*) gdb/objfiles.h:475 #3 dwarf2_canonicalize_name gdb/dwarf2/read.c:21904 #4 dwarf2_name gdb/dwarf2/read.c:21999 #5 read_base_type gdb/dwarf2/read.c:17092 #6 read_type_die_1 gdb/dwarf2/read.c:21529 #7 read_type_die gdb/dwarf2/read.c:21464 #8 process_die gdb/dwarf2/read.c:8674 #9 read_file_scope gdb/dwarf2/read.c:9610 #10 process_die gdb/dwarf2/read.c:8614 #11 process_full_comp_unit gdb/dwarf2/read.c:8383 #12 process_queue_item gdb/dwarf2/read.c:7592 ... and: ... Previous write of size 8 at 0x7bb4000000d0 by main thread: #0 gdb::bcache::insert(void const*, int, bool*) gdb/bcache.c:167 #1 objfile_per_bfd_storage::intern(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) gdb/objfiles.h:257 #2 objfile::intern(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) <null> #3 dwarf2_compute_name gdb/dwarf2/read.c:9050 #4 dwarf2_full_name gdb/dwarf2/read.c:9070 #5 read_structure_type gdb/dwarf2/read.c:14558 #6 process_structure_scope gdb/dwarf2/read.c:14847 #7 process_die gdb/dwarf2/read.c:8643 #8 read_file_scope gdb/dwarf2/read.c:9610 #9 process_die gdb/dwarf2/read.c:8614 #10 process_full_comp_unit gdb/dwarf2/read.c:8383 #11 process_queue_item gdb/dwarf2/read.c:7592 ...
2022-07-21[gdb/symtab] Fix data race in get_die_type_at_offsetTom de Vries1-19/+32
Data race between: ... ================== WARNING: ThreadSanitizer: data race (pid=28142) Read of size 4 at 0x7b1c0004b978 by thread T2: #0 htab_find_with_hash libiberty/hashtab.c:591 (gdb+0x1c5a254) #1 htab_find libiberty/hashtab.c:621 (gdb+0x1c5a44d) #2 get_die_type_at_offset gdb/dwarf2/read.c:23877 (gdb+0x872004) #3 get_die_type gdb/dwarf2/read.c:23890 (gdb+0x8720d0) #4 read_type_die gdb/dwarf2/read.c:21460 (gdb+0x8698e4) #5 process_die gdb/dwarf2/read.c:8674 (gdb+0x839f6e) #6 read_file_scope gdb/dwarf2/read.c:9610 (gdb+0x83ca5d) #7 process_die gdb/dwarf2/read.c:8614 (gdb+0x839e1f) #8 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x83945e) #9 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x83597d) ... and: ... Previous write of size 4 at 0x7b1c0004b978 by thread T1: #0 htab_find_with_hash libiberty/hashtab.c:591 (gdb+0x1c5a26e) #1 htab_find libiberty/hashtab.c:621 (gdb+0x1c5a44d) #2 get_die_type_at_offset gdb/dwarf2/read.c:23877 (gdb+0x872004) #3 get_die_type gdb/dwarf2/read.c:23890 (gdb+0x8720d0) #4 process_structure_scope gdb/dwarf2/read.c:14845 (gdb+0x851c12) #5 process_die gdb/dwarf2/read.c:8643 (gdb+0x839f24) #6 read_file_scope gdb/dwarf2/read.c:9610 (gdb+0x83ca5d) #7 process_die gdb/dwarf2/read.c:8614 (gdb+0x839e1f) #8 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x83945e) #9 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x83597d) ... Fix by using lock, also in set_die_type.
2022-07-21[gdb/symtab] Fix data race in objstats->n_symsTom de Vries2-4/+4
Data race between: ... Read of size 4 at 0x7b4000006dc8 by main thread: #0 new_symbol gdb/dwarf2/read.c:20704 (gdb+0x866f3e) #1 process_die gdb/dwarf2/read.c:8674 (gdb+0x839fa8) #2 read_file_scope gdb/dwarf2/read.c:9610 (gdb+0x83ca7f) #3 process_die gdb/dwarf2/read.c:8614 (gdb+0x839e41) #4 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839480) #5 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x83599f) ... and: ... Previous write of size 4 at 0x7b4000006dc8 by thread T2: #0 new_symbol gdb/dwarf2/read.c:20704 (gdb+0x866f5d) #1 process_die gdb/dwarf2/read.c:8674 (gdb+0x839fa8) #2 read_file_scope gdb/dwarf2/read.c:9610 (gdb+0x83ca7f) #3 process_die gdb/dwarf2/read.c:8614 (gdb+0x839e41) #4 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839480) #5 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x83599f) ... Fix by making objstats->n_syms atomic. Likewise for n_types.
2022-07-21[gdb/symtab] Fix data race on per_objfile->sym_cuTom de Vries3-7/+14
We have both: ... gdb/dwarf2/read.c:9590: internal-error: read_file_scope: \ Assertion `per_objfile->sym_cu == nullptr' failed. ... and a data race between: ... #0 read_file_scope gdb/dwarf2/read.c:9590 (gdb+0x83c8ca) #1 process_die gdb/dwarf2/read.c:8614 (gdb+0x839dc1) #2 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839400) #3 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x83591f) ... and: ... Previous write of size 8 at 0x7b4400096f20 by thread T1: #0 scoped_restore_tmpl<dwarf2_cu*>::scoped_restore_tmpl<dwarf2_cu*> (dwarf2_cu**, dwarf2_cu*) gdbsupport/scoped_restore.h:73 (gdb+0x89d23e) #1 scoped_restore_tmpl<dwarf2_cu*> make_scoped_restore<dwarf2_cu*, dwarf2_cu*>(dwarf2_cu**, dwarf2_cu*) gdbsupport/scoped_restore.h:115 (gdb+0x890543) #2 read_file_scope gdb/dwarf2/read.c:9592 (gdb+0x83c924) #3 process_die gdb/dwarf2/read.c:8614 (gdb+0x839dc1) #4 process_full_comp_unit gdb/dwarf2/read.c:8383 (gdb+0x839400) #5 process_queue_item gdb/dwarf2/read.c:7592 (gdb+0x83591f) ... Fix again by using poor man's thread local.
2022-07-21[gdb/symtab] Fix race condition in objfile_obstackTom de Vries1-2/+16
Race condition between: ... Read of size 8 at 0x7b4400096f60 by thread T1: #0 obstack_zalloc<compunit_symtab> gdbsupport/gdb_obstack.h:33 #1 allocate_compunit_symtab(objfile*, char const*) gdb/symfile.c:2822 #2 buildsym_compunit::buildsym_compunit(objfile*, char const*, char const*, language, unsigned long) gdb/buildsym.c:65 #3 dwarf2_cu::start_compunit_symtab(char const*, char const*, unsigned long) gdb/dwarf2/cu.c:65 #4 read_file_scope gdb/dwarf2/read.c:9587 #5 process_die gdb/dwarf2/read.c:8614 #6 process_full_comp_unit gdb/dwarf2/read.c:8383 #7 process_queue_item gdb/dwarf2/read.c:7592 ... and: ... Previous write of size 8 at 0x7b4400096f60 by thread T2: #0 _obstack_newchunk libiberty/obstack.c:211 #1 obstack_zalloc<compunit_symtab> gdbsupport/gdb_obstack.h:33 #2 allocate_compunit_symtab(objfile*, char const*) gdb/symfile.c:2822 #3 buildsym_compunit::buildsym_compunit(objfile*, char const*, char const*, language, unsigned long) gdb/buildsym.c:65 #4 dwarf2_cu::start_compunit_symtab(char const*, char const*, unsigned long) gdb/dwarf2/cu.c:65 #5 read_file_scope gdb/dwarf2/read.c:9587 #6 process_die gdb/dwarf2/read.c:8614 #7 process_full_comp_unit gdb/dwarf2/read.c:8383 #8 process_queue_item gdb/dwarf2/read.c:7592 ... Fix by using poor man's thread_local.
2022-07-21[gdbsupport] Workaround data race in get_print_cellTom de Vries1-6/+1
Data race between: ... Write of size 4 at 0x00000324eb60 by thread T2: #0 get_print_cell() gdbsupport/print-utils.cc:35 (gdb+0x1c032c7) #1 hex_string(long) gdbsupport/print-utils.cc:230 (gdb+0x1c03bc2) #2 sect_offset_str gdb/gdbtypes.h:82 (gdb+0x81b333) #3 process_queue_item gdb/dwarf2/read.c:7581 (gdb+0x831645) ... and: ... Previous read of size 4 at 0x00000324eb60 by thread T3: #0 get_print_cell() gdbsupport/print-utils.cc:35 (gdb+0x1c032b4) #1 hex_string(long) gdbsupport/print-utils.cc:230 (gdb+0x1c03bc2) #2 sect_offset_str gdb/gdbtypes.h:82 (gdb+0x81b333) #3 process_queue_item gdb/dwarf2/read.c:7581 (gdb+0x831645) ... For now, just do a malloc in get_print_cell to work around the data race.
2022-07-21[gdb/symtab] Use parallel_for_each in process_queueTom de Vries1-5/+26
Do the parallelization.
2022-07-21[gdb] Make objfile_obstack a member functionTom de Vries22-175/+179
Prepare to fix race conditions in a single location.
2022-07-21[gdb/symtab] Factor out process_queue_itemTom de Vries1-43/+52
Refactoring that makes the patch to parallelize process_queue more readable.
2022-07-21[gdb/symtab] Add early-out in process_queueTom de Vries1-0/+3
Don't print "Expanding one or more symtabs of objfile" if the queue is empty.
2022-07-21[gdb/symtab] Use deque instead of queue for per_objfile->queueTom de Vries2-4/+4
Allows us to access all elements at once.
2022-07-21[gdbsupport] Add thread_pool::idTom de Vries2-1/+26
Used to implement a poor mans thread_local.
2022-07-21[COVER-LETTER] Parallelize process_queueTom de Vries1-0/+0
I. Rationale When investigating my running example for gdb speed with lto execs (see PR23710): ... $ gdb -q -batch ./lto/cc1 -ex "b do_rpo_vn" ... using this patch: ... @@ -7549,13 +7549,17 @@ maybe_queue_comp_unit (struct dwarf2_cu *dependent_cu, static void process_queue (dwarf2_per_objfile *per_objfile) { - dwarf_read_debug_printf ("Expanding one or more symtabs of objfile %s ...", - objfile_name (per_objfile->objfile)); + if (per_objfile->queue->empty ()) + return; /* The queue starts out with one item, but following a DIE reference may load a new CU, adding it to the end of the queue. */ while (!per_objfile->queue->empty ()) { + dwarf_read_debug_printf ("Expanding symtabs of objfile %s, queue size: %zd ...", + objfile_name (per_objfile->objfile), + per_objfile->queue->size ()); + dwarf2_queue_item &item = per_objfile->queue->front (); dwarf2_per_cu_data *per_cu = item.per_cu; @@ -8522,7 +8526,11 @@ process_imported_unit_die (struct die_info *die, struct dwarf2_cu *cu) if (die->parent && die->parent->parent == NULL && per_cu->unit_type (false) == DW_UT_compile && per_cu->lang (false) == language_cplus) - return; + { + dwarf_read_debug_printf ("Skipping import of c++ CU at offset %s", + sect_offset_str (sect_off)); + return; + } /* If necessary, add it to the queue and load its DIEs. */ if (maybe_queue_comp_unit (cu, per_cu, per_objfile, ... and "set debug dwarf-read 1" (dumped into a log file, see V), I noticed: ... $ grep "Expanding symtabs of" LOG | more [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 1 ... [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 1 ... [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 173 ... [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 172 ... ... that the queue processed by process_queue can be large, and is processed sequentially, and I wondered if doing this in parallel might speed things up. This might also be useful for -readnow, but that might require additional changes to active this, I haven't checked that yet. II. Correctness results. The running example runs without thread sanitizer issues. Running the testsuite with thread sanitizer revealed issues during cpexprs-debug-types.exp. III. Performance results. I did a performance experiment using: ... $ for n in $(seq 1 10); do \ time gdb -q -batch ~/firefox/libxul.so-93.0-1.1.x86_64.debug \ 2>&1 \ | grep "real:"; \ done ... and observed the following results for master: ... real: 4.09 real: 4.03 real: 4.64 real: 4.04 real: 4.18 real: 4.73 real: 4.63 real: 4.02 real: 4.04 real: 4.03 ... and with this branch: ... real: 4.04 real: 4.06 real: 3.97 real: 4.59 real: 4.39 real: 4.03 real: 4.03 real: 3.96 real: 3.97 real: 4.54 ... which looks roughtly comparable, so we don't seem to have slowed down the common case (where we don't excercise process_queue yet). Then with the running example: ... $ for n in $(seq 1 10); do \ time gdb -q -batch ./lto/cc1 -ex "b do_rpo_vn" 2>&1 | grep "real:"; \ done ... with master: ... real: 4.19 real: 4.40 real: 4.30 real: 4.29 real: 4.20 real: 4.25 real: 4.28 real: 4.22 real: 4.31 real: 4.32 ... and this branch: ... real: 4.79 real: 4.83 real: 4.81 real: 4.74 real: 4.93 real: 4.92 real: 4.72 real: 4.82 real: 4.77 real: 4.79 ... So, there's a noticable slowdown. Doing the break after "maint set worker-threads 0" (to force the parallel for in process_queue to run sequentially) gives us: ... real: 4.56 real: 4.50 real: 4.57 real: 4.57 real: 4.61 real: 4.58 real: 4.52 real: 4.62 real: 4.52 real: 4.58 ... IV. Analysis. The slowdown is probably caused by excessive locking. This could be solved by tracking more things in a thread_local way, but probably at the cost of more memory. We could implement a statistics_mutex that dumps the lock/unlock statistics upon destroying to find out what the problematic locks are (I suspect at least the die_type ones). A possibility is that we're not getting the full benefit because we only start processing in parallel once process_queue is called. A possible fix would be to have the main thread filling the queue and a dispatcher thread reading it and dispatching items to worker threads. Another possibility is that we're not getting the full benefit because we fairly distribute a number of CUs, but CUs will not be of equal size (this might hold equally for the cooked index btw). This could be mitigated somewhat by taking into account the size of the CUs when doing the distribution. Another solution would be to add a parallel_for_each_dynamic or some such that dispatches to workers that are idle. [ Presumably the dispatcher thread mentioned above would behave similarly. ] [ I've proposed a patch "[gdbsupport] Use task size in parallel_for_each" for trunk that deals with this issue for the parallel for in dwarf2_build_psymtabs_hard. Included in this branch before the cover letter. ] [ A last minute addition "[gdb/symtab] Use task size in parallel for in process_queue" did not improve the result. ] V. Dwarf-read log FTR, full log of gdb output with dwarf-read logging on: ... [dwarf-read] dwarf2_initialize_objfile: called [dwarf-read] dwarf2_build_psymtabs_hard: Building psymtabs of objfile cc1 ... [dwarf-read] read_comp_units_from_section: Reading .debug_info for cc1 [dwarf-read] open_and_init_dwp_file: DWP file not found: cc1.dwp [dwarf-read] print_tu_stats: Type unit statistics: [dwarf-read] print_tu_stats: 0 TUs [dwarf-read] print_tu_stats: 0 uniq abbrev tables [dwarf-read] print_tu_stats: 0 symtabs from stmt_list entries [dwarf-read] print_tu_stats: 0 symtab sharers [dwarf-read] print_tu_stats: 0 type units without a stmt_list [dwarf-read] print_tu_stats: 0 all_type_units reallocs [dwarf-read] dwarf2_build_psymtabs_hard: Done building psymtabs of cc1 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 1 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x282e061 [dwarf-read] process_queue: Done expanding CU at offset 0x282e061 [dwarf-read] process_queue: Done expanding symtabs of cc1. [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 1 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x4f726fa [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x18913 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xd9 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x48bb60 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x56019 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x432a1f [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x4c6372 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x27e55eb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x94932 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x17642d [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x261f49 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x52ac2c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x151169 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xd2a8cd [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x279a341 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x256eabe [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x271c86b [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x6a3f89 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x24ad9d6 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x274b291 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x26e630a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x282e06c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x540b58 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x181903c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3f05d53 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xe25133 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x35811ee [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xcc5d11 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1e7e6d1 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1e3fbd [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1fb00fe [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x65e263 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x625166 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2a3cb30 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xfa6640 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2d0bdf6 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x22ed46 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x4ef108 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x8d697a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xe50cd2 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x109c04d [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xb42761 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xaa65e8 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x7f222a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1a54bc [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x23c40eb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xd5eccb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xeb4343 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x211992 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xf34af1 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x150e087 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xa070aa [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xaf4948 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x922e3c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2628d41 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x229ddf3 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x14c101f [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x709504 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x193586f [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x8c24f9 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x20741b1 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x9530c2 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x5f55f9 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x5c2f35 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x58e313 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x19b0475 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xbfb92a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x10f2e0 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xda08e5 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xc90a25 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x16524ce [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x834f38 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2e9352 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x31964b [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x9bd839 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x5a0ea0 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x27cbbf1 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1012d7 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2424d46 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xcaaa67 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2017b91 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x6c293d [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x47e745 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x245be5d [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x13f465a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x27840f7 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1f94f6e [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x18c12a1 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2733a9c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x228970c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x24eed38 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1e085a3 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xc59eeb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x7c4801 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x26b9f5c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x269fd21 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x5db31b [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2687a48 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2478fbe [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2317395 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2657181 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x20d8a89 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1369c6c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x21583cf [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1a76f13 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x849309 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x411fc8 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x260a83d [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x12f73a3 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x899f40 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x195b657 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x25bcc72 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x259688c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3ebb2d5 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3ec48c8 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xc3fc34 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1d36e66 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xee7fc [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x22c669e [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3ea4bac [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1ff9d25 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xd0a5eb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x824e4a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xf679ff [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xfe5f20 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x203861e [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2a167ce [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xbe8373 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x23ee830 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1efde95 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3028d26 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2e1f51e [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x10411d1 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x33e777d [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3f0a9ce [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1dc37af [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3ef249e [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1751aa5 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1b52685 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x11cc196 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1b3b1e6 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x12eba45 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x414bd [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3f3a624 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2915861 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x248fe5c [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2dadb2 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2113e46 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x321ff16 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3d80b8a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x21879c2 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x19158b7 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1d425c7 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x172a702 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x17709ba [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x335da3 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2c76457 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x12b9fe2 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x38abdf2 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2ee9139 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3d68c0a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1d6e394 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3d49449 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x22278ca [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3ef7e15 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2bf61b9 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x19d1d3a [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xa71c19 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x14eef30 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3e966b0 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xbaa4fb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1e18bd6 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x3ee5f02 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x4082bc [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x46f8cf [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2effdc1 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0xdcd1cb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1270a16 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2243311 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x169070e [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1bd41bb [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x39b092 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1ebd919 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x1cb0b5e [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x2381bf5 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x12de1b4 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x220dd2f [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x7436f9 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x36b680 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x765494 [dwarf-read] process_imported_unit_die: Skipping import of c++ CU at offset 0x14061fc [dwarf-read] process_queue: Done expanding CU at offset 0x4f726fa [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 173 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd7e1b [dwarf-read] process_queue: Done expanding CU at offset 0x3fd7e1b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 172 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f6f015 [dwarf-read] process_queue: Done expanding CU at offset 0x3f6f015 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 171 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f6a111 [dwarf-read] process_queue: Done expanding CU at offset 0x3f6a111 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 170 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f66c00 [dwarf-read] process_queue: Done expanding CU at offset 0x3f66c00 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 169 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f51880 [dwarf-read] process_queue: Done expanding CU at offset 0x3f51880 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 168 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fcc5a5 [dwarf-read] process_queue: Done expanding CU at offset 0x3fcc5a5 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 167 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd478f [dwarf-read] process_queue: Done expanding CU at offset 0x3fd478f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 166 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f5eb9c [dwarf-read] process_queue: Done expanding CU at offset 0x3f5eb9c [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 165 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd916c [dwarf-read] process_queue: Done expanding CU at offset 0x3fd916c [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 164 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd1973 [dwarf-read] process_queue: Done expanding CU at offset 0x3fd1973 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 163 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd73b7 [dwarf-read] process_queue: Done expanding CU at offset 0x3fd73b7 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 162 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fcca75 [dwarf-read] process_queue: Done expanding CU at offset 0x3fcca75 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 161 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd98bd [dwarf-read] process_queue: Done expanding CU at offset 0x3fd98bd [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 160 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fca0f1 [dwarf-read] process_queue: Done expanding CU at offset 0x3fca0f1 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 159 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd9f5b [dwarf-read] process_queue: Done expanding CU at offset 0x3fd9f5b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 158 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd1e43 [dwarf-read] process_queue: Done expanding CU at offset 0x3fd1e43 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 157 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fca842 [dwarf-read] process_queue: Done expanding CU at offset 0x3fca842 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 156 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3fd05c2 [dwarf-read] process_queue: Done expanding CU at offset 0x3fd05c2 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 155 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f64557 [dwarf-read] process_queue: Done expanding CU at offset 0x3f64557 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 154 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x52ac21 [dwarf-read] process_queue: Done expanding CU at offset 0x52ac21 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 153 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x27e55e0 [dwarf-read] process_queue: Done expanding CU at offset 0x27e55e0 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 152 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x279a336 [dwarf-read] process_queue: Done expanding CU at offset 0x279a336 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 151 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x27840ec [dwarf-read] process_queue: Done expanding CU at offset 0x27840ec [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 150 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x274b286 [dwarf-read] process_queue: Done expanding CU at offset 0x274b286 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 149 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x26e62ff [dwarf-read] process_queue: Done expanding CU at offset 0x26e62ff [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 148 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x26b9f51 [dwarf-read] process_queue: Done expanding CU at offset 0x26b9f51 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 147 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x269fd16 [dwarf-read] process_queue: Done expanding CU at offset 0x269fd16 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 146 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2687a3d [dwarf-read] process_queue: Done expanding CU at offset 0x2687a3d [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 145 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2657176 [dwarf-read] process_queue: Done expanding CU at offset 0x2657176 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 144 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2596881 [dwarf-read] process_queue: Done expanding CU at offset 0x2596881 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 143 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3ec48bd [dwarf-read] process_queue: Done expanding CU at offset 0x3ec48bd [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 142 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x6a3f7e [dwarf-read] process_queue: Done expanding CU at offset 0x6a3f7e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 141 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1819031 [dwarf-read] process_queue: Done expanding CU at offset 0x1819031 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 140 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2733a91 [dwarf-read] process_queue: Done expanding CU at offset 0x2733a91 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 139 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x8c24ee [dwarf-read] process_queue: Done expanding CU at offset 0x8c24ee [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 138 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3ebb2ca [dwarf-read] process_queue: Done expanding CU at offset 0x3ebb2ca [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 137 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x18908 [dwarf-read] process_queue: Done expanding CU at offset 0x18908 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 136 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xc3fc29 [dwarf-read] process_queue: Done expanding CU at offset 0xc3fc29 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 135 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x411fbd [dwarf-read] process_queue: Done expanding CU at offset 0x411fbd [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 134 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x12f7398 [dwarf-read] process_queue: Done expanding CU at offset 0x12f7398 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 133 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xc59ee0 [dwarf-read] process_queue: Done expanding CU at offset 0xc59ee0 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 132 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1e7e6c6 [dwarf-read] process_queue: Done expanding CU at offset 0x1e7e6c6 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 131 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x271c860 [dwarf-read] process_queue: Done expanding CU at offset 0x271c860 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 130 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xcaaa5c [dwarf-read] process_queue: Done expanding CU at offset 0xcaaa5c [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 129 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2a3cb25 [dwarf-read] process_queue: Done expanding CU at offset 0x2a3cb25 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 128 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x5600e [dwarf-read] process_queue: Done expanding CU at offset 0x5600e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 127 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3ea4ba1 [dwarf-read] process_queue: Done expanding CU at offset 0x3ea4ba1 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 126 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x540b4d [dwarf-read] process_queue: Done expanding CU at offset 0x540b4d [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 125 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x195b64c [dwarf-read] process_queue: Done expanding CU at offset 0x195b64c [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 124 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xf34ae6 [dwarf-read] process_queue: Done expanding CU at offset 0xf34ae6 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 123 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x58e308 [dwarf-read] process_queue: Done expanding CU at offset 0x58e308 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 122 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x5db310 [dwarf-read] process_queue: Done expanding CU at offset 0x5db310 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 121 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x5f55ee [dwarf-read] process_queue: Done expanding CU at offset 0x5f55ee [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 120 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2d0bdeb [dwarf-read] process_queue: Done expanding CU at offset 0x2d0bdeb [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 119 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x33e7772 [dwarf-read] process_queue: Done expanding CU at offset 0x33e7772 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 118 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2289701 [dwarf-read] process_queue: Done expanding CU at offset 0x2289701 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 117 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x211987 [dwarf-read] process_queue: Done expanding CU at offset 0x211987 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 116 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1d36e5b [dwarf-read] process_queue: Done expanding CU at offset 0x1d36e5b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 115 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x220dd24 [dwarf-read] process_queue: Done expanding CU at offset 0x220dd24 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 114 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x245be52 [dwarf-read] process_queue: Done expanding CU at offset 0x245be52 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 113 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xc90a1a [dwarf-read] process_queue: Done expanding CU at offset 0xc90a1a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 112 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1f94f63 [dwarf-read] process_queue: Done expanding CU at offset 0x1f94f63 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 111 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x22ed3b [dwarf-read] process_queue: Done expanding CU at offset 0x22ed3b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 110 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x23ee825 [dwarf-read] process_queue: Done expanding CU at offset 0x23ee825 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 109 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x20741a6 [dwarf-read] process_queue: Done expanding CU at offset 0x20741a6 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 108 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x47e73a [dwarf-read] process_queue: Done expanding CU at offset 0x47e73a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 107 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1fb00f3 [dwarf-read] process_queue: Done expanding CU at offset 0x1fb00f3 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 106 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1dc37a4 [dwarf-read] process_queue: Done expanding CU at offset 0x1dc37a4 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 105 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xb42756 [dwarf-read] process_queue: Done expanding CU at offset 0xb42756 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 104 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x48bb55 [dwarf-read] process_queue: Done expanding CU at offset 0x48bb55 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 103 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x94927 [dwarf-read] process_queue: Done expanding CU at offset 0x94927 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 102 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x321ff0b [dwarf-read] process_queue: Done expanding CU at offset 0x321ff0b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 101 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x18c1296 [dwarf-read] process_queue: Done expanding CU at offset 0x18c1296 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 100 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2038613 [dwarf-read] process_queue: Done expanding CU at offset 0x2038613 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 99 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xd0a5e0 [dwarf-read] process_queue: Done expanding CU at offset 0xd0a5e0 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 98 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xcc5d06 [dwarf-read] process_queue: Done expanding CU at offset 0xcc5d06 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 97 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x19b046a [dwarf-read] process_queue: Done expanding CU at offset 0x19b046a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 96 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x65e258 [dwarf-read] process_queue: Done expanding CU at offset 0x65e258 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 95 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2a167c3 [dwarf-read] process_queue: Done expanding CU at offset 0x2a167c3 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 94 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x231738a [dwarf-read] process_queue: Done expanding CU at offset 0x231738a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 93 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2c7644c [dwarf-read] process_queue: Done expanding CU at offset 0x2c7644c [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 92 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x10f2d5 [dwarf-read] process_queue: Done expanding CU at offset 0x10f2d5 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 91 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x12de1a9 [dwarf-read] process_queue: Done expanding CU at offset 0x12de1a9 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 90 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2e9347 [dwarf-read] process_queue: Done expanding CU at offset 0x2e9347 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 89 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3ef2493 [dwarf-read] process_queue: Done expanding CU at offset 0x3ef2493 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 88 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x432a14 [dwarf-read] process_queue: Done expanding CU at offset 0x432a14 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 87 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x39b087 [dwarf-read] process_queue: Done expanding CU at offset 0x39b087 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 86 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x21583c4 [dwarf-read] process_queue: Done expanding CU at offset 0x21583c4 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 85 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x248fe51 [dwarf-read] process_queue: Done expanding CU at offset 0x248fe51 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 84 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2915856 [dwarf-read] process_queue: Done expanding CU at offset 0x2915856 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 83 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2628d36 [dwarf-read] process_queue: Done expanding CU at offset 0x2628d36 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 82 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x260a832 [dwarf-read] process_queue: Done expanding CU at offset 0x260a832 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 81 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2478fb3 [dwarf-read] process_queue: Done expanding CU at offset 0x2478fb3 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 80 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x5a0e95 [dwarf-read] process_queue: Done expanding CU at offset 0x5a0e95 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 79 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xda08da [dwarf-read] process_queue: Done expanding CU at offset 0xda08da [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 78 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x16524c3 [dwarf-read] process_queue: Done expanding CU at offset 0x16524c3 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 77 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x22c6693 [dwarf-read] process_queue: Done expanding CU at offset 0x22c6693 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 76 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x35811e3 [dwarf-read] process_queue: Done expanding CU at offset 0x35811e3 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 75 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x172a6f7 [dwarf-read] process_queue: Done expanding CU at offset 0x172a6f7 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 74 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x20d8a7e [dwarf-read] process_queue: Done expanding CU at offset 0x20d8a7e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 73 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x25bcc67 [dwarf-read] process_queue: Done expanding CU at offset 0x25bcc67 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 72 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x150e07c [dwarf-read] process_queue: Done expanding CU at offset 0x150e07c [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 71 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xaf493d [dwarf-read] process_queue: Done expanding CU at offset 0xaf493d [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 70 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x27cbbe6 [dwarf-read] process_queue: Done expanding CU at offset 0x27cbbe6 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 69 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x9530b7 [dwarf-read] process_queue: Done expanding CU at offset 0x9530b7 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 68 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x7c47f6 [dwarf-read] process_queue: Done expanding CU at offset 0x7c47f6 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 67 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xfa6635 [dwarf-read] process_queue: Done expanding CU at offset 0xfa6635 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 66 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x13f464f [dwarf-read] process_queue: Done expanding CU at offset 0x13f464f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 65 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x9bd82e [dwarf-read] process_queue: Done expanding CU at offset 0x9bd82e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 64 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x24ad9cb [dwarf-read] process_queue: Done expanding CU at offset 0x24ad9cb [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 63 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x256eab3 [dwarf-read] process_queue: Done expanding CU at offset 0x256eab3 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 62 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x24eed2d [dwarf-read] process_queue: Done expanding CU at offset 0x24eed2d [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 61 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1ff9d1a [dwarf-read] process_queue: Done expanding CU at offset 0x1ff9d1a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 60 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x6c2932 [dwarf-read] process_queue: Done expanding CU at offset 0x6c2932 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 59 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xf679f4 [dwarf-read] process_queue: Done expanding CU at offset 0xf679f4 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 58 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xe50cc7 [dwarf-read] process_queue: Done expanding CU at offset 0xe50cc7 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 57 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1a54b1 [dwarf-read] process_queue: Done expanding CU at offset 0x1a54b1 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 56 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2ed3119 [dwarf-read] process_queue: Done expanding CU at offset 0x2ed3119 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 55 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x319640 [dwarf-read] process_queue: Done expanding CU at offset 0x319640 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 54 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x261f3e [dwarf-read] process_queue: Done expanding CU at offset 0x261f3e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 53 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x229dde8 [dwarf-read] process_queue: Done expanding CU at offset 0x229dde8 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 52 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x4ef0fd [dwarf-read] process_queue: Done expanding CU at offset 0x4ef0fd [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 51 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x4c6367 [dwarf-read] process_queue: Done expanding CU at offset 0x4c6367 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 50 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2e1f513 [dwarf-read] process_queue: Done expanding CU at offset 0x2e1f513 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 49 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xd5ecc0 [dwarf-read] process_queue: Done expanding CU at offset 0xd5ecc0 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 48 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xd2a8c2 [dwarf-read] process_queue: Done expanding CU at offset 0xd2a8c2 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 47 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xaa65dd [dwarf-read] process_queue: Done expanding CU at offset 0xaa65dd [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 46 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xeb4338 [dwarf-read] process_queue: Done expanding CU at offset 0xeb4338 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 45 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x7f221f [dwarf-read] process_queue: Done expanding CU at offset 0x7f221f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 44 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x109c042 [dwarf-read] process_queue: Done expanding CU at offset 0x109c042 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 43 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xa71c0e [dwarf-read] process_queue: Done expanding CU at offset 0xa71c0e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 42 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x922e31 [dwarf-read] process_queue: Done expanding CU at offset 0x922e31 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 41 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x23c40e0 [dwarf-read] process_queue: Done expanding CU at offset 0x23c40e0 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 40 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x8d696f [dwarf-read] process_queue: Done expanding CU at offset 0x8d696f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 39 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3028d1b [dwarf-read] process_queue: Done expanding CU at offset 0x3028d1b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 38 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2424d3b [dwarf-read] process_queue: Done expanding CU at offset 0x2424d3b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 37 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x834f2d [dwarf-read] process_queue: Done expanding CU at offset 0x834f2d [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 36 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2381bea [dwarf-read] process_queue: Done expanding CU at offset 0x2381bea [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 35 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1b3b1db [dwarf-read] process_queue: Done expanding CU at offset 0x1b3b1db [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 34 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1b5267a [dwarf-read] process_queue: Done expanding CU at offset 0x1b5267a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 33 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f3a619 [dwarf-read] process_queue: Done expanding CU at offset 0x3f3a619 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 32 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x19158ac [dwarf-read] process_queue: Done expanding CU at offset 0x19158ac [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 31 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1d425bc [dwarf-read] process_queue: Done expanding CU at offset 0x1d425bc [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 30 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1e08598 [dwarf-read] process_queue: Done expanding CU at offset 0x1e08598 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 29 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x335d98 [dwarf-read] process_queue: Done expanding CU at offset 0x335d98 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 28 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3f0a9c3 [dwarf-read] process_queue: Done expanding CU at offset 0x3f0a9c3 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 27 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1751a9a [dwarf-read] process_queue: Done expanding CU at offset 0x1751a9a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 26 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xbfb91f [dwarf-read] process_queue: Done expanding CU at offset 0xbfb91f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 25 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x824e3f [dwarf-read] process_queue: Done expanding CU at offset 0x824e3f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 24 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x36b675 [dwarf-read] process_queue: Done expanding CU at offset 0x36b675 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 23 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x17709af [dwarf-read] process_queue: Done expanding CU at offset 0x17709af [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 22 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x5c2f2a [dwarf-read] process_queue: Done expanding CU at offset 0x5c2f2a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 21 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2113e3b [dwarf-read] process_queue: Done expanding CU at offset 0x2113e3b [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 20 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x16f9378 [dwarf-read] process_queue: Done expanding CU at offset 0x16f9378 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 19 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3d68bff [dwarf-read] process_queue: Done expanding CU at offset 0x3d68bff [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 18 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2ee912e [dwarf-read] process_queue: Done expanding CU at offset 0x2ee912e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 17 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1d6e389 [dwarf-read] process_queue: Done expanding CU at offset 0x1d6e389 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 16 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x899f35 [dwarf-read] process_queue: Done expanding CU at offset 0x899f35 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 15 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3d4943e [dwarf-read] process_queue: Done expanding CU at offset 0x3d4943e [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 14 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x14061f1 [dwarf-read] process_queue: Done expanding CU at offset 0x14061f1 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 13 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0xfe5f15 [dwarf-read] process_queue: Done expanding CU at offset 0xfe5f15 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 12 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1935864 [dwarf-read] process_queue: Done expanding CU at offset 0x1935864 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 11 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x21879b7 [dwarf-read] process_queue: Done expanding CU at offset 0x21879b7 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 10 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3d80b7f [dwarf-read] process_queue: Done expanding CU at offset 0x3d80b7f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 9 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1369c61 [dwarf-read] process_queue: Done expanding CU at offset 0x1369c61 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 8 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x1a76f08 [dwarf-read] process_queue: Done expanding CU at offset 0x1a76f08 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 7 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x7094f9 [dwarf-read] process_queue: Done expanding CU at offset 0x7094f9 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 6 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x12b9fd7 [dwarf-read] process_queue: Done expanding CU at offset 0x12b9fd7 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 5 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x38abde7 [dwarf-read] process_queue: Done expanding CU at offset 0x38abde7 [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 4 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x19d1d2f [dwarf-read] process_queue: Done expanding CU at offset 0x19d1d2f [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 3 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x3ef7e0a [dwarf-read] process_queue: Done expanding CU at offset 0x3ef7e0a [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 2 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x2bf61ae [dwarf-read] process_queue: Done expanding CU at offset 0x2bf61ae [dwarf-read] process_queue: Expanding symtabs of objfile cc1, queue size: 1 ... [dwarf-read] process_queue: Expanding symtab of CU at offset 0x765489 [dwarf-read] process_queue: Done expanding CU at offset 0x765489 [dwarf-read] process_queue: Done expanding symtabs of cc1. Breakpoint 1 at 0xd40e30: do_rpo_vn. (2 locations) ...
2022-07-21[gdbsupport] Use task size in parallel_for_eachTom de Vries2-22/+84
Ensuring a fair distribution over the worker threads and main thread in terms of number of CUs might not be the most efficient way, given that CUs can vary in size. Fix this by: - adding a task_size_ptr parameter to parallel_for_each, defaulting to nullptr, - using per_cu->get_length () as the task size in the parallel_for_each in dwarf2_build_psymtabs_hard, and - using the task size in parallel_for_each to distribute similarly-sized tasks to the threads. I've used this experiment to verify the performance impact: ... $ for n in $(seq 1 10); do \ time gdb -q -batch ~/firefox/libxul.so-93.0-1.1.x86_64.debug \ 2>&1 \ | grep "real:"; \ done ... and without the patch got: ... real: 4.71 real: 4.88 real: 4.29 real: 4.30 real: 4.65 real: 4.27 real: 4.27 real: 4.27 real: 4.75 real: 4.41 ... and with the patch: ... real: 3.68 real: 3.81 real: 3.80 real: 3.68 real: 3.75 real: 3.69 real: 3.69 real: 3.74 real: 3.67 real: 3.74 ... so that seems a reasonable improvement. With parallel_for_each_debug set to true, we get some more detail about the difference in behaviour. Without the patch we have: ... Parallel for: n_elements: 2818 Parallel for: minimum elements per thread: 1 Parallel for: elts_per_thread: 704 Parallel for: elements on worker thread 0 : 705 Parallel for: elements on worker thread 1 : 705 Parallel for: elements on worker thread 2 : 704 Parallel for: elements on worker thread 3 : 0 Parallel for: elements on main thread : 704 ... and with the patch: ... Parallel for: n_elements: 2818 Parallel for: total_size: 1483674865 Parallel for: size_per_thread: 370918716 Parallel for: elements on worker thread 0 : 752 (size: 371811790) Parallel for: elements on worker thread 1 : 360 (size: 371509370) Parallel for: elements on worker thread 2 : 1130 (size: 372681710) Parallel for: elements on worker thread 3 : 0 (size: 0) Parallel for: elements on main thread : 576 (size: 367671995) ... Tested on x86_64-linux.
2022-07-21[gdb/python] Fix typo in test_pythonTom de Vries1-1/+1
Fix typo in ref_output_0 variable in test_python. Tested by running the selftest on x86_64-linux with python 3.11.
2022-07-21[gdb/python] Fix python selftest with python 3.11Tom de Vries1-4/+7
With python 3.11 I noticed: ... $ gdb -q -batch -ex "maint selftest python" Running selftest python. Self test failed: self-test failed at gdb/python/python.c:2246 Ran 1 unit tests, 1 failed ... In more detail: ... (gdb) p output $5 = "Traceback (most recent call last):\n File \"<string>\", line 0, \ in <module>\nKeyboardInterrupt\n" (gdb) p ref_output $6 = "Traceback (most recent call last):\n File \"<string>\", line 1, \ in <module>\nKeyboardInterrupt\n" ... Fix this by also allowing line number 0. Tested on x86_64-linux. This should hopefully fix buildbot builder gdb-rawhide-x86_64.
2022-07-21[gdbsupport] Fix type of parallel_for_each_debugTom de Vries1-1/+1
When I changed the initialization of parallel_for_each_debug from 0 to false, I forgot to change the type from int to bool. Fix this. Tested by rebuilding on x86_64-linux.
2022-07-21[gdb/symtab] Fix bad compile unit index complaintTom de Vries1-9/+17
I noticed this code in dw2_debug_names_iterator::next: ... case DW_IDX_compile_unit: /* Don't crash on bad data. */ if (ull >= per_bfd->all_comp_units.size ()) { complaint (_(".debug_names entry has bad CU index %s" " [in module %s]"), pulongest (ull), objfile_name (objfile)); continue; } per_cu = per_bfd->get_cu (ull); break; ... This code used to DTRT, before we started keeping both CUs and TUs in all_comp_units. Fix by using "per_bfd->all_comp_units.size () - per_bfd->tu_stats.nr_tus" instead. It's hard to produce a test-case for this, but let's try at least to trigger the complaint somehow. We start out by creating an exec with .debug_types and .debug_names: ... $ gcc -g ~/hello.c -fdebug-types-section $ gdb-add-index -dwarf-5 a.out ... and verify that we don't see any complaints: ... $ gdb -q -batch -iex "set complaints 100" ./a.out ... We look at the CU and TU table using readelf -w and conclude that we have nr_cus == 6 and nr_tus == 1. Now override ull in dw2_debug_names_iterator::next for the DW_IDX_compile_unit case to 6, and we have: ... $ gdb -q -batch -iex "set complaints 100" ./a.out During symbol reading: .debug_names entry has bad CU index 6 [in module a.out] ... After this, it still crashes because this code in dw2_debug_names_iterator::next: ... /* Skip if already read in. */ if (m_per_objfile->symtab_set_p (per_cu)) goto again; ... is called with per_cu == nullptr. Fix this by skipping the entry if per_cu == nullptr. Now revert the fix and observe that the complaint disappears, so we've confirmed that the fix is required. A somewhat similar issue for .gdb_index in dw2_symtab_iter_next has been filed as PR29367. Tested on x86_64-linux, with native and target board cc-with-debug-names. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29336
2022-07-21x86: replace wrong attributes on VCVTDQ2PH{X,Y}Jan Beulich2-4/+4
A standalone (without SAE) StaticRounding attribute is meaningless, and indeed all other similar insns have ATTSyntax there instead. I can only assume this was some strange copy-and-paste mistake.
2022-07-21x86/Intel: correct AVX512F scatter insn element sizesJan Beulich4-40/+40
I clearly screwed up in 6ff00b5e12e7 ("x86/Intel: correct permitted operand sizes for AVX512 scatter/gather") giving all AVX512F scatter insns Dword element size. Update testcases (also their gather parts), utilizing that there previously were two identical lines each (for no apparent reason).
2022-07-21PR29390, DW_CFA_AARCH64_negate_ra_state vs. DW_CFA_GNU_window_saveAlan Modra3-5/+14
PR 29390 binutils/ * dwarf.c (is_aarch64, DW_CFA_GNU_window_save_name): New. (display_debug_frames): Use them. (init_dwarf_regnames_aarch64): Set is_aarch64. (init_dwarf_regnames_by_elf_machine_code): Clear is_aarch64. (init_dwarf_regnames_by_bfd_arch_and_mach): Likewise. gas/ * testsuite/gas/aarch64/pac_ab_key.d: Adjust expected output. * testsuite/gas/aarch64/pac_negate_ra_state.d: Likewise.
2022-07-21PR29337, readelf CU/TU mixup in .gdb_indexAlan Modra1-2/+2
Commit 244e19c79111 changed a number of variables in display_gdb_index to count entries rather than words. PR 29337 * dwarf.c (display_gdb_index): Correct use of cu_list_elements.
2022-07-21PR29370, infinite loop in display_debug_abbrevAlan Modra1-13/+6
The PR29370 testcase is a fuzzed object file with multiple .trace_abbrev sections. Multiple .trace_abbrev or .debug_abbrev sections are not a violation of the DWARF standard. The DWARF5 standard even gives an example of multiple .debug_abbrev sections contained in groups. Caching and lookup of processed abbrevs thus needs to be done by section and offset rather than base and offset. (Why base anyway?) Or, since section contents are kept, by a pointer into the contents. PR 29370 * dwarf.c (struct abbrev_list): Replace abbrev_base and abbrev_offset with raw field. (find_abbrev_list_by_abbrev_offset): Delete. (find_abbrev_list_by_raw_abbrev): New function. (process_abbrev_set): Set list->raw and list->next. (find_and_process_abbrev_set): Replace abbrev list lookup with new function. Don't set list abbrev_base, abbrev_offset or next.
2022-07-21binutils/dwarf.c: abbrev cachingAlan Modra1-98/+110
I'm inclined to think that abbrev caching is counter-productive. The time taken to search the list of abbrevs converted to internal form is non-zero, and it's easy to decode the raw abbrevs. It's especially silly to cache empty lists of decoded abbrevs (happens with zero padding in .debug_abbrev), or abbrevs as they are displayed when there is no further use of those abbrevs. This patch stops caching in those cases. * dwarf.c (record_abbrev_list_for_cu): Add free_list param. Put abbrevs on abbrev_lists here. (new_abbrev_list): Delete function. (process_abbrev_set): Return newly allocated list. Move abbrev base, offset and size checking to.. (find_and_process_abbrev_set): ..here, new function. Handle lookup of cached abbrevs here, and calculate start and end for process_abbrev_set. Return free_list if newly alloc'd. (process_debug_info): Consolidate cached list lookup, new list alloc and processing into find_and_process_abbrev_set call. Free list when not cached. (display_debug_abbrev): Similarly.
2022-07-21miscellaneous dwarf.c tidiesAlan Modra1-110/+106
* dwarf.c: Leading and trailing whitespace fixes. (free_abbrev_list): New function. (free_all_abbrevs): Use the above. Free cu_abbrev_map here too. (process_abbrev_set): Print actual section name on error. (get_type_abbrev_from_form): Add overflow check. (free_debug_memory): Don't free cu_abbrev_map here.. (process_debug_info): ..or here. Warn on another case of not finding a neeeded abbrev.
2022-07-21PowerPC64: fix build error on 32-bit hostsAlan Modra1-1/+1
elf64-ppc.c:11673:33: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘bfd_vma’ {aka ‘long long unsigned int’} [-Werror=format=] 11673 | fprintf (stderr, "offset = %#lx:", stub_entry->stub_offset); | ~~~^ ~~~~~~~~~~~~~~~~~~~~~~~ | | | | | bfd_vma {aka long long unsigned int} | long unsigned int | %#llx * elf64-ppc.c (dump_stub): Use BFD_VMA_FMT.
2022-07-20Wrap python_write_bytecode with HAVE_PYTHON ifdefKevin Buettner1-0/+2
This commit fixes a build error on machines lacking python headers and/or libraries.
2022-07-21Automatic date update in version.inGDB Administrator1-1/+1
2022-07-20Handle Python 3.11 deprecation of PySys_SetPath and Py_SetProgramNameKevin Buettner2-18/+86
Python 3.11 deprecates PySys_SetPath and Py_SetProgramName. The PyConfig API replaces these and other functions. This commit uses the PyConfig API to provide equivalent functionality while also preserving support for older versions of Python, i.e. those before Python 3.8. A beta version of Python 3.11 is available in Fedora Rawhide. Both Fedora 35 and Fedora 36 use Python 3.10, while Fedora 34 still used Python 3.9. I've tested these changes on Fedora 34, Fedora 36, and rawhide, though complete testing was not possible on rawhide due to a kernel bug. That being the case, I decided to enable the newer PyConfig API by testing PY_VERSION_HEX against 0x030a0000. This corresponds to Python 3.10. We could try to use the PyConfig API for Python versions as early as 3.8, but I'm reluctant to do this as there may have been PyConfig related bugs in earlier versions which have since been fixed. Recent linux distributions should have support for Python 3.10. This should be more than adequate for testing the new Python initialization code in GDB. Information about the PyConfig API as well as the motivation behind deprecating the old interface can be found at these links: https://github.com/python/cpython/issues/88279 https://peps.python.org/pep-0587/ https://docs.python.org/3.11/c-api/init_config.html The v2 commit also addresses several problems that Simon found in the v1 version. In v1, I had used Py_DontWriteBytecodeFlag in the new initialization code, but Simon pointed out that this global configuration variable will be deprecated in Python 3.12. This version of the patch no longer uses Py_DontWriteBytecodeFlag in the new initialization code. Additionally, both Py_DontWriteBytecodeFlag and Py_IgnoreEnvironmentFlag will no longer be used when building GDB against Python 3.10 or higher. While it's true that both of these global configuration variables are deprecated in Python 3.12, it makes sense to disable their use for gdb builds against 3.10 and higher since those are the versions for which the PyConfig API is now being used by GDB. (The PyConfig API includes different mechanisms for making the same settings afforded by use of the soon-to-be deprecated global configuration variables.) Simon also noted that PyConfig_Clear() would not have be called for one of the failure paths. I've fixed that problem and also made the rest of the "bail out" code more direct. In particular, PyConfig_Clear() will always be called, both for success and failure. The v3 patch addresses some rebase conflicts related to module initialization . Commit 3acd9a692dd ("Make 'import gdb.events' work") uses PyImport_ExtendInittab instead of PyImport_AppendInittab. That commit also initializes a struct for each module to import. Both the initialization and the call to were moved ahead of the ifdefs to avoid having to replicate (at least some of) the code three times in various portions of the ifdefs. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28668 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29287
2022-07-20gdb/value.c: add several headers to the include listChristopher Di Bella1-0/+3
Building GDB currently fails to build with libc++, because libc++ is stricter about which headers "leak" entities they're not guaranteed to support. The following headers have been added: * `<iterator>`, to support `std::back_inserter` * `<utility>`, to support `std::move` and `std::swap` * `<vector>`, to support `std::vector` Change-Id: Iaeb15057c5fbb43217df77ce34d4e54446dbcf3d
2022-07-20Don't stop all threads prematurely after first step of "step N"Pedro Alves3-5/+124
In all-stop mode, when the target is itself in non-stop mode (like GNU/Linux), if you use the "step N" (or "stepi/next/nexti N") to step a thread a number of times: (gdb) help step step, s Step program until it reaches a different source line. Usage: step [N] Argument N means step N times (or till program stops for another reason). ... GDB prematurely stops all threads after the first step, and doesn't re-resume them for the subsequent N-1 steps. It's as if for the 2nd and subsequent steps, the command was running with scheduler-locking enabled. This can be observed with the testcase added by this commit, which looks like this: static pthread_barrier_t barrier; static void * thread_func (void *arg) { pthread_barrier_wait (&barrier); return NULL; } int main () { pthread_t thread; int ret; pthread_barrier_init (&barrier, NULL, 2); /* We run to this line below, and then issue "next 3". That should step over the 3 lines below and land on the return statement. If GDB prematurely stops the thread_func thread after the first of the 3 nexts (and never resumes it again), then the join won't ever return. */ pthread_create (&thread, NULL, thread_func, NULL); /* set break here */ pthread_barrier_wait (&barrier); pthread_join (thread, NULL); return 0; } The test hangs and times out without the GDB fix: (gdb) next 3 [New Thread 0x7ffff7d89700 (LWP 525772)] FAIL: gdb.threads/step-N-all-progress.exp: non-stop=off: target-non-stop=on: next 3 (timeout) The problem is a core gdb bug. When you do "step/stepi/next/nexti N", GDB internally creates a thread_fsm object and associates it with the stepping thread. For the stepping commands, the FSM's class is step_command_fsm. That object is what keeps track of how many steps are left to make. When one step finishes, handle_inferior_event calls stop_waiting and returns, and then fetch_inferior_event calls the "should_stop" method of the event thread's FSM. The implementation of that method decrements the steps-left counter. If the counter is 0, it returns true and we proceed to presenting the stop to the user. If it isn't 0 yet, then the method returns false, indicating to fetch_inferior_event to "keep going". Focusing now on when the first step finishes -- we're in "all-stop" mode, with the target in non-stop mode. When a step finishes, handle_inferior_event calls stop_waiting, which itself calls stop_all_threads to stop everything. I.e., after the first step completes, all threads are stopped, before handle_inferior_event returns. And after that, now in fetch_inferior_event, we consult the thread's thread_fsm::should_stop, which as we've seen, for the first step returns false -- i.e., we need to keep_going for another step. However, since the target is in non-stop mode, keep_going resumes _only_ the current thread. All the other threads remain stopped, inadvertently. If the target is in non-stop mode, we don't actually need to stop all threads right after each step finishes, and then re-resume them again. We can instead defer stopping all threads until all the steps are completed. So fix this by delaying the stopping of all threads until after we called the FSM's "should_stop" method. I.e., move it from stop_waiting, to handle_inferior_events's callers, fetch_inferior_event and wait_for_inferior. New test included. Tested on x86-64 GNU/Linux native and gdbserver. Change-Id: Iaad50dcfea4464c84bdbac853a89df92ade6ae01
2022-07-20Re: opcodes/arc: Implement style support in the disassemblerAlan Modra1-1/+1
* arc-dis.c (print_insn_arc): Fix thinko.
2022-07-20gas/symbols: introduce md_resolve_symbolDmitry Selyutin2-0/+45
Assuming GMSD is a special operand, marked as O_md1, the code: .set VREG, GMSD .set REG, VREG extsw REG, 2 ...fails upon attempts to resolve the value of the symbol. This happens since machine-dependent values are not handled in the giant op switch. We introduce a custom md_resolve_symbol macro; the ports can use this macro to customize the behavior when resolve_symbol_value hits O_md operand.
2022-07-20Automatic date update in version.inGDB Administrator1-1/+1
2022-07-19x86: Disallow invalid relocations against protected symbolsH.J. Lu11-24/+47
Since glibc 2.36 will issue warnings for copy relocation against protected symbols and non-canonical reference to canonical protected functions, change the linker to always disallow such relocations. bfd/ * elf32-i386.c (elf_i386_scan_relocs): Remove check for elf_has_indirect_extern_access. * elf64-x86-64.c (elf_x86_64_scan_relocs): Likewise. (elf_x86_64_relocate_section): Remove check for elf_has_no_copy_on_protected. * elfxx-x86.c (elf_x86_allocate_dynrelocs): Check for building executable instead of elf_has_no_copy_on_protected. (_bfd_x86_elf_adjust_dynamic_symbol): Disallow copy relocation against non-copyable protected symbol. * elfxx-x86.h (SYMBOL_NO_COPYRELOC): Remove check for elf_has_no_copy_on_protected. ld/ * testsuite/ld-i386/i386.exp: Expect linker error for PR ld/17709 test. * testsuite/ld-i386/pr17709.rd: Removed. * testsuite/ld-i386/pr17709.err: New file. * testsuite/ld-x86-64/pr17709.rd: Removed. * testsuite/ld-x86-64/pr17709.err: New file. * testsuite/ld-x86-64/pr28875-func.err: Updated. * testsuite/ld-x86-64/x86-64.exp: Expect linker error for PR ld/17709 test. Add tests for function pointer against protected function.
2022-07-19x86: Make protected symbols local for -sharedFangrui Song13-39/+24
Call _bfd_elf_symbol_refs_local_p with local_protected==true. This has 2 noticeable effects for -shared: * GOT-generating relocations referencing a protected data symbol no longer lead to a GLOB_DAT (similar to a hidden symbol). * Direct access relocations (e.g. R_X86_64_PC32) no longer has the confusing diagnostic below. __attribute__((visibility("protected"))) void *foo() { return (void *)foo; } // gcc -fpic -shared -fuse-ld=bfd relocation R_X86_64_PC32 against protected symbol `foo' can not be used when making a shared object The new behavior matches arm, aarch64 (commit 83c325007c5599fa9b60b8d5f7b84842160e1d1b), and powerpc ports, and other linkers: gold and ld.lld. Note: if some code tries to use direct access relocations to take the address of foo, the pointer equality will break, but the error should be reported on the executable link, not on the innocent shared object link. glibc 2.36 will give a warning at relocation resolving time. With this change, `#define elf_backend_extern_protected_data 1` is no longer effective. Just remove it. Remove the test "Run protected-func-1 without PIE" since -fno-pic address taken operation in the executable doesn't work with protected symbol in a shared object by default. Similarly, remove protected-data-1a and protected-data-1b. protected-data-1b can be made working by removing HAVE_LD_PIE_COPYRELOC from GCC (https://sourceware.org/pipermail/gcc-patches/2022-June/596678.html).
2022-07-19Reformat gdbarch-components.py to fix deviationsLuis Machado1-1/+6
Reformat to make sure we have a clean file with no deviations from the expected python code format.
2022-07-19[AArch64] MTE corefile supportLuis Machado17-8/+1048
Teach GDB how to dump memory tags for AArch64 when using the gcore command and how to read memory tag data back from a core file generated by GDB (via gcore) or by the Linux kernel. The format is documented in the Linux Kernel documentation [1]. Each tagged memory range (listed in /proc/<pid>/smaps) gets dumped to its own PT_AARCH64_MEMTAG_MTE segment. A section named ".memtag" is created for each of those segments when reading the core file back. To save a little bit of space, given MTE tags only take 4 bits, the memory tags are stored packed as 2 tags per byte. When reading the data back, the tags are unpacked. I've added a new testcase to exercise the feature. Build-tested with --enable-targets=all and regression tested on aarch64-linux Ubuntu 20.04. [1] Documentation/arm64/memory-tagging-extension.rst (Core Dump Support)
2022-07-19[AArch64] Support AArch64 MTE memory tag dumps in core filesLuis Machado3-0/+93
The Linux kernel can dump memory tag segments to a core file, one segment per mapped range. The format and documentation can be found in the Linux kernel tree [1]. The following patch adjusts bfd and binutils so they can handle this new segment type and display it accordingly. It also adds code required so GDB can properly read/dump core file data containing memory tags. Upon reading, each segment that contains memory tags gets mapped to a section named "memtag". These sections will be used by GDB to lookup the tag data. There can be multiple such sections with the same name, and they are not numbered to simplify GDB's handling and lookup. There is another patch for GDB that enables both reading and dumping of memory tag segments. Tested on aarch64-linux Ubuntu 20.04. [1] Documentation/arm64/memory-tagging-extension.rst (Core Dump Support)
2022-07-19[AArch64] Fix testcase compilation failureLuis Machado1-5/+10
Newer distros carry newer headers that contains MTE definitions. Account for that fact in the MTE testcases (gdb.arch/aarch64-mte.exp) and define constants conditionally to prevent compilation failures.
2022-07-18ld: Pass -nostdlib to compiler with -rH.J. Lu1-1/+1
Pass -nostdlib to compiler with -r to avoid unnecessary .o file and libraries. PR ld/29377 * testsuite/ld-elf/linux-x86.exp: Pass -nostdlib with -r.
2022-07-18x86: Properly check invalid relocation against protected symbolH.J. Lu5-0/+35
Only check invalid relocation against protected symbol defined in shared object. bfd/ PR ld/29377 * elf32-i386.c (elf_i386_scan_relocs): Only check invalid relocation against protected symbol defined in shared object. * elf64-x86-64.c (elf_x86_64_scan_relocs): Likewise. ld/ PR ld/29377 * testsuite/ld-elf/linux-x86.exp: Run PR ld/29377 tests. * testsuite/ld-elf/pr29377a.c: New file. * testsuite/ld-elf/pr29377b.c: Likewise.
2022-07-19Automatic date update in version.inGDB Administrator1-1/+1
generated by cgit v1.1 at 2024-11-21 15:32:18 +0000