aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-09-28Automatic date update in version.inGDB Administrator1-1/+1
2018-09-27testsuite: Fix race condition in check-libthread-dbAlan Hayward2-0/+14
It is possible for the created thread to reach the breakpoint before the main thread has set errno to 23. Prevent this using a pthread barrier. * gdb.threads/check-libthread-db.c (thread_routine): Use a pthread barrier. (main): Likewise.
2018-09-27Automatic date update in version.inGDB Administrator1-1/+1
2018-09-26Skip broken assembler test on Windows host.Sandra Loosemore2-1/+10
2018-09-26 Sandra Loosemore <sandra@codesourcery.com> gas/ * testsuite/gas/all/gas.exp: Skip "Output file must be distinct from input" test on Windows host.
2018-09-26gdb/riscv: Improve non-dwarf stack unwindingAndrew Burgess7-21/+189
This commit improves the prologue scanning stack unwinder, to better support AUIPC, LUI, and more variants of ADD and ADDI. This allows unwinding over frames containing large local variables, where the frame size does not fit into a single instruction immediate, and is first loaded into a temporary register, before being added to the stack pointer. A new test is added that tests this behaviour. As there's nothing truely RiscV specific about this test I've added it into gdb.base, but as this depends on target specific code to perform the unwind it is possible that some targets might fail this new test. gdb/ChangeLog: * riscv-tdep.c (riscv_insn::decode): Decode c.lui. (riscv_scan_prologue): Split handling of AUIPC, LUI, ADD, ADDI, and NOP. gdb/testsuite/ChangeLog: * gdb.base/large-frame-1.c: New file. * gdb.base/large-frame-2.c: New file. * gdb.base/large-frame.exp: New file. * gdb.base/large-frame.h: New file.
2018-09-26elf32-nds32: Remove elf32_nds32_allocate_dynrelocsSimon Marchi2-13/+4
It is unused, removing it fixes this error when building with clang: /home/emaisin/src/binutils-gdb/bfd/elf32-nds32.c:3172:1: error: unused function 'elf32_nds32_allocate_dynrelocs' [-Werror,-Wunused-function] elf32_nds32_allocate_dynrelocs (struct bfd_link_info *info, asection *sreloc, ^ 1 error generated. gcc only reports the error if you remove "inline". I don't know if this is actually a mistake and it should actually be used though. gdb/ChangeLog: * elf32-nds32.c (elf32_nds32_allocate_dynrelocs): Remove.
2018-09-26Remove dead definition from valops.cTom Tromey2-7/+4
This removes a variable definition in valops.c that has been surrounded by "#if 0" since gdb moved to sourceware. gdb/ChangeLog 2018-09-26 Tom Tromey <tom@tromey.com> * valops.c (auto_abandon): Remove dead code.
2018-09-26Small fix for "winheight" usageTom Tromey2-1/+5
I noticed that the usage string for "winheight" has a couple of extraneous ">"s in it. I must have forgotten to remove these back when I changed the text to use the GNU style for metasyntactic variables. gdb/ChangeLog 2018-09-26 Tom Tromey <tom@tromey.com> * tui/tui-win.c (WIN_HEIGHT_USAGE): Remove extra ">"s.
2018-09-26Automatic date update in version.inGDB Administrator1-1/+1
2018-09-25RISC-V: Give error for RVE PLTs.Jim Wilson2-8/+46
bfd/ * elfnn-riscv.c (riscv_make_plt_header): New arg output_bfd. Change return type to bfd_boolean. If EF_RISCV_RVE call _bfd_error_handler and return FALSE. Return TRUE at end. (riscv_make_plt_entry): Likewise. (riscv_elf_finish_dynamic_symbol): Update call to riscv_make_plt_entry. (riscv_elf_finish_dynamic_sections): Update call to riscv_make_plt_header.
2018-09-25S/390: Fix symbolic displacement in layAndreas Krebbel4-1/+8
Increase the fixup length to 4 for the 20 bit displacement. gas/ChangeLog: 2018-09-25 Andreas Krebbel <krebbel@linux.ibm.com> * config/tc-s390.c (md_apply_fix): Set fx_size to 4 for 20 bit displacements. * testsuite/gas/s390/s390.exp: Run new test. * testsuite/gas/s390/zarch-z990-symbol-lay.s: New test.
2018-09-25Remove dead code from gdbserver's configureTom Tromey3-11/+5
gdbserver's configure removes -Wmissing-prototypes from the warning flags. However, this flag is only useful for C, so this deletion is no longer needed. gdb/gdbserver/ChangeLog 2018-09-25 Tom Tromey <tom@tromey.com> * configure: Rebuild. * configure.ac (WARN_CFLAGS): Don't remove -Wmissing-prototypes.
2018-09-25Couple of minor tweaks to the linker testsuite.Eric Botcazou3-1/+15
This gets rid of the couple of linker failures for visium-elf: FAIL: ld-elf/pr14156b FAIL: ld-elf/pr22677 by tweaking the respective testcases. The first tweak is the same as the one made to the sibling testcase ld-elf/pr14156a.d about one year ago and the second tweak adds the usual main/start/_start/__start symbols. ld/ * testsuite/ld-elf/pr14156b.d: Adjust for extra symbols. * testsuite/ld-elf/pr22677.s: Define main/start/_start/__start.
2018-09-25Automatic date update in version.inGDB Administrator1-1/+1
2018-09-24RISC-V: For PCREL_LO12, fix addend handling in auipc lookup.Jim Wilson2-2/+11
bfd/ * elfnn-riscv.c (_bfd_riscv_relax_pc) <R_RISCV_PCREL_LO12_I>: New local hi_sec_off which is symbol address with addend subtracted. Use in riscv_find_pcgp_hi_reloc and riscv_record_pcgp_lo_reloc calls.
2018-09-24RISC-V: Allow pcrel_lo addends, error on addend overflow.Jim Wilson7-13/+58
bfd/ * elfnn-riscv.c (riscv_resolve_pcrel_lo_relocs): Add check for reloc overflow with addend. Use reloc_dangerous instead of reloc_overflow. Add strings for the two errors handled here. (riscv_elf_relocate_section) In case R_RISCV_PCREL_LO12_I, rewrite comment. Only give error with addend when used with section symbol. In case bfd_reloc_dangerous, update error string. ld/ * testsuite/ld-riscv-elf/ld-riscv-elf.exp: Run pcrel-lo-addend-2. * testsuite/ld-riscv/elf/ld-riscv-elf/pcrel-lo-addend-2.d: New. * testsuite/ld-riscv/elf/ld-riscv-elf/pcrel-lo-addend-2.s: New. * testsuite/ld-riscv/elf/ld-riscv-elf/pcrel-lo-addend.d: Update name and error string.
2018-09-24Fix PR gdb/20948: --write option to GDB causes segmentation faultJozef Lawrynowicz5-0/+91
When opening a BFD for update, as gdb --write does, modifications to anything but the contents of sections is restricted. Do not try to write back any ELF headers in this case. bfd/ChangeLog 2018-09-24 Jozef Lawrynowicz <jozef.l@mittosystems.com> PR gdb/20948 * elf.c (_bfd_elf_write_object_contents): Return from function early if abfd->direction == both_direction. gdb/testsuite/ChangeLog 2018-09-24 Jozef Lawrynowicz <jozef.l@mittosystems.com> PR gdb/20948 * gdb.base/write_mem.exp: New test. * gdb.base/write_mem.c: Likewise.
2018-09-24Add "const" to a few locals in gdbTom Tromey4-4/+11
I noticed that some code in gdb was doing: char *mumble = getenv (...) However, using "const char *" here would be clearer. This patch fixes the instances I could readily build. Tested by rebuilding. gdb/ChangeLog 2018-09-24 Tom Tromey <tom@tromey.com> * common/pathstuff.c (get_standard_cache_dir): Make "xdg_cache_home" and "home" const. * top.c (init_history): Make "tmpenv" const. * main.c (get_init_files): Make "homedir" const.
2018-09-23Allow setting a parameter to raise gdb.GdbErrorTom Tromey6-4/+57
A convention in the Python layer is that raising a gdb.GdbError will not print the Python stack -- instead the exception is treated as any other gdb exception. PR python/18852 asks that this treatment be extended the the get_set_value method of gdb.Parameter. This makes sense, because it lets Python-created parameters act like gdb parameters. 2018-09-23 Tom Tromey <tom@tromey.com> PR python/18852: * python/py-param.c (get_set_value): Use gdbpy_handle_exception. gdb/doc/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/18852: * python.texi (Parameters In Python): Document exception behavior of get_set_string. gdb/testsuite/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/18852: * gdb.python/py-parameter.exp: Add test for parameter that throws on "set".
2018-09-23Consolidate gdb.GdbError handlingTom Tromey5-97/+66
I noticed two nearly identical copies of the same code for handling gdb.GdbError. The only differences were in some error messages. These differences didn't seem very important, so this patch pulls the code out into a new function. 2018-09-23 Tom Tromey <tom@tromey.com> * python/py-function.c (fnpy_call): Use gdbpy_handle_exception. * python/py-cmd.c (cmdpy_function): Use gdbpy_handle_exception. * python/python-internal.h (gdbpy_handle_exception): Declare. * python/py-utils.c (gdbpy_handle_exception): New function.
2018-09-23Check for negative argument in Type.template_argumentTom Tromey4-0/+23
typy_template_argument did not check if the template argument was non-negative. A negative value could cause a gdb crash. 2018-09-23 Tom Tromey <tom@tromey.com> PR python/17284: * python/py-type.c (typy_template_argument): Check for negative argument number. gdb/testsuite/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/17284: * gdb.python/py-template.exp (test_template_arg): Add test for negative template argument number.
2018-09-23Report Python errors coming from gdb.post_eventTom Tromey4-3/+23
PR python/14062 points out that errors coming from the gdb.post_event callback are not reported. This can make it hard to understand why your Python code in gdb isn't working. Because users have control over whether exceptions are printed at all, it seems good to simply have post_event report errors in the usual way. 2018-09-23 Tom Tromey <tom@tromey.com> PR python/14062: * python/python.c (gdbpy_run_events): Do not ignore exceptions. gdb/testsuite/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/14062: * gdb.python/python.exp: Add test for post_event error.
2018-09-23Allow conversion of pointers to Python intTom Tromey4-3/+23
PR python/18170 questions why it's not possible to convert a pointer value to a Python int. Digging a bit shows that the Python 2.7 int() constructor will happily return a long in some cases. And, it seems gdb already understands this in other places -- this is what gdb_py_object_from_longest handles. So, this patch simply extends valpy_int to allow pointer conversions, as valpy_long does. gdb/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/18170: * python/py-value.c (valpy_int): Allow conversion from pointer type. gdb/testsuite/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/18170: * gdb.python/py-value.exp (test_value_numeric_ops): Add tests to convert pointers to int and long.
2018-09-23Preserve sign when converting gdb.Value to Python intTom Tromey4-1/+23
PR python/20126 points out that sometimes the conversion of a gdb.Value can result in a negative Python integer. This happens because valpy_int does not examine the signedness of the value's type. gdb/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/20126: * python/py-value.c (valpy_int): Respect type sign. gdb/testsuite/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/20126: * gdb.python/py-value.exp (test_value_numeric_ops): Add signed-ness conversion tests.
2018-09-23Allow more Python scalar conversionsTom Tromey4-3/+48
PR python/18352 points out that the gdb Python code can't convert an integer-valued gdb.Value to a Python float. While writing the test I noticed that, similarly, converting integer gdb.Values to float does not work. However, all of these cases seem reasonable. gdb/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/18352; * python/py-value.c (valpy_float): Allow conversions from int or char. (valpy_int, valpy_long): Allow conversions from float. gdb/testsuite/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> PR python/18352; * gdb.python/py-value.exp (test_float_conversion): New proc. Use it.
2018-09-24Automatic date update in version.inGDB Administrator1-1/+1
2018-09-23Fix incorrect extraction of signed constants in nios2 disassembler.Sandra Loosemore2-13/+21
2018-09-23 Sandra Loosemore <sandra@codesourcery.com> opcodes/ * nios2-dis.c (nios2_print_insn_arg): Make sure signed conversions are used when extracting signed fields and converting them to potentially 64-bit types.
2018-09-23Mark more file descriptors close-on-execTom Tromey3-3/+12
I noticed a couple of spots in gdb that were opening files but not marking the file descriptors as close-on-exec. This patch fixes these. There are still a few more of these, but they are in code that I can't compile, so I'd prefer not to touch. gdb/ChangeLog 2018-09-23 Tom Tromey <tom@tromey.com> * ctf.c (ctf_start): Use gdb_fopen_cloexec. * common/scoped_mmap.c (mmap_file): Use gdb_open_cloexec.
2018-09-23Also recognize __sighndlr on Solaris/x86Rainer Orth3-2/+10
Unlike Solaris/SPARC, the __sighndlr function isn't recognized as part of a signal handler, causing a couple of testcases to fail. The following patch fixes that. A followup patch will move this to common code to avoid such unnecessary discrepancies between Solaris/SPARC and x86 in the future. While this fixes a couple of backtraces to now correctly print #1 <signal handler called> they often fail later with #2 0x0ff3ffffff00857f in ?? () Backtrace stopped: Cannot access memory at address 0xff3000002e0886f which needs further investigation. Tested on amd64-pc-solaris2.11 (running the tests with both -m64 and -m32). * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Also recognize __sighndlr. * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Likewise.
2018-09-23Remove a spurious target_terminal::ours() from windows_nat_target::wait()Jon Turney2-2/+5
This causes the inferior to stop with SIGTTIN if it tries to read from the terminal after it has been continued. See https://cygwin.com/ml/cygwin/2016-09/msg00285.html for reproduction. Since MinGW doesn't have a tcsetpgrp(), I don't think this problem would be observed there, but Cygwin does so target_terminal::ours() will call it. Calling target_terminal::ours() here seems to be is no longer appropriate after the "Merge async and sync code paths" changes (as the inferior is now in a separate process group even in sync mode(?), which is always used on Windows targets) This call was added in commit c44537cf (and see https://sourceware.org/ml/gdb-patches/2007-02/msg00167.html for what it fixed, which is not regressed by this change) When windows_nat_target::wait() is entered, the inferior is running (either it's been just been started or attached to, or windows_continue() was called), so grabbing the controlling terminal away from it here seems to be wrong, since infrun.c takes care of calling target_terminal::ours() when the inferior stops. gdb/ChangeLog: 2018-08-02 Jon Turney <jon.turney@dronecode.org.uk> * windows-nat.c (windows_nat_target::wait): Remove a spurious target_terminal::ours().
2018-09-23Fix build error in aarch64-linux-tdep.c on macOSSimon Marchi2-1/+6
When building with --enable-targets=all on macOS, I get this error: CXX aarch64-linux-tdep.o /Users/simark/src/binutils-gdb/gdb/aarch64-linux-tdep.c:328:7: error: no matching function for call to 'store_integer' store_integer ((gdb_byte *)&vg_target, sizeof (uint64_t), byte_order, ^~~~~~~~~~~~~ /Users/simark/src/binutils-gdb/gdb/defs.h:556:13: note: candidate template ignored: requirement 'Or<is_same<unsigned long long, long>, is_same<unsigned long long, unsigned long> >::value' was not satisfied [with T = unsigned long long] extern void store_integer (gdb_byte *addr, int len, enum bfd_endian byte_order, ^ I believe it's because uint64_t is defined as "unsigned long long" on macOS, even though "unsigned long" is also 64 bits. Other 64-bits platforms define uint64_t as "unsigned long". This makes the type of the argument to store_integer (unsigned long long) not match the requirement that it must be the same as ULONGEST, which is unsigned long. Fix it by changing the type of the vl variable to be ULONGEST, which is what extract_unsigned_integer returns anyway. gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_linux_supply_sve_regset): Change type of vl to ULONGEST.
2018-09-23Automatic date update in version.inGDB Administrator1-1/+1
2018-09-22Automatic date update in version.inGDB Administrator1-1/+1
2018-09-22Revert part of commit 32ec8896025Alan Modra2-6/+5
echo "__thread char *p;" | gcc -c -g -xc - -o thread.o With current powerpc64le-linux-gcc has this reloc in .debug_info 0000000000000025 0000000d0000004e R_PPC64_DTPREL64 0000000000000000 p + 8000 That stops me looking at .debug_info. ~/build/gas-virgin/powerpc64le-linux/binutils/readelf -wi thread.o readelf: Warning: unable to apply unsupported reloc type 78 to section .debug_info Older readelf continued on after the warning, dumping .debug_info. * readelf.c (apply_relocations): Don't return FALSE for warnings.
2018-09-21csky-opc.h: Initialize fields of last array elementsSimon Marchi7-68/+14
clang gives these errors: In file included from /Users/simark/src/binutils-gdb/opcodes/csky-dis.c:30: /Users/simark/src/binutils-gdb/opcodes/csky-opc.h:2330:8: error: missing field 'transfer' initializer [-Werror,-Wmissing-field-initializers] {NULL} ^ /Users/simark/src/binutils-gdb/opcodes/csky-opc.h:8126:10: error: missing field 'transfer' initializer [-Werror,-Wmissing-field-initializers] {NULL} ^ They go away when we Initialize all fields. I noticed there used to be some files built with -Wno-missing-field-initializers, but it's not the case anymore, since commit e7ae278d0474ab84ba3b1ee932a19e83616ddacc. There is still a NO_WMISSING_FIELD_INITIALIZERS variable defined in the Makefile, but it's unused, so I removed it to avoid further confusion. opcodes/ChangeLog: * Makefile.am: Remove NO_WMISSING_FIELD_INITIALIZERS. * Makefile.in: Re-generate. * aclocal.m4: Re-generate. * configure: Re-generate. * configure.ac: Remove check for -Wno-missing-field-initializers. * csky-opc.h (csky_v1_opcodes): Initialize all fields of last element. (csky_v2_opcodes): Likewise.
2018-09-21elf32-nds32: Don't define fls if it is provided by the systemSimon Marchi5-2/+14
The fls function already exists on macOS and FreeBSD (and probably others), leading to this error: /Users/simark/src/binutils-gdb/bfd/elf32-nds32.c:5074:1: error: static declaration of 'fls' follows non-static declaration fls (register unsigned int x) ^ /usr/include/strings.h:87:6: note: previous declaration is here int fls(int) __OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0); ^ Add a configure-time check for it, and only define it if the system doesn't provide it. bfd/ChangeLog: * configure.ac: Check for fls. * elf32-nds32.c (fls): Only define if !HAVE_FLS. * config.in: Re-generate. * configure: Re-generate.
2018-09-21Remove redundant test in update_inserted_breakpoint_locationsYacov Simhony2-1/+6
Remove a redundant test in update_inserted_breakpoint_locations. gdb/ChangeLog 2018-09-21 Yacov Simhony <ysimhony@gmail.com> * breakpoint.c (update_inserted_breakpoint_locations): Remove redundant condition.
2018-09-21Correct ChangeLog entry for commit b8426d169d3f8aH.J. Lu1-1/+1
commit b8426d169d3f8ab820f3bdaf45fbc64f8bb827ed Author: H.J. Lu <hjl.tools@gmail.com> Date: Fri Sep 21 04:24:40 2018 -0700 gas: Make bfin-parse.c/rl78-parse.c/rx-parse.c depend on bfd/reloc.c It is for PR gas/23691, not PR gas/23692.
2018-09-21gas: Make bfin-parse.c/rl78-parse.c/rx-parse.c depend on bfd/reloc.cH.J. Lu3-6/+14
Since bfin-parse.c, rl78-parse.c and rx-parse.c use BFD_RELOC_XXX, we need to regenerate them when bfd/reloc.c changhes. PR gas/23692 * Makefile.am (bfin-parse.c): Depend on $(srcdir)/../bfd/reloc.c. (rl78-parse.c): Likewise. (rx-parse.c): Likewise. * Makefile.in: Regenerated.
2018-09-21ELF: Don't include zero size sections at start of PT_NOTE segmentH.J. Lu2-4/+12
We shouldn't include zero size sections at start of PT_NOTE segment, similar to PT_DYNAMIC segment. PR binutils/23694 * include/elf/internal.h (ELF_SECTION_IN_SEGMENT_1): Don't include zero size sections at start of PT_NOTE segment.
2018-09-21Fix more fallout from 17f6ade235fcAlan Modra4-60/+42
gas/ * testsuite/gas/avr/large-debug-line-table.d: Update. ld/ * testsuite/ld-avr/gc-section-debugline.d: Update.
2018-09-21Automatic date update in version.inGDB Administrator1-1/+1
2018-09-20ld: Add the entry symbol, _main, for LynxOS targetsH.J. Lu17-0/+55
Add the entry symbol, _main, to fix: FAIL: ld-elf/64ksec FAIL: ld-elf/comm-data4 FAIL: ld-elf/comm-data5 FAIL: ld-elf/eh5 FAIL: ld-elf/empty FAIL: ld-elf/empty2 FAIL: ld-elf/endsym FAIL: ld-elf/exclude3a FAIL: ld-elf/linkonce2 FAIL: ld-elf/orphan3 FAIL: ld-elf/pr12851 FAIL: ld-elf/pr14156a FAIL: ld-elf/pr14156b FAIL: ld-elf/pr14926 FAIL: ld-elf/pr20513a FAIL: ld-elf/pr20513b FAIL: ld-elf/stab FAIL: ld-elf/var1 FAIL: ld-elf/warn3 FAIL: section size overflow for i386-lynxos target. * testsuite/ld-checks/over2.s: Add "_main" for LynxOS targets. * testsuite/ld-elf/comm-data4.s: Likewise. * testsuite/ld-elf/comm-data5.s: Likewise. * testsuite/ld-elf/eh5b.s: Likewise. * testsuite/ld-elf/empty.s: Likewise. * testsuite/ld-elf/empty2.s: Likewise. * testsuite/ld-elf/exclude3.s: Likewise. * testsuite/ld-elf/fini0.s: Likewise. * testsuite/ld-elf/init0.s: Likewise. * testsuite/ld-elf/linkonce1b.s: Likewise. * testsuite/ld-elf/orphan3a.s: Likewise. * testsuite/ld-elf/pr14926.s: Likewise. * testsuite/ld-elf/pr20513a.s: Likewise. * testsuite/ld-elf/sec64k.exp: Likewise. * testsuite/ld-elf/start.s: Likewise. * testsuite/ld-elf/var1.s: Likewise.
2018-09-20RISC-V: Fix library search path for rv32.Jim Wilson4-3/+9
2018-09-19 Kito Cheng <kito@andestech.com> ld/ * emulparams/elf32lriscv.sh: Correct the library search path. * emulparams/elf32lriscv_ilp32.sh: Likewise. * emulparams/elf32lriscv_ilp32f.sh: Likewise.
2018-09-20More Solaris procfs cleanupRainer Orth5-149/+166
This procfs.c (and friends) cleanup patch grew along a couple of lines: * First I noticed that PR_MODEL_NATIVE is always defined now that Solaris 10 is the minimum supported version. * Then there was a cleanup that I'd missed when removing support for !NEW_PROC_API, IRIX, and Tru64 UNIX: given that sysset_t is no longer dynamic, there's no need for the special sysset_t_alloc, but we can just use XNEW instead. * Then I found one of those ARI warning mails on gdb-patches, discovered how to run it myself and fixed a large number of the warnings, among them all uses of sprintf. I had to silence the warnings in only 3 instances of the same issue, namely references to LDT in function names which are due to the libthread_db API. * Even so, there were several formatting glitches, like braces around single statements in an if, which I chose to fix while I was at it. The result has been tested on amd64-pc-solaris2.11 and amd64-pc-solaris2.11. * proc-utils.h (PROC_CTL_WORD_TYPE): Remove. * procfs.c: Don't check for PR_MODEL_NATIVE definition. * sparc-sol2-nat.c: Likewise. Remove Linux, __arch64__ references. * sol-thread.c (ps_pdmodel): Don't guard definition. * procfs.c: Fix formatting. * procfs.c (sysset_t_alloc): Remove. (create_procinfo): Use XNEW instead of sysset_t_alloc. (procfs_debug_inferior): Likewise. (procfs_set_exec_trap): Likewise. (proc_set_traced_sysentry): Don't allocate argp dynamically. (proc_set_traced_sysexit): Likewise. * procfs.c (create_procinfo): Use xsnprintf to fix ARI warning. (dead_procinfo): Likewise. (proc_warn): Likewise. (proc_error): Likewise. (proc_get_LDT_entry): Likewise. (do_attach): Likewise. (procfs_target::pid_to_str): Likewise. (iterate_over_mappings): Likewise. * procfs.c (create_procinfo): Fix ARI warning. (proc_get_status): Likewise. (proc_stop_process): Likewise. (proc_run_process): Likewise. (proc_kill): Likewise. (proc_get_LDT_entry): Likewise. (procfs_find_LDT_entry): Likewise. (proc_update_threads): Likewise. (proc_iterate_over_threads): Likewise. (do_attach): Likewise. (procfs_xfer_memory): Likewise. (invalidate_cache): Likewise. (procfs_target::resume): Likewise. (procfs_init_inferior): Likewise. (procfs_set_exec_trap): Likewise. (procfs_target::thread_alive): Likewise. (procfs_target::pid_to_exec_file): Likewise. (iterate_over_mappings): Likewise. (procfs_target::make_corefile_notes): Likewise. * sol-thread.c (sol_thread_target::thread_alive): Likewise. * procfs.c (procfs_find_LDT_entry): Silence ARI warning. (procfs_find_LDT_entry): Likewise. * sol-thread.c (ps_lgetLDT): Likewise.
2018-09-20gas: Update expected outputs of "readelf -wL"H.J. Lu12-70/+86
Update expected outputs of "readelf -wL" for commit 17f6ade235fc96b4e572b5251b344d426c5f1cd5 Author: John Darrington <john@darrington.wattle.id.au> Date: Wed Sep 19 19:56:29 2018 +0200 binutils --dwarf=decodedline: Add display of is_stmt flag which adds display of is_stmt flag. PR binutils/23695 * testsuite/gas/elf/dwarf2-11.d: Update expected outputs of "readelf -wL". * testsuite/gas/elf/dwarf2-12.d: Likewise. * testsuite/gas/elf/dwarf2-13.d: Likewise. * testsuite/gas/elf/dwarf2-14.d: Likewise. * testsuite/gas/elf/dwarf2-15.d: Likewise. * testsuite/gas/elf/dwarf2-16.d: Likewise. * testsuite/gas/elf/dwarf2-17.d: Likewise. * testsuite/gas/elf/dwarf2-18.d: Likewise. * testsuite/gas/elf/dwarf2-5.d: Likewise. * testsuite/gas/elf/dwarf2-6.d: Likewise. * testsuite/gas/elf/dwarf2-7.d: Likewise.
2018-09-20binutils --dwarf=decodedline: Add display of is_stmt flagJohn Darrington3-11/+16
binutils/ * dwarf.c (display_debug_lines_decoded): Add display of is_stmt. * testsuite/binutils-all/dw5.W: Deal with the consequences. * testsuite/binutils-all/objdump.WL: Deal with the consequences.
2018-09-20Add '_' in the match pattern.Hafiz Abid Qadeer2-1/+5
I was looking at GDB testcase results for arm-eabi target with qemu and noticed that register groups returned by the qemu can have '_' in the name e.g. 'cp_regs'. The reggroups.exp fails to recognize that as group name. Fixed by adding '_' in the pattern. 2018-09-20 Hafiz Abid Qadeer <abidh@codesourcery.com> gdb.base/reggroups.exp (fetch_reggroups): Add '_' in match pattern.
2018-09-20S12Z/GAS: Correct a signed vs unsigned comparison error with GCC 4.1Maciej W. Rozycki2-11/+18
Fix a build error: cc1: warnings being treated as errors .../gas/config/tc-s12z.c: In function 'lex_opr': .../gas/config/tc-s12z.c:617: warning: comparison between signed and unsigned .../gas/config/tc-s12z.c:624: warning: comparison between signed and unsigned make[4]: *** [config/tc-s12z.o] Error 1 observed with GCC 4.1.2 with the `s12z-elf' target. Here we have a constant assembly instruction operand, whose value is within the 24-bit unsigned range, to be placed in a machine instruction such as to use the least space-consuming encoding. So the sign of that value does not matter, because signed values are out of range and are not supposed to appear here, and we only have this warning here because the `X_add_number' member of `struct expressionS' is of the `offsetT' type, which is signed. Use an auxiliary variable of an unsigned data type then, observing that both `offsetT' and `valueT' have the same width, as they correspond to `bfd_signed_vma' and `bfd_vma' respectively. gas/ * config/tc-s12z.c (lex_opr): Use an auxiliary unsigned variable in encoding a constant operand.
2018-09-20PPC/GAS: Correct a signed vs unsigned comparison error with GCC 4.1Maciej W. Rozycki2-1/+6
Fix a build error: cc1: warnings being treated as errors .../gas/config/tc-ppc.c: In function 'ppc_dwsect': .../gas/config/tc-ppc.c:4091: warning: comparison between signed and unsigned make[4]: *** [config/tc-ppc.o] Error 1 observed with GCC 4.1.2 with the `powerpc-beos' target. Here `flag' identifies the type of a DWARF section, as used with the the first operand to the `.dwsect' pseudo-op, and has no notion of a sign, or for that matter being arithmetic in the first place[1]. We already handle this correctly with the `flag' member of the `xcoff_dwsect_name' structure, however not in the local variable used in GAS to hold the parsed value of said `.dwsect' pseudo-op's operand. Use an unsigned data type in GAS then too, observing that both `offsetT' and `valueT' have the same width, as they correspond to `bfd_signed_vma' and `bfd_vma' respectively. References: [1] "AIX Version 7.2: Assembler Language Reference", IBM Corporation 2015, 2018, Section ".dwsect pseudo-op", pp. 531-532 gas/ * config/tc-ppc.c (ppc_dwsect): Use `valueT' rather than `offsetT' as the type of `flag'.