aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-01-22With some changes to how software single-step (SSS) breakpoints arePedro Alves4-2/+55
handled, one of those being to place SSS breakpoints on the breakpoint chain as all other breakpoints, annota1.exp times out with lots and lots of breakpoint-invalid and frame-changed annotations. All those extra annotations are actually unnecessary. For one, SSS breakpoints are internal breakpoints, so the frontend shouldn't care if they were added, removed or changed. Then, there's really no point in emitting "breakpoints-invalid" or "frames-invalid" more than once between times the frontend/user can actually issues GDB commands; the frontend will have to wait for the GDB prompt to refresh its state, so emitting those annotations at most once between prompts is enough. Non-stop or async would complicate this, but no frontend will be using annotations in those modes (one of goes of emacs switching to MI was non-stop mode support, AFAIK). The previous patch reveals there has been an intention in the past to suppress multiple breakpoints-invalid annotations caused by ignore count changes. As the previous patch shows, that's always been broken, but in any case, this patch actually makes it work. The next patch will remove several annotation-specific calls in breakpoint.c in favor of always using the breakpoint modified & friends observers, and that causes yet more of these annotations, because several calls to the corresponding annotate_* functions in breakpoint.c are missing, particularly in newer code. So all in all, here's a simple mechanism that avoids sending the same annotation to the frontend more than once until gdb is ready to accept further commands. Tested on x86_64 Fedora 17. 2013-01-22 Pedro Alves <palves@redhat.com> * annotate.c: Include "inferior.h". (frames_invalid_emitted) (breakpoints_invalid_emitted): New globals. (async_background_execution_p): New function. (annotate_breakpoints_changed, annotate_frames_invalid): Skip emitting the annotation if it has already been emitted. (annotate_display_prompt): New function. * annotate.h (annotate_display_prompt): New declaration. * event-top.c: Include annotate.h. (display_gdb_prompt): Call annotate_display_prompt.
2013-01-22There's code in annotate.c and breakpoint.c that is supposed toPedro Alves6-25/+20
suppress multiple breakpoints-invalid annotations when the ignore count of a breakpoint changes, up until the target actually stops. But, the code is bogus: void annotate_breakpoints_changed (void) { if (annotation_level == 2) { target_terminal_ours (); printf_unfiltered (("\n\032\032breakpoints-invalid\n")); if (ignore_count_changed) ignore_count_changed = 0; /* Avoid multiple break annotations. */ } } The "ignore_count_changed" flag isn't actually guarding the output of the annotation at all. It would have been better written something like: void annotate_breakpoints_changed (void) { if (annotation_level == 2 && !ignore_count_changed) { target_terminal_ours (); printf_unfiltered (("\n\032\032breakpoints-invalid\n")); ignore_count_changed = 0; /* Avoid multiple break annotations. */ } } but, it wasn't. AFAICS, that goes all the way back to the original patch'es submission and check in, at <http://sourceware.org/ml/gdb-patches/1999-q4/msg00106.html>. I looked a tar of HP's wdb from 1999, and even though that contains local changes in the annotate code, this suppression seems borked there too to me. The original patch added a test to supposedly exercise this suppression, but, it actually doesn't. It merely tests that "breakpoints-invalid" is output after "stopped", but doesn't check whether the duplicates supression actually works (IOW, check that only _one_ annotation is seen). I was going to simply delete the tests too, but a following patch will eliminate the duplicates in a different way (which I needed for a different reason), so instead, I'm making the tests actually fail if a duplicate annotation is seen. Worry not, the test doesn't actually fail! The reason is that breakpoint.c does: else if (b->ignore_count > 0) { b->ignore_count--; annotate_ignore_count_change (); bs->stop = 0; /* Increase the hit count even though we don't stop. */ ++(b->hit_count); observer_notify_breakpoint_modified (b); } where the annotate_ignore_count_change call is meant to inform the "breakpoint_modified" annotation observer to ignore the notification. All sounds good. But, the trouble is that nowadays annotate.c only installs the observers if GDB is started with annotations enabled with a command line option (gdb --annotate=2): void _initialize_annotate (void) { if (annotation_level == 2) { observer_attach_breakpoint_deleted (breakpoint_changed); observer_attach_breakpoint_modified (breakpoint_changed); } } and annota1.exp, to enable annotations, starts GDB normally, and afterwards does "set annotate 2", so the observers aren't installed when annota1.exp is run, and therefore changing the ignore count isn't triggering any annotation at all... gdb/ 2013-01-22 Pedro Alves <palves@redhat.com> * annotate.c (ignore_count_changed): Delete. (annotate_breakpoints_changed): Don't clear ignore_count_changed. (annotate_ignore_count_change): Delete. (annotate_stopped): Don't emit a delayed breakpoints-changed annotation. * annotate.h (annotate_ignore_count_change): Delete. * breakpoint.c (bpstat_check_breakpoint_conditions): Don't call annotate_ignore_count_change. gdb/testsuite/ 2013-01-22 Pedro Alves <palves@redhat.com> * gdb.base/annota1.exp (annotate ignore count change): Add expected output for failure case.
2013-01-22 * dwarf2loc.c (dwarf2_compile_expr_to_ax) <DW_OP_fbreg>: OnlyTom Tromey2-1/+7
require_rvalue for a register location.
2013-01-22 * gdb.gdb/selftest.exp (do_steps_and_nexts): Handle bfd_initTom Tromey2-0/+9
call.
2013-01-22Updated Changelog and testsuite/Changelog because of bad formatting.Marc Khouzam2-10/+11
2013-01-22*** empty log message ***gdbadmin1-1/+1
2013-01-212013-01-21 Marc Khouzam <marc.khouzam@ericsson.com>Marc Khouzam11-62/+136
* breakpoint.c (print_one_breakpoint_location): Add MI field 'thread-groups' when printing a breakpoint. (output_thread_groups): New function. 2013-01-21 Marc Khouzam <marc.khouzam@ericsson.com> * gdb.texinfo (GDB/MI Breakpoint Commands): Document new 'thread-groups' field when printing a breakpoint in MI. 2013-01-21 Marc Khouzam <marc.khouzam@ericsson.com> * gdb.mi/mi-break.exp: Expect new 'thread-groups' field. * gdb.mi/mi-nsmoribund.exp: Expect new 'thread-groups' field. Also handle 'thread' field. * gdb.mi/mi-simplerun.exp: Expect new 'thread-groups' field. * gdb.mi/mi-watch.exp: Ditto. * lib/mi-support.exp: Ditto.
2013-01-21daily updateAlan Modra1-1/+1
2013-01-21 * python/lib/gdb/commands/explore.pySiva Chandra Reddy4-6/+28
(CompoundExplorer.explore_expr): Correct the name of a method being invoked. (ExploreTypeCommand.invoke): Add a missing 'return'. * testsuite/gdb.python/py-explore.exp: Improve a test
2013-01-21 * gdb_obstack.h (obconcat): Move declaration here, from...Tom Tromey6-35/+68
* symfile.h (obconcat): ... here. * gdb_obstack.c: New file. (obconcat): Move from... * symfile.c (obconcat): ... here. * Makefile.in (SFILES): Add gdb_obstack.c. (COMMON_OBS): Add gdb_obstack.o.
2013-01-21 * symfile.h (obsavestring): Don't declare.Tom Tromey14-96/+81
* symfile.c (obsavestring): Remove. * ada-exp.y: Use obstack_copy0, not obsavestring. * ada-lang.c: Use obstack_copy0, not obsavestring. * coffread.c: Use obstack_copy0, not obsavestring. * cp-namespace.c: Use obstack_copy0, not obsavestring. * dbxread.c: Use obstack_copy0, not obsavestring. * dwarf2read.c: Use obstack_copy0, not obsavestring. * jit.c: Use obstack_copy0, not obsavestring. * mdebugread.c: Use obstack_copy0, not obsavestring. * psymtab.c: Use obstack_copy0, not obsavestring. * stabsread.c: Use obstack_copy0, not obsavestring. * xcoffread.c: Use obstack_copy0, not obsavestring.
2013-01-21 * dwarf2read.c (fixup_go_packaging): Save package nameTom Tromey3-9/+16
on objfile obstack. * gdbtypes.c (init_type): Don't copy name.
2013-01-21 * dwarf2read.c (struct partial_die_info) <name, scope>: NowTom Tromey2-65/+88
const. (struct attribute) <u.str>: Now const. (struct fnfieldlist) <name>: Now const. (dw2_get_file_names_reader, init_cutu_and_read_dies): Update. (partial_die_parent_scope): Make return type const. (partial_die_full_name, add_partial_symbol): Update. (dwarf2_compute_name, dwarf2_full_name, dwarf2_physname): Make 'name' const. (find_file_and_directory): Make 'name' and 'comp_dir' const. (read_file_scope, read_func_scope, dwarf2_add_field) (dwarf2_add_member_fn, read_structure_type) (process_enumeration_scope, read_array_type, read_module_type) (read_base_type, read_subrange_type): Update. (dwarf2_start_symtab): Make 'name' and 'comp_dir' const. (new_symbol_full, guess_full_die_structure_name): Update. (dwarf2_canonicalize_name): Return const type. Make 'name' const. (dwarf2_name): Return const type. (dwarf_decode_macro_bytes, dwarf_decode_macros): Make 'comp_dir' const.
2013-01-21 * gdbtypes.c (init_type): Make 'name' const.Tom Tromey3-2/+7
* gdbtypes.h (init_type): Update.
2013-01-21 * buildsym.c (patch_subfile_names): Use set_last_source_file.Tom Tromey7-34/+87
(start_symtab): Make 'name' and 'dirname' const. Use set_last_source_file. (restart_symtab, reset_symtab_globals): Use set_last_source_file. (last_source_file): Define. Now static. (set_last_source_file, get_last_source_file): New functions. * buildsym.h (last_source_file): Don't declare. (start_symtab): Update. (set_last_source_file, get_last_source_file): Declare. * coffread.c (complete_symtab): Use set_last_source_file. (coff_end_symtab): Likewise. (coff_symtab_read): Use set_last_source_file, get_last_source_file. * dbxread.c (read_dbx_symtab, read_ofile_symtab): Use set_last_source_file. (process_one_symbol): Use get_last_source_file. * mdebugread.c (parse_partial_symbols): Use set_last_source_file. (psymtab_to_symtab_1): Use get_last_source_file. * xcoffread.c (process_linenos): Use get_last_source_file. (complete_symtab): Use set_last_source_file. (read_xcoff_symtab): Use set_last_source_file, get_last_source_file. (scan_xcoff_symtab): Use set_last_source_file.
2013-01-21 * symtab.c (struct demangled_name_entry) <mangled>: Now const.Tom Tromey2-5/+13
(symbol_set_names): Remove casts. Handle field const-ness.
2013-01-21 * dwarf2read.c (new_symbol_full): Remove cast.Tom Tromey4-3/+10
* symtab.c (symbol_set_demangled_name): Make 'name' const. * symtab.h (symbol_set_demangled_name): Update.
2013-01-21 * main.c (captured_main): Call bfd_init.Tom Tromey2-0/+6
2013-01-21 * gnu-v2-abi.c (_initialize_gnu_v2_abi): Don't set default ABI.Tom Tromey5-24/+11
* gnu-v3-abi.c (_initialize_gnu_v3_abi): Set default ABI. * minsyms.c (install_minimal_symbols): Don't check for _Z symbols. * NEWS: Update.
2013-01-21gdb/Jan Kratochvil2-0/+5
* symmisc.c (maintenance_print_msymbols): Check also ST_DEV.
2013-01-21gdb/Jan Kratochvil4-4/+21
Fix gdb.fortran/common-block.exp crash in PIE mode. * dwarf2read.c (new_symbol_full) <DW_TAG_common_block>: Use LOC_COMMON_BLOCK. * f-valprint.c (info_common_command_for_block): Expect LOC_COMMON_BLOCK in gdb_assert. * symtab.h (struct general_symbol_info): Update comment for the common_block member. (domain_enum): Extend comment for the COMMON_BLOCK_DOMAIN member. (enum address_class): New member LOC_COMMON_BLOCK.
2013-01-21ld: enable new dtags by default for linux/gnu targetsMike Frysinger3-0/+18
The "new" dtags options have been around for 14+ years now, so for Linux and GNU targets, enable them by default. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2013-01-21 * ld-size/size.exp (build_tests <size-7, size-8>): PassAlan Modra2-2/+7
--no-as-needed in cflags.
2013-01-21*** empty log message ***gdbadmin1-1/+1
2013-01-20daily updateAlan Modra1-1/+1
2013-01-20*** empty log message ***gdbadmin1-1/+1
2013-01-19daily updateAlan Modra1-1/+1
2013-01-19Add HOSTING_SCRT0 for PIE testH.J. Lu9-5/+39
ld/ * Makefile.am (HOSTING_SCRT0): New. * configure.host (HOSTING_SCRT0): New. Used for PIE. * configure.in (HOSTING_SCRT0): New AC_SUBST. * Makefile.in: Regenerated. * configure: Likewise. ld/testsuite/ * config/default.exp (get_target_emul): Also set HOSTING_SCRT0. * lib/ld-lib.exp (default_ld_link): Use HOSTING_SCRT0 for -pie.
2013-01-19*** empty log message ***gdbadmin1-1/+1
2013-01-18daily updateAlan Modra1-1/+1
2013-01-18Resolve size relocation against non-zero TLS symbolH.J. Lu11-41/+102
bfd/ * elf32-i386.c (elf_i386_allocate_dynrelocs): Clear pc_count for non-zero TLS symbol. (elf_i386_relocate_section): Resolve size relocation against non-zero TLS symbol. * elf64-x86-64.c (elf_x86_64_allocate_dynrelocs): Clear pc_count for non-zero TLS symbol. (elf_x86_64_relocate_section): Resolve size relocation against non-zero TLS symbol. ld/testsuite/ * ld-size/size-10.rd: Updated. * ld-size/size-8.rd: Likewise. * ld-size/size32-2-i386.d: Likewise. * ld-size/size32-2-x32.d: Likewise. * ld-size/size32-2-x86-64.d: Likewise. * ld-size/size64-2-x32.d: Likewise. * ld-size/size64-2-x86-64.d: Likewise.
2013-01-18gdbDavid Blaikie1-2/+3
* ChangeLog: Fix errors in my previous commit: whitespace->tabs, date, and trailing blank line. (from review by Sergio Durigan Junior)
2013-01-18gdbDavid Blaikie2-0/+4
* MAINTAINERS (Write After Approval): Add "David Blaikie".
2013-01-18gdb/testsuiteDavid Blaikie2-1/+6
* gdb.base/label.c (main): Correct the type of the second parameter.
2013-01-18 PR c++/14999:Tom Tromey5-0/+348
* dwarf2loc.c (dwarf2_compile_expr_to_ax) <DW_OP_fbreg>: Call require_rvalue. gdb/testsuite * gdb.dwarf2/trace-crash.s: New file. * gdb.dwarf2/trace-crash.exp: New file.
2013-01-18gold: enable new dtags by defaultMike Frysinger2-1/+5
The "new" dtags options have been around for 14+ years, and for all the targets that gold supports, these flags have always existed. So enable them by default. Having behavior be different from ld.bfd isn't new, and this behavior is the "better" one, so there shouldn't be a problem based on that. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2013-01-18ld: change --enable-new-dtags to only generate new dtagsMike Frysinger7-11/+29
The "new" dtags options have been around for 14+ years, so there shouldn't be a need to generate both new & old tags anymore. Signed-off-by: Mike Frysinger <vapier@gentoo.org>
2013-01-18Support size relocation only for ELFH.J. Lu2-0/+13
* config/tc-i386.c (reloc): Support size relocation only for ELF. (tc_i386_fix_adjustable): Likewise. (lex_got): Likewise. (tc_gen_reloc): Likewise.
2013-01-18 PR binutils/15026Nick Clifton2-1/+12
* addr2line.c (translate_addresses): When pretty printing, print unknown function names on the same line as unknown symbol names.
2013-01-182013-01-18 Hafiz Abid Qadeer<abidh@codesourcery.com>Hafiz Abid Qadeer2-9/+15
PR gdb/13443 * gdb.base/checkpoint.exp: Update test messages to make them unique.
2013-01-18gdb/gdbserver:Yao Qi11-69/+171
* ax.h (struct eval_agent_expr_context): New. (gdb_eval_agent_expr): Update declaration. * ax.c (gdb_eval_agent_expr): Remove argument REGCACHE and TFRAME. Add new argument CTX. * server.h (struct eval_agent_expr_context): Declare. (agent_mem_read, agent_tsv_read): Update declaration. (agent_mem_read_string): Likewise. * tracepoint.c (eval_tracepoint_agent_expr): Remove. (add_traceframe_block): Add new argument TPOINT. Increase TPOINT->traceframe_usage. (do_action_at_tracepoint): Call gdb_eval_agent_expr instead of eval_tracepoint_agent_expr. (condition_true_at_tracepoint): Likewise. (agent_mem_read): Remove argument TFRAME. Add argument CTX. (agent_mem_read_string, agent_tsv_read): Likewise. Callers update. gdb/testsuite: * gdb.trace/infotrace.exp: Check 'traceframe usage' in the output of 'info tracepoints'. * gdb.trace/disconnected-tracing.exp (disconnected_tracing): Likewise. * gdb.trace/tstatus.exp (run_trace_experiment): Likewise. * gdb.trace/disconnected-tracing.c (struct foo): New.
2013-01-18gdb/Yao Qi7-37/+65
* dbxread.c (dbx_psymtab_to_symtab): Delete the declaration. (dbx_read_symtab): New declaration. (dbx_psymtab_to_symtab): Delete. (dbx_read_symtab): Rename from dbx_psymtab_to_symtab. Rename parameter PST to SELF. Exchanged two parameters. (start_psymtab): Caller update. * dwarf2read.c (dwarf2_psymtab_to_symtab): Delete the declaration. (dwarf2_read_symtab): New declaration. (dwarf2_psymtab_to_symtab): Delete. (dwarf2_read_symtab): Rename from dwarf2_psymtab_to_symtab. Rename parameter PST to SELF. Exchanged two parameters. (create_partial_symtab): Caller update. * mdebugread.c (mdebug_psymtab_to_symtab): Delete. (mdebug_read_symtab): Rename from mdebug_psymtab_to_symtab. Rename parameter PST to SELF. Exchanged two parameters. (parse_partial_symbols, new_psymtab): Caller update. * psympriv.h (struct partial_symtab) <read_symtab>: Exchange two parameters. * psymtab.c (psymtab_to_symtab): Caller update. * xcoffread.c (xcoff_psymtab_to_symtab): Delete. (xcoff_read_symtab): Rename from xcoff_psymtab_to_symtab. Rename parameter PST to SELF. Exchanged two parameters. (xcoff_start_psymtab): Caller update.
2013-01-18gdb/Yao Qi2-6/+13
* infrun.c (proceed): Rename local variable 'oneproc' to 'force_step'.
2013-01-18Verify run-time size relocations if supportedH.J. Lu12-0/+103
* ld-size/size-7.out: New file. * ld-size/size-8.out: Likewise. * ld-size/size-9.out: Likewise. * ld-size/size-9.rd: Likewise. * ld-size/size-9a.c: Likewise. * ld-size/size-9b.c: Likewise. * ld-size/size-10.out: Likewise. * ld-size/size-10.rd: Likewise. * ld-size/size-10a.c: Likewise. * ld-size/size-10b.c: Likewise. * ld-size/size.exp (build_tests): Build libsize-9.so and libsize-10.so. Run-time size relocation tests if supported. (run_time_tests): New.
2013-01-18Add size-1 and size-2 testsH.J. Lu10-0/+70
* ld-size/size-1.c: New file. * ld-size/size-1.out: Likewise. * ld-size/size-1a.c: Likewise. * ld-size/size-1b.c: Likewise. * ld-size/size-2.c: Likewise. * ld-size/size-2.out: Likewise. * ld-size/size-2a.c: Likewise. * ld-size/size-2b.c: Likewise. * ld-size/size.exp (build_tests): Build libsize-1.so and libsize-2.so. (run_tests): Run size-1 and size-2.
2013-01-18*** empty log message ***gdbadmin1-1/+1
2013-01-17Add missing filesH.J. Lu6-1/+42
2013-01-17Count size relocation as PC-relative relocationH.J. Lu4-2/+24
bfd/ * elf32-i386.c (elf_i386_check_relocs): Count size relocation as PC-relative relocation. * elf64-x86-64.c (elf_x86_64_check_relocs): Count size relocation as PC-relative relocation. ld/testsuite/ * ld-size/size32-3-i386.d: New file. * ld-size/size32-3-x32.d: Likewise. * ld-size/size32-3-x86-64.d: Likewise. * ld-size/size32-3.s: Likewise.
2013-01-17 * powerpc.cc (Stub_table::find_plt_call_entry): Make typesAlan Modra2-6/+12
used in declaration and definition consistent. (Target_powerpc::symval_for_branch): Ditto.
2013-01-17 * dwarf2read.c (dw2_build_type_unit_groups_reader): Delete.Doug Evans2-47/+15
(dw2_build_type_unit_groups): Delete. All uses updated.
generated by cgit v1.1 at 2025-01-04 03:38:52 +0000