aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2015-08-31ppc64 section group handlingAlan Modra4-176/+192
Two organizational changes to the array of additional info kept for sections. 1) Move group info into a per-group allocated struct, in preparation for future changes that need per-group accounting. 2) Expand the array to include output sections, which simplifies sizing and removes the need for a separate output section array. * section.c (section_id): Make file scope. (bfd_get_next_section_id): New function. * elf64-ppc.c (struct map_stub): Remove toc_off field. Move decl. (struct ppc_stub_hash_entry): Delete stub_sec and id_sec. Add group. Update all uses. (struct ppc_link_hash_table): Delete top_id, top_index, and input_list. Add sec_info_arr_size. Rename stub_group to sec_info, and make group info indirect. Update stub_group refs throughout file. (ppc_add_stub): Don't look for stub_sec on link_sec stub_group entry. (ppc_build_one_stub): Delete FIXME. (ppc64_elf_setup_section_lists): Size htab->sec_info for all sections, not just input sections. Don't create htab->input_list. (ppc64_elf_next_input_section): Update to use sec_info union as list pointer. (PREV_SEC): Delete. (group_sections): Pass "info" param rather than "htab". Iterate over output sections rather than input_list. Use sec_info union as list pointers. Alloc atruct map_stub, and return fail status. * bfd-in2.h: Regenerate.
2015-08-31gdb/tui: Make local variable const.Andrew Burgess2-1/+6
Small clean up to make a local variable const and remove a cast of NULL. gdb/ChangeLog: * tui/tui-data.c (tui_win_name): Make local variable const, remove cast of NULL.
2015-08-31xtensa: initialize call_abi in xtensa_tdepMax Filippov2-1/+8
Use XSHAL_ABI value provided by xtensa-config.h to correctly initialize xtensa_tdep.call_abi This fixes calls to functions from GDB that otherwise fail with the following assertion in call0 configuration: gdb/regcache.c:602: internal-error: regcache_raw_read: Assertion `regnum >= 0 && regnum < regcache->descr->nr_raw_registers' failed. 2015-08-31 Max Filippov <jcmvbkbc@gmail.com> gdb/ * xtensa-tdep.h (XTENSA_GDBARCH_TDEP_INSTANTIATE): Initialize call_abi using XSHAL_ABI macro.
2015-08-31More "Make asection->id and asection->index unsigned"Alan Modra4-5/+13
Fixes regressions introduced by 7292b3ac. * elflink.c (elf_sort_symbol): Use correctly sized type for calculating signed section->id difference. (elf_link_add_object_symbols): Likewise. * pef.c (bfd_pef_scan_start_address): Warning fix. * vms-alpha.c (vms_new_section_hook): Likewise.
2015-08-31NDS32 build fixesAlan Modra2-5/+13
* elf32-nds32.c (nds32_convert_32_to_16_alu1): Warning fix. (find_relocs_at_address_addr): Make "reloc_type" an enum. (nds32_elf_relax_delete_blanks): Warning fix. (nds32_elf_relax_loadstore): Correct loop bound.
2015-08-31Regen intl/configureAlan Modra2-214/+603
* configure: Regenerate.
2015-08-31Make asection->id and asection->index unsignedAlan Modra14-28/+46
These int vars are really unsigned, so make them so. * section.c (struct bfd_section): Make "id" and "index" unsigned. * coff-rs6000.c (_bfd_xcoff_sizeof_headers): Adjust local var to suit. * elf.c (elf_map_symbols): Likewise. * elf64-ppc.c (sym_exists_at): Make "id" param unsigned. (struct ppc_link_hash_table): Make "top_id" and "top_index" unsigned. (ppc64_elf_setup_section_lists): Ditto for local vars. * elf32-arm.c: Similarly to elf64-ppc.c. * elf32-avr.c: Likewise. * elf32-hppa.c: Likewise. * elf32-m68hc1x.c: Likewise. * elf32-metag.c: Likewise. * elf32-nios2.c: Likewise. * elfnn-aarch64.c: Likewise. * simple.c (struct saved_offsets): Make "section_count" unsigned. * bfd-in2.h: Regenerate.
2015-08-31Automatic date update in version.inGDB Administrator1-1/+1
2015-08-29symtab.h (struct symbol): Tweak comment.Doug Evans2-5/+8
gdb/ChangeLog: * symtab.h (struct symbol): Tweak comment.
2015-08-30Automatic date update in version.inGDB Administrator1-1/+1
2015-08-29Revert "Use gdbarch obstack to allocate the TYPE_NAME string in arch_type"Patrick Palka4-22/+1
This patch manually modified the autogenerated files gdbarch.[ch] instead of going through gdbarch.sh. This reverts commit aa78b3b28aeff4bb9977a313f5a8002d920b34c5.
2015-08-29Use gdbarch obstack to allocate the TYPE_NAME string in arch_typePatrick Palka4-1/+22
Since the type whose name is being set is now being allocated on the gdbarch obstack, we should allocate its TYPE_NAME on the obstack too. This reduces the number of individual valgrind warnings for the command "gdb gdb" from ~300 to ~150. Tested on x86_64-unknown-linux-gnu. gdb/ChangeLog: * gdbarch.h (gdbarch_obstack_strdup): Declare. * gdbarch.c (gdbarch_obstack_strdup): Define. * gdbtypes.c (arch_type): Use it.
2015-08-29Use gdbarch obstack to allocate types in alloc_type_archPatrick Palka2-3/+9
For the command "gdb gdb" valgrind currently reports 100s of individual memory leaks, 500 of which originate solely out of the function alloc_type_arch. This function allocates a "struct type" associated with the given gdbarch using malloc but apparently the types allocated by this function are never freed. This patch fixes these leaks by making the function alloc_type_arch allocate these gdbarch-associated types on the gdbarch obstack instead of on the general heap. Since, from what I can tell, the types allocated by this function are all fundamental "wired-in" types, such types would not benefit from more granular memory management anyway. They would likely live as long as the gdbarch is alive so allocating them on the gdbarch obstack makes sense. With this patch, the number of individual vargrind warnings emitted for the command "gdb gdb" drops from ~800 to ~300. Tested on x86_64-unknown-linux-gnu. gdb/ChangeLog: * gdbtypes.c (alloc_type_arch): Allocate the type on the given gdbarch obstack instead of on the heap. Update commentary accordingly.
2015-08-29Automatic date update in version.inGDB Administrator1-1/+1
2015-08-28Document the GDB 7.10 release in gdb/ChangeLogJoel Brobecker1-0/+4
gdb/ChangeLog: GDB 7.10 released.
2015-08-28Update NEWS entry about non-8-bits addressable memorySimon Marchi2-1/+5
2015-08-28Revert: solib_global_lookup: Fetch arch from objfile.Ulrich Weigand2-1/+8
solib_ops are installed as a property of the inferior gdbarch, so they need to be systematically looked up via that architecture, not some objfile architecture. ChangeLog: Revert: 2014-11-06 Doug Evans <xdje42@gmail.com> * solib.c (solib_global_lookup): Fetch arch from objfile, not target_gdbarch.
2015-08-28Fix incorrect ChangeLog dates.Ulrich Weigand1-4/+4
2015-08-28Also install readelf into tooldir/bin directoryH.J. Lu3-2/+7
* Makefile.am (TOOL_PROGS): Add readelf. * Makefile.in: Regenerated.
2015-08-28Automatic date update in version.inGDB Administrator1-1/+1
2015-08-27Fix ChangeLog entries starting with "Likewise"Simon Marchi2-2/+4
The first lines of these ChangeLog entries are "Likewise"... it doesn't make much sense.
2015-08-27[Cell/B.E.] Fix wrong relocation for TLS variable offsetUlrich Weigand2-1/+6
When debugging Cell/B.E. code, the cross-architecture frame unwinding works by accessing data structures refered to by a thread-local variable in the inferior. While accessing this variable via minimal symbol, code would use BMSYMBOL_VALUE_ADDRESS to determine the offset of the variable in the thread-local storage block. This is incorrect, since it adds any relocation offset of the shared library defining the TLS variable. That offset would be OK when accessing the initial copy present in the .tbss section, but it must not be applied to the offset of the variable in the TLS block at runtime. Depending on whether or not the libspe2.so library was prelinked, access to the variable would fail due to the incorrectly relocated offset. ChangeLog: * ppc-linux-tdep.c (ppc_linux_spe_context_lookup): Do not attempt to relocate a TLS variable offset.
2015-08-27[Cell/B.E.] Make parse_spufs_run more robustUlrich Weigand2-1/+16
With recent changes to inferior handling, parse_spufs_run needs to be more careful in assumptions it makes. In particular, this patch: - Bails out early if the current inferior has not yet been registered (e.g. during fork procession) to avoid assertion failures in register cache code. - Sets inferior_ptid to the current ptid while calling target_read_memory to make sure the correct process is accessed if parse_spufs_run is called early when inferior_ptid has not yet been switched by the caller. ChangeLog: * spu-multiarch.c (parse_spufs_run): Bail out if inferior is not registered yet. Set inferior_ptid while calling target_read_memory.
2015-08-27Detect SW breakpoints in Cell/B.E. combined debuggingUlrich Weigand5-6/+25
The Linux target and gdbserver now check the siginfo si_code reported on a SIGTRAP to detect whether the trap indicates a software breakpoint was hit. Unfortunately, on Cell/B.E., the kernel uses an si_code value of TRAP_BRKPT when a SW breakpoint was hit in PowerPC code, but a si_code value of SI_KERNEL when a SW breakpoint was hit in SPU code. This patch updates Linux target and gdbserver to accept both si_code values to indicate SW breakpoint on PowerPC. ChangeLog: * nat/linux-ptrace.h (GDB_ARCH_TRAP_BRKPT): Replace by ... (GDB_ARCH_IS_TRAP_BRKPT): ... this. Add __powerpc__ case. * linux-nat.c (check_stopped_by_breakpoint): Use GDB_ARCH_IS_TRAP_BRKPT instead of GDB_ARCH_TRAP_BRKPT. gdbserver/ChangeLog: * linux-low.c (check_stopped_by_breakpoint): Use GDB_ARCH_IS_TRAP_BRKPT instead of GDB_ARCH_TRAP_BRKPT.
2015-08-27Fix assertion failure in linux-thread-dbUlrich Weigand2-4/+13
Since we are no longer using thread events by default in linux-thread-db, the find_new_threads_once routine contains an assertion that it should never be called on a live inferior unless using thread events: gdb_assert (!target_has_execution || thread_db_use_events ()); However, there is a code path from thread_db_get_thread_local_address that will in fact call find_new_threads_once in some scenarios. In particular, this is currently always triggered when starting up any Cell/B.E. combined exeuctable. To fix this, this patch removes the call to thread_db_find_new_threads_1 when the current thread was not yet detected. In its place, we now just call thread_from_lwp to detect this one thread if necessary. ChangeLog: * linux-thread-db.c (thread_db_get_thread_local_address): If the thread was not yet discovered, use thread_from_lwp instead of calling thread_db_find_new_threads_1.
2015-08-27Report UNRESOLVED on failures while detecting Cell/B.E.Ulrich Weigand2-1/+6
The gdb.cell testcases use the predicate skip_cell_tests defined in lib/cell.exp to determine whether Cell/B.E. test cases ought to be run. This tests verifies that we have a toolchain that supports generating combined Cell/B.E. binaries, and that the target machine actually is a Cell/B.E. In order to do so, a small test program is built and run (under the debugger). Any failure is taken as a sign that we don't have a Cell/B.E. machine and the tests are to be skipped. This has the unfortunate effect that a serious bug in GDB that causes internal compiler errors even on the trivial test program does not lead to any failures in the testsuite, since now all gdb.cell test are simply skipped. This patch changes skip_cell_tests to at least report UNRESOLVED in cases where execution of the test program fails in unexpected ways. testsuite/ChangeLog: * lib/cell.exp (skip_cell_tests): Report UNRESOLVED on unexpected failures to run the test program under GDB.
2015-08-27Add reloc sort testAlan Modra4-0/+62
* ld-powerpc/relocsort.s, * ld-powerpc/relocsort.d: New test. * ld-powerpc/powerpc.exp: Run it.
2015-08-27More fallout from "Allow symbol and label names to be enclosed in double quotes"Alan Modra18-92/+134
Some of the TC_START_LABEL implementations need to adjust the end of the symbol, when a colon doesn't mean a label definition. That means they need access to nul_char both the restore the NUL location (it may be a quote rather than a colon) and to store the new nul_char. Others need adjusting to step over a potential trailing quote. PR gas/18581 * config/tc-aarch64.h (TC_START_LABEL): Redefine. * config/tc-arm.c (tc_start_label_without_colon): Delete params. Use input_line_pointer directly. * config/tc-arm.h (TC_START_LABEL): Redefine. (TC_START_LABEL_WITHOUT_COLON): Redefine. (tc_start_label_without_colon): Update prototype. * config/tc-bfin.c (bfin_start_label): Delete ptr param. Check for NUL instead. * config/tc-bfin.h (bfin_start_label): Update prototype. (TC_START_LABEL): Redefine. * config/tc-d30v.h (TC_START_LABEL): Redefine. * config/tc-fr30.c (restore_colon): Rewrite. (fr30_is_colon_insn): Add nul_char param. Return int. Bump i_l_p over quote. Update restore_colon calls. * config/tc-fr30.h (TC_START_LABEL): Redefine. (fr30_is_colon_insn): Update prototype. * config/tc-m32c.c (restore_colon, m32c_is_colon_insn): As above. * config/tc-m32c.h (TC_START_LABEL): Redefine. (m32c_is_colon_insn): Update prototype. * config/tc-m32r.h (TC_START_LABEL): Redefine. * config/tc-mep.h (TC_START_LABEL): Redefine. * config/tc-nds32.h (TC_START_LABEL): Redefine. * config/tc-tic54x.c (tic54x_start_label): Replace params with nul_char and next_char. Step over trailing quote. * config/tc-tic54x.h (TC_START_LABEL_WITHOUT_COLON): Redefine. (tic54x_start_label): Update prototype. * read.c (TC_START_LABEL): Redefine. Update invocation. (TC_START_LABEL_WITHOUT_COLON): Update invocation. * config/tc-nios2.c (s_nios2_set): Save initial input_line_pointer and restore if calling s_set. Don't restore delim again.
2015-08-27Fix inverted statements in m88k_analyze_prologueSimon Marchi2-2/+7
These two statements were inverted by mistake in commit "Replace some xmalloc-family functions with XNEW-family ones". It obviously doesn't make sense to have them in this order, which is why I am pushing this as obvious. gdb/ChangeLog: * m88k-tdep.c (m88k_analyze_prologue): Fix inverted allocation statements.
2015-08-27Remove duplicate ChangeLog entrySimon Marchi1-4/+0
2015-08-27Document non-8-bits addressable memory support in NEWSSimon Marchi2-0/+11
I think it would be a good idea to document that gdb now has (basic) support to read/write memory on architectures with non-8-bits memory. Hopefully somebody will see it and say "Hey! We can now (more easily) port GDB to our strange DSP that has 32-bits-addressable memory!" and do it. gdb/ChangeLog: * NEWS: Document support for non-8-bits addressable memory.
2015-08-27gdbserver/proc-service.c: bogus return value conversionPedro Alves2-1/+7
Building in C++ mode shows: int write_inferior_memory (CORE_ADDR memaddr, const unsigned char *myaddr, ^ src/gdb/gdbserver/proc-service.c:93:64: error: invalid conversion from ‘int’ to ‘ps_err_e’ [-fpermissive] return write_inferior_memory ((unsigned long) addr, buf, size); ^ It only works today by accident, write_inferior_memory does not return a ps_err_e. gdb/gdbserver/ChangeLog: 2015-08-27 Pedro Alves <palves@redhat.com> * proc-service.c (ps_pdwrite): Return PS_ERR/PS_OK explicily.
2015-08-27gdb: Drop use of obsolete AC_TYPE_SIGNALPedro Alves4-37/+5
Since we're using sighandler_t, nothing else refers to RETSIGTYPE in gdb. (Actually, given gdb/remote.c has been assuming signal handlers return void for a long time, we could have gotten get rid of this even without gnulib's sighandler_t.) gdb/ChangeLog: 2015-08-27 Pedro Alves <palves@redhat.com> * configure.ac: Remove AC_TYPE_SIGNAL call. * configure, config.in: Regenerate.
2015-08-27gdb: Use sighandler_t everywherePedro Alves9-21/+39
This fixes 14 build errors like these in C++ mode: src/gdb/extension.c: In function ‘void install_sigint_handler(const signal_handler*)’: src/gdb/extension.c:698:41: error: invalid conversion from ‘void (*)()’ to ‘__sighandler_t {aka void (*)(int)}’ [-fpermissive] signal (SIGINT, handler_state->handler); ^ In file included from build-gnulib/import/signal.h:52:0, from ../../src/gdb/extension.c:24: /usr/include/signal.h:102:23: error: initializing argument 2 of ‘void (* signal(int, __sighandler_t))(int)’ [-fpermissive] extern __sighandler_t signal (int __sig, __sighandler_t __handler) ^ Instead of this everywhere: - RETSIGTYPE (*handle_sigint_for_compare) () = handle_sigint; + RETSIGTYPE (*handle_sigint_for_compare) (int) = handle_sigint; Use sighandler_t (a GNU extension). That's OK to use unconditionaly because gnulib's signal.h replacement makes sure that it is available. gdb/ChangeLog: 2015-08-27 Pedro Alves <palves@redhat.com> * cp-support.c (gdb_demangle): Use sighandler_t. Remove cast. * extension-priv.h: Include signal.h. (struct signal_handler) <handler>: Change type to sighandler_t. * extension.c (install_gdb_sigint_handler): Use sighandler_t. * inflow.c (sigint_ours, sigquit_ours): Change type to sighandler_t. (child_terminal_inferior): Remove casts. (child_terminal_ours_1, new_tty): Use sighandler_t. Remove casts. (osig): Change type to sighandler_t. * nto-procfs.c (ofunc): Change type to sighandler_t. (procfs_wait): Remove casts. * remote-m32r-sdi.c (m32r_wait, m32r_load): Use sighandler_t. * remote-sim.c (gdbsim_wait): Use sighandler_t. * utils.c (wait_to_die_with_timeout): Use sighandler_t.
2015-08-27Import the "signal-h" module from gnulibPedro Alves11-21/+954
This gives us a signal.h replacement that makes sure the sighandler_t typedef (a GNU extension) is always available. A follow up patch will make use of this. gdb/ChangeLog: 2015-08-27 Pedro Alves <palves@redhat.com> * gnulib/update-gnulib.sh (IMPORTED_GNULIB_MODULES): Add signal-h. * gnulib/aclocal.m4: Renegerate. * gnulib/config.in: Renegerate. * gnulib/configure: Renegerate. * gnulib/import/Makefile.am: Update. * gnulib/import/Makefile.in: Regenerate. * gnulib/import/m4/gnulib-cache.m4: Update. * gnulib/import/m4/gnulib-comp.m4: Update. * gnulib/import/m4/signal_h.m4: New file. * gnulib/import/signal.in.h: New file.
2015-08-27Fix ChangeLog entry date and mention gdb/18804Pedro Alves1-1/+2
2015-08-27gdb: remove packet size limitPedro Alves2-35/+49
The remote packet buffer size is currently capped to 16384 mostly for historical reasons, related to use of alloca. Stop using alloca and remove the limitation. Tested on x86_64 Fedora 20. gdb/ChangeLog: 2015-08-27 Pedro Alves <palves@redhat.com> * remote.c (DEFAULT_MAX_MEMORY_PACKET_SIZE) (MIN_MEMORY_PACKET_SIZE): New. (MAX_REMOTE_PACKET_SIZE, MIN_REMOTE_PACKET_SIZE): Delete. (get_memory_packet_size): Adjust. No longer limit the max packet size. (set_memory_packet_size): Adjust, and remove dead code. (remote_check_symbols): Use xmalloc and a cleanup instead of alloca. (remote_packet_size): No longer cap the packet size. (putpkt_binary): Use xmalloc and a cleanup instead of alloca.
2015-08-27Mention language in compile error messageLuis Machado2-1/+7
This patch improves one of the compile error messages by mentioning the language. Before - No compiler support for this language. After - No compiler support for language <language>. gdb/ChangeLog: 2015-08-26 Luis Machado <lgustavo@codesourcery.com> * compile/compile.c (compile_to_object): Mention language in error message.
2015-08-27Force language to C in gdb.compile/compile-ifunc.expLuis Machado2-0/+11
Due to the lack of debug information in the binary, GDB is unable to figure out what language is being used. This may be a problem when doing remote debugging and the binary stops at the entry point containing asm code. In this case GDB will switch to asm as current language and will not switch back to C when it reaches main, which in turn causes the compile feature check to malfunction. This is solved by forcing the language to C after reaching main. gdb/testsuite/ChangeLog: 2015-08-26 Luis Machado <lgustavo@codesourcery.com> * gdb.compile/compile-ifunc.exp (with_test_prefix): Force language to C.
2015-08-27Add missing pr referenceAlan Modra1-0/+1
2015-08-27Don't sort ld -r output relocs on alphaAlan Modra2-0/+19
LITERAL/LITUSE relocs must be kept together. * elf64-alpha.c (elf64_alpha_sort_relocs_p): New function. (elf_backend_sort_relocs_p): Define.
2015-08-26Unset attach_flag when running a new processPatrick Palka5-0/+100
We currently set attach_flag when attaching to a process, so we should make sure to unset it when forking a new process. Otherwise attach_flag would remain set after forking, if the previous process associated with the inferior was attached to. gdb/ChangeLog: * target.c (target_pre_inferior): Unset attach_flag. gdb/testsuite/ChangeLog: * gdb.base/run-after-attach.exp: New test file. * gdb.base/run-after-attach.c: New test file.
2015-08-27Automatic date update in version.inGDB Administrator1-1/+1
2015-08-26Fix gdbarch.c build errorSimon Marchi3-2/+7
I made a mistake while handling my previous patch. A change in gdbarch causes a build failure. gdb/ChangeLog: * gdbarch.sh (append_name): Fix type in XRESIZEVEC. * gdbarch.c: Re-generate.
2015-08-26Replace some xmalloc-family functions with XNEW-family onesSimon Marchi177-675/+906
This patch is part of the make-gdb-buildable-in-C++ effort. The idea is to change some calls to the xmalloc family of functions to calls to the equivalents in the XNEW family. This avoids adding an explicit cast, so it keeps the code a bit more readable. Some of them also map relatively well to a C++ equivalent (XNEW (struct foo) -> new foo), so it will be possible to do scripted replacements if needed. I only changed calls that were obviously allocating memory for one or multiple "objects". Allocation of variable sizes (such as strings or buffer handling) will be for later (and won't use XNEW). - xmalloc (sizeof (struct foo)) -> XNEW (struct foo) - xmalloc (num * sizeof (struct foo)) -> XNEWVEC (struct foo, num) - xcalloc (1, sizeof (struct foo)) -> XCNEW (struct foo) - xcalloc (num, sizeof (struct foo)) -> XCNEWVEC (struct foo, num) - xrealloc (p, num * sizeof (struct foo) -> XRESIZEVEC (struct foo, p, num) - obstack_alloc (ob, sizeof (struct foo)) -> XOBNEW (ob, struct foo) - obstack_alloc (ob, num * sizeof (struct foo)) -> XOBNEWVEC (ob, struct foo, num) - alloca (sizeof (struct foo)) -> XALLOCA (struct foo) - alloca (num * sizeof (struct foo)) -> XALLOCAVEC (struct foo, num) Some instances of xmalloc followed by memset to zero the buffer were replaced by XCNEW or XCNEWVEC. I regtested on x86-64, Ubuntu 14.04, but the patch touches many architecture-specific files. For those I'll have to rely on the buildbot or people complaining that I broke their gdb. gdb/ChangeLog: * aarch64-linux-nat.c (aarch64_add_process): Likewise. * aarch64-tdep.c (aarch64_gdbarch_init): Likewise. * ada-exp.y (write_ambiguous_var): Likewise. * ada-lang.c (resolve_subexp): Likewise. (user_select_syms): Likewise. (assign_aggregate): Likewise. (ada_evaluate_subexp): Likewise. (cache_symbol): Likewise. * addrmap.c (allocate_key): Likewise. (addrmap_create_mutable): Likewise. * aix-thread.c (sync_threadlists): Likewise. * alpha-tdep.c (alpha_push_dummy_call): Likewise. (alpha_gdbarch_init): Likewise. * amd64-windows-tdep.c (amd64_windows_push_arguments): Likewise. * arm-linux-nat.c (arm_linux_add_process): Likewise. * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise. * arm-tdep.c (push_stack_item): Likewise. (arm_displaced_step_copy_insn): Likewise. (arm_gdbarch_init): Likewise. (_initialize_arm_tdep): Likewise. * avr-tdep.c (push_stack_item): Likewise. * ax-general.c (new_agent_expr): Likewise. * block.c (block_initialize_namespace): Likewise. * breakpoint.c (alloc_counted_command_line): Likewise. (update_dprintf_command_list): Likewise. (parse_breakpoint_sals): Likewise. (decode_static_tracepoint_spec): Likewise. (until_break_command): Likewise. (clear_command): Likewise. (update_global_location_list): Likewise. (get_breakpoint_objfile_data) Likewise. * btrace.c (ftrace_new_function): Likewise. (btrace_set_insn_history): Likewise. (btrace_set_call_history): Likewise. * buildsym.c (add_symbol_to_list): Likewise. (record_pending_block): Likewise. (start_subfile): Likewise. (start_buildsym_compunit): Likewise. (push_subfile): Likewise. (end_symtab_get_static_block): Likewise. (buildsym_init): Likewise. * cli/cli-cmds.c (source_command): Likewise. * cli/cli-decode.c (add_cmd): Likewise. * cli/cli-script.c (build_command_line): Likewise. (setup_user_args): Likewise. (realloc_body_list): Likewise. (process_next_line): Likewise. (copy_command_lines): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (read_pe_exported_syms): Likewise. * coffread.c (coff_locate_sections): Likewise. (coff_symtab_read): Likewise. (coff_read_struct_type): Likewise. * common/cleanups.c (make_my_cleanup2): Likewise. * common/common-exceptions.c (throw_it): Likewise. * common/filestuff.c (make_cleanup_close): Likewise. * common/format.c (parse_format_string): Likewise. * common/queue.h (DEFINE_QUEUE_P): Likewise. * compile/compile-object-load.c (munmap_list_add): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * compile/compile.c (append_args): Likewise. * corefile.c (specify_exec_file_hook): Likewise. * cp-support.c (make_symbol_overload_list): Likewise. * cris-tdep.c (push_stack_item): Likewise. (cris_gdbarch_init): Likewise. * ctf.c (ctf_trace_file_writer_new): Likewise. * dbxread.c (init_header_files): Likewise. (add_new_header_file): Likewise. (init_bincl_list): Likewise. (dbx_end_psymtab): Likewise. (start_psymtab): Likewise. (dbx_end_psymtab): Likewise. * dcache.c (dcache_init): Likewise. * dictionary.c (dict_create_hashed): Likewise. (dict_create_hashed_expandable): Likewise. (dict_create_linear): Likewise. (dict_create_linear_expandable): Likewise. * dtrace-probe.c (dtrace_process_dof_probe): Likewise. * dummy-frame.c (register_dummy_frame_dtor): Likewise. * dwarf2-frame-tailcall.c (cache_new_ref1): Likewise. * dwarf2-frame.c (dwarf2_build_frame_info): Likewise. (decode_frame_entry_1): Likewise. * dwarf2expr.c (new_dwarf_expr_context): Likewise. * dwarf2loc.c (dwarf2_compile_expr_to_ax): Likewise. * dwarf2read.c (dwarf2_has_info): Likewise. (create_signatured_type_table_from_index): Likewise. (dwarf2_read_index): Likewise. (dw2_get_file_names_reader): Likewise. (create_all_type_units): Likewise. (read_cutu_die_from_dwo): Likewise. (init_tu_and_read_dwo_dies): Likewise. (init_cutu_and_read_dies): Likewise. (create_all_comp_units): Likewise. (queue_comp_unit): Likewise. (inherit_abstract_dies): Likewise. (read_call_site_scope): Likewise. (dwarf2_add_field): Likewise. (dwarf2_add_typedef): Likewise. (dwarf2_add_member_fn): Likewise. (attr_to_dynamic_prop): Likewise. (abbrev_table_alloc_abbrev): Likewise. (abbrev_table_read_table): Likewise. (add_include_dir): Likewise. (add_file_name): Likewise. (dwarf_decode_line_header): Likewise. (dwarf2_const_value_attr): Likewise. (dwarf_alloc_block): Likewise. (parse_macro_definition): Likewise. (set_die_type): Likewise. (write_psymtabs_to_index): Likewise. (create_cus_from_index): Likewise. (dwarf2_create_include_psymtab): Likewise. (process_psymtab_comp_unit_reader): Likewise. (build_type_psymtab_dependencies): Likewise. (read_comp_units_from_section): Likewise. (compute_compunit_symtab_includes): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (load_partial_dies): Likewise. (dwarf2_symbol_mark_computed): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_read_minimal_symbols): Likewise. * environ.c (make_environ): Likewise. * eval.c (evaluate_subexp_standard): Likewise. * event-loop.c (create_file_handler): Likewise. (create_async_signal_handler): Likewise. (create_async_event_handler): Likewise. (create_timer): Likewise. * exec.c (build_section_table): Likewise. * fbsd-nat.c (fbsd_remember_child): Likewise. * fork-child.c (fork_inferior): Likewise. * frv-tdep.c (new_variant): Likewise. * gdbarch.sh (gdbarch_alloc): Likewise. (append_name): Likewise. * gdbtypes.c (rank_function): Likewise. (copy_type_recursive): Likewise. (add_dyn_prop): Likewise. * gnu-nat.c (make_proc): Likewise. (make_inf): Likewise. (gnu_write_inferior): Likewise. * gnu-v3-abi.c (build_gdb_vtable_type): Likewise. (build_std_type_info_type): Likewise. * guile/scm-param.c (compute_enum_list): Likewise. * guile/scm-utils.c (gdbscm_parse_function_args): Likewise. * guile/scm-value.c (gdbscm_value_call): Likewise. * h8300-tdep.c (h8300_gdbarch_init): Likewise. * hppa-tdep.c (hppa_init_objfile_priv_data): Likewise. (read_unwind_info): Likewise. * ia64-tdep.c (ia64_gdbarch_init): Likewise. * infcall.c (dummy_frame_context_saver_setup): Likewise. (call_function_by_hand_dummy): Likewise. * infcmd.c (step_once): Likewise. (finish_forward): Likewise. (attach_command): Likewise. (notice_new_inferior): Likewise. * inferior.c (add_inferior_silent): Likewise. * infrun.c (add_displaced_stepping_state): Likewise. (save_infcall_control_state): Likewise. (save_inferior_ptid): Likewise. (_initialize_infrun): Likewise. * jit.c (bfd_open_from_target_memory): Likewise. (jit_gdbarch_data_init): Likewise. * language.c (add_language): Likewise. * linespec.c (decode_line_2): Likewise. * linux-nat.c (add_to_pid_list): Likewise. (add_initial_lwp): Likewise. * linux-thread-db.c (add_thread_db_info): Likewise. (record_thread): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_gdbarch_init): Likewise. * m68hc11-tdep.c (m68hc11_gdbarch_init): Likewise. * m68k-tdep.c (m68k_gdbarch_init): Likewise. * m88k-tdep.c (m88k_analyze_prologue): Likewise. * macrocmd.c (macro_define_command): Likewise. * macroexp.c (gather_arguments): Likewise. * macroscope.c (sal_macro_scope): Likewise. * macrotab.c (new_macro_table): Likewise. * mdebugread.c (push_parse_stack): Likewise. (parse_partial_symbols): Likewise. (parse_symbol): Likewise. (psymtab_to_symtab_1): Likewise. (new_block): Likewise. (new_psymtab): Likewise. (mdebug_build_psymtabs): Likewise. (add_pending): Likewise. (elfmdebug_build_psymtabs): Likewise. * mep-tdep.c (mep_gdbarch_init): Likewise. * mi/mi-main.c (mi_execute_command): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. * minidebug.c (lzma_open): Likewise. * minsyms.c (terminate_minimal_symbol_table): Likewise. * mips-linux-nat.c (mips_linux_insert_watchpoint): Likewise. * mips-tdep.c (mips_gdbarch_init): Likewise. * mn10300-tdep.c (mn10300_gdbarch_init): Likewise. * msp430-tdep.c (msp430_gdbarch_init): Likewise. * mt-tdep.c (mt_registers_info): Likewise. * nat/aarch64-linux.c (aarch64_linux_new_thread): Likewise. * nat/linux-btrace.c (linux_enable_bts): Likewise. (linux_enable_pt): Likewise. * nat/linux-osdata.c (linux_xfer_osdata_processes): Likewise. (linux_xfer_osdata_processgroups): Likewise. * nios2-tdep.c (nios2_gdbarch_init): Likewise. * nto-procfs.c (procfs_meminfo): Likewise. * objc-lang.c (start_msglist): Likewise. (selectors_info): Likewise. (classes_info): Likewise. (find_methods): Likewise. * objfiles.c (allocate_objfile): Likewise. (update_section_map): Likewise. * osabi.c (gdbarch_register_osabi): Likewise. (gdbarch_register_osabi_sniffer): Likewise. * parse.c (start_arglist): Likewise. * ppc-linux-nat.c (hwdebug_find_thread_points_by_tid): Likewise. (hwdebug_insert_point): Likewise. * printcmd.c (display_command): Likewise. (ui_printf): Likewise. * procfs.c (create_procinfo): Likewise. (load_syscalls): Likewise. (proc_get_LDT_entry): Likewise. (proc_update_threads): Likewise. * prologue-value.c (make_pv_area): Likewise. (pv_area_store): Likewise. * psymtab.c (extend_psymbol_list): Likewise. (init_psymbol_list): Likewise. (allocate_psymtab): Likewise. * python/py-inferior.c (add_thread_object): Likewise. * python/py-param.c (compute_enum_values): Likewise. * python/py-value.c (valpy_call): Likewise. * python/py-varobj.c (py_varobj_iter_next): Likewise. * python/python.c (ensure_python_env): Likewise. * record-btrace.c (record_btrace_start_replaying): Likewise. * record-full.c (record_full_reg_alloc): Likewise. (record_full_mem_alloc): Likewise. (record_full_end_alloc): Likewise. (record_full_core_xfer_partial): Likewise. * regcache.c (get_thread_arch_aspace_regcache): Likewise. * remote-fileio.c (remote_fileio_init_fd_map): Likewise. * remote-notif.c (remote_notif_state_allocate): Likewise. * remote.c (demand_private_info): Likewise. (remote_notif_stop_alloc_reply): Likewise. (remote_enable_btrace): Likewise. * reverse.c (save_bookmark_command): Likewise. * rl78-tdep.c (rl78_gdbarch_init): Likewise. * rx-tdep.c (rx_gdbarch_init): Likewise. * s390-linux-nat.c (s390_insert_watchpoint): Likewise. * ser-go32.c (dos_get_tty_state): Likewise. (dos_copy_tty_state): Likewise. * ser-mingw.c (ser_windows_open): Likewise. (ser_console_wait_handle): Likewise. (ser_console_get_tty_state): Likewise. (make_pipe_state): Likewise. (net_windows_open): Likewise. * ser-unix.c (hardwire_get_tty_state): Likewise. (hardwire_copy_tty_state): Likewise. * solib-aix.c (solib_aix_new_lm_info): Likewise. * solib-dsbt.c (dsbt_current_sos): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (frv_current_sos): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_bfd_fopen): Likewise. * solib-svr4.c (lm_info_read): Likewise. (svr4_copy_library_list): Likewise. (svr4_default_sos): Likewise. * source.c (find_source_lines): Likewise. (line_info): Likewise. (add_substitute_path_rule): Likewise. * spu-linux-nat.c (spu_bfd_open): Likewise. * spu-tdep.c (info_spu_dma_cmdlist): Likewise. * stabsread.c (dbx_lookup_type): Likewise. (read_type): Likewise. (read_member_functions): Likewise. (read_struct_fields): Likewise. (read_baseclasses): Likewise. (read_args): Likewise. (_initialize_stabsread): Likewise. * stack.c (func_command): Likewise. * stap-probe.c (handle_stap_probe): Likewise. * symfile.c (addrs_section_sort): Likewise. (addr_info_make_relative): Likewise. (load_section_callback): Likewise. (add_symbol_file_command): Likewise. (init_filename_language_table): Likewise. * symtab.c (create_filename_seen_cache): Likewise. (sort_search_symbols_remove_dups): Likewise. (search_symbols): Likewise. * target.c (make_cleanup_restore_target_terminal): Likewise. * thread.c (new_thread): Likewise. (enable_thread_stack_temporaries): Likewise. (make_cleanup_restore_current_thread): Likewise. (thread_apply_all_command): Likewise. * tic6x-tdep.c (tic6x_gdbarch_init): Likewise. * top.c (gdb_readline_wrapper): Likewise. * tracefile-tfile.c (tfile_trace_file_writer_new): Likewise. * tracepoint.c (trace_find_line_command): Likewise. (all_tracepoint_actions_and_cleanup): Likewise. (make_cleanup_restore_current_traceframe): Likewise. (get_uploaded_tp): Likewise. (get_uploaded_tsv): Likewise. * tui/tui-data.c (tui_alloc_generic_win_info): Likewise. (tui_alloc_win_info): Likewise. (tui_alloc_content): Likewise. (tui_add_content_elements): Likewise. * tui/tui-disasm.c (tui_find_disassembly_address): Likewise. (tui_set_disassem_content): Likewise. * ui-file.c (ui_file_new): Likewise. (stdio_file_new): Likewise. (tee_file_new): Likewise. * utils.c (make_cleanup_restore_integer): Likewise. (add_internal_problem_command): Likewise. * v850-tdep.c (v850_gdbarch_init): Likewise. * valops.c (find_oload_champ): Likewise. * value.c (allocate_value_lazy): Likewise. (record_latest_value): Likewise. (create_internalvar): Likewise. * varobj.c (install_variable): Likewise. (new_variable): Likewise. (new_root_variable): Likewise. (cppush): Likewise. (_initialize_varobj): Likewise. * windows-nat.c (windows_make_so): Likewise. * x86-nat.c (x86_add_process): Likewise. * xcoffread.c (arrange_linetable): Likewise. (allocate_include_entry): Likewise. (process_linenos): Likewise. (SYMBOL_DUP): Likewise. (xcoff_start_psymtab): Likewise. (xcoff_end_psymtab): Likewise. * xml-support.c (gdb_xml_parse_attr_ulongest): Likewise. * xtensa-tdep.c (xtensa_register_type): Likewise. * gdbarch.c: Regenerate. * gdbarch.h: Regenerate. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Likewise. (compile_bytecodes): Likewise. * dll.c (loaded_dll): Likewise. * event-loop.c (append_callback_event): Likewise. (create_file_handler): Likewise. (create_file_event): Likewise. * hostio.c (handle_open): Likewise. * inferiors.c (add_thread): Likewise. (add_process): Likewise. * linux-aarch64-low.c (aarch64_linux_new_process): Likewise. * linux-arm-low.c (arm_new_process): Likewise. (arm_new_thread): Likewise. * linux-low.c (add_to_pid_list): Likewise. (linux_add_process): Likewise. (handle_extended_wait): Likewise. (add_lwp): Likewise. (enqueue_one_deferred_signal): Likewise. (enqueue_pending_signal): Likewise. (linux_resume_one_lwp_throw): Likewise. (linux_resume_one_thread): Likewise. (linux_read_memory): Likewise. (linux_write_memory): Likewise. * linux-mips-low.c (mips_linux_new_process): Likewise. (mips_linux_new_thread): Likewise. (mips_add_watchpoint): Likewise. * linux-x86-low.c (initialize_low_arch): Likewise. * lynx-low.c (lynx_add_process): Likewise. * mem-break.c (set_raw_breakpoint_at): Likewise. (set_breakpoint): Likewise. (add_condition_to_breakpoint): Likewise. (add_commands_to_breakpoint): Likewise. (clone_agent_expr): Likewise. (clone_one_breakpoint): Likewise. * regcache.c (new_register_cache): Likewise. * remote-utils.c (look_up_one_symbol): Likewise. * server.c (queue_stop_reply): Likewise. (start_inferior): Likewise. (queue_stop_reply_callback): Likewise. (handle_target_event): Likewise. * spu-low.c (fetch_ppc_memory): Likewise. (store_ppc_memory): Likewise. * target.c (set_target_ops): Likewise. * thread-db.c (thread_db_load_search): Likewise. (try_thread_db_load_1): Likewise. * tracepoint.c (add_tracepoint): Likewise. (add_tracepoint_action): Likewise. (create_trace_state_variable): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtro): Likewise. (add_while_stepping_state): Likewise. * win32-low.c (child_add_thread): Likewise. (get_image_name): Likewise.
2015-08-26Fix native follow-exec-mode "new"Don Breazeal3-3/+21
This patch fixes a segmentation fault in native GDB when handling an exec event with follow-exec-mode set to "new". The stack trace from the segfault was this: 0 0x0000000000669594 in gdbarch_data (gdbarch=0x0, data=0x20da7a0) at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/gdbarch.c:4847 1 0x00000000004d430e in get_remote_arch_state () at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/remote.c:603 2 0x00000000004d431e in get_remote_state () at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/remote.c:616 3 0x00000000004dda8b in discard_pending_stop_replies (inf=0x217c710) at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/remote.c:5775 4 0x00000000006a5928 in observer_inferior_exit_notification_stub ( data=0x4dda7a <discard_pending_stop_replies>, args_data=0x7fff12c258f0) at ./observer.inc:1137 5 0x00000000006a419a in generic_observer_notify (subject=0x21dfbe0, args=0x7fff12c258f0) at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/observer.c:167 6 0x00000000006a59ba in observer_notify_inferior_exit (inf=0x217c710) at ./observer.inc:1162 7 0x00000000007981d5 in exit_inferior_1 (inftoex=0x217c710, silent=1) at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/inferior.c:244 8 0x00000000007982f2 in exit_inferior_num_silent (num=1) at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/inferior.c:286 9 0x000000000062f93d in follow_exec (ptid=..., execd_pathname=0x7fff12c259a0 "/scratch/dbreazea/sandbox/exec-nat/build/gdb/testsuite/gdb.base/execd-prog") at /scratch/dbreazea/sandbox/exec-nat/binutils-gdb/gdb/infrun.c:1195 In follow_exec we were creating a new inferior for the execd program, as required by the exec mode, but we were doing it before calling exit_inferior_num_silent on the original inferior. So on entry to exit_inferior_num_silent we had two inferiors with the same ptid. In the calls made by exit_inferior_num_silent, the current inferior is temporarily saved and replaced in order to make use of functions that only operate on the current inferior (for example, in do_all_continuations, called while deleting the threads of the original inferior). When we restored the original inferior, we just took the first inferior that matched the ptid of the original and got the new (wrong) one. It hadn't been initialized yet and had no gdbarch pointer, and GDB segfaulted. The fix for that is to call exit_inferior_num_silent before adding the new inferior, so that we never have two inferiors with the same ptid. Then exit_inferior_num_silent uses the original inferior as the current inferior throughout, and can find a valid gdbarch pointer. Once we have finished with the exit of the old inferior and added the new one, we need to create a new thread for the new inferior. In the function that called follow_exec, handle_inferior_event_1, ecs->event_thread now points to the thread that was deleted with the exit of the original inferior. To remedy this we create the new thread, and once we return from follow_exec we reset ecs->event_thread. Note that we are guaranteed that we can reset ecs->event_thread safely using inferior_thread because we have set the current inferior in follow_exec, and inferior_ptid was set by the call to context_switch at the beginning of exec event handling. gdb/ChangeLog: * infrun.c (follow_exec): Re-order operations for handling follow-exec-mode "new". (handle_inferior_event_1): Assign ecs->event_thread to the current thread. * remote.c (get_remote_arch_state): Add an assertion.
2015-08-26New test for follow-exec-modeDon Breazeal3-0/+242
This patch implements a new GDB test for follow-exec-mode. Although there is a GDB test for debugging across an exec, there is no test for follow-exec-mode. This test is derived from gdb.base/foll-exec.exp, and re-uses execd-prog.c as the program to exec. The following behavior is tested: follow-exec-mode == "same" - 'next' over the exec, check for one inferior - 'continue' past the exec to a breakpoint, check for one inferior - after the exec, use a 'run' command to run the current binary follow-exec-mode == "new" - 'next' over the exec, check for two inferiors - 'continue' past the exec to a breakpoint, check for two inferiors - after the exec, use a 'run' command to run the current binary - after the exec, use the 'inferior' command to switch inferiors, then use a 'run' command to run the current binary Note that single-step breakpoints do not survive across an exec. There has to be a breakpoint in the execed program in order for it to stop right after the exec. gdb/testsuite/ChangeLog: * gdb.base/foll-exec-2.c: New test program. * gdb.base/foll-exec-2.exp: New test.
2015-08-26gdb: Add Markus Metzger as btrace maintainerPedro Alves2-0/+11
gdb/ChangeLog: 2015-08-26 Pedro Alves <palves@redhat.com> * MAINTAINERS: Add Markus Metzger as btrace maintainer.
2015-08-26Use stable sort for ld -r relocsAlan Modra2-72/+86
A number of targets emit multiple relocs at a given r_offset, and depend on those relocs staying in their original order. PR 18867 * elflink.c (cmp_ext32l_r_offset, cmp_ext32b_r_offset): Delete. (cmp_ext64l_r_offset, cmp_ext64b_r_offset): Delete. (ext32l_r_offset, ext32b_r_offset, ext64l_r_offset, ext64b_r_offset): New functions. (elf_link_adjust_relocs): Use an insertion sort to sort relocs.
2015-08-26Select MIPS ABi based upon abiflags rather than e_flags.Matthew Fortune4-235/+250
bfd PR ld/18401 * elfxx-mips.c (bfd_mips_isa_ext_mach): New function: Converts an ISA value to a bfd machine number. (bfd_mips_isa_ext): Update the ISA level and revision if necessary. Use mips_mach_extends_p to decide if the ISA extension needs to be set. (_bfd_mips_elf_merge_private_bfd_data): Allow the ISA extension to be inferred from the ABI setting. Set the ISA level from the maximum of the incoming and outgoing ISA levels. tests * ld-mips-elf/mips-elf-flags.exp: Add more ISA conflict tests.
generated by cgit v1.1 at 2024-12-23 12:25:22 +0000