diff options
Diffstat (limited to 'gdbserver')
| -rw-r--r-- | gdbserver/ChangeLog | 13 | ||||
| -rw-r--r-- | gdbserver/linux-low.cc | 7 | ||||
| -rw-r--r-- | gdbserver/linux-riscv-low.cc | 6 | ||||
| -rw-r--r-- | gdbserver/linux-x86-low.cc | 14 | ||||
| -rw-r--r-- | gdbserver/tdesc.cc | 4 |
5 files changed, 28 insertions, 16 deletions
diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index 553a00e..510cf2e 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,16 @@ +2020-10-08 Andrew Burgess <andrew.burgess@embecosm.com> + + * linux-low.cc (linux_process_target::handle_extended_wait): + Release the unique_ptr returned from allocate_target_description. + * linux-riscv-low.cc (riscv_target::low_arch_setup): Likewise. + * linux-x86-low.cc (tdesc_amd64_linux_no_xml): Change type. + (tdesc_i386_linux_no_xml): Change type. + (x86_linux_read_description): Borrow pointer from unique_ptr + object. + (x86_target::get_ipa_tdesc_idx): Likewise. + (initialize_low_arch): Likewise. + * tdesc.cc (allocate_target_description): Update return type. + 2020-10-07 Tom Tromey <tromey@adacore.com> * server.cc (handle_search_memory): Remove dead code. diff --git a/gdbserver/linux-low.cc b/gdbserver/linux-low.cc index 1ae72a2..06ce2f0 100644 --- a/gdbserver/linux-low.cc +++ b/gdbserver/linux-low.cc @@ -497,7 +497,6 @@ linux_process_target::handle_extended_wait (lwp_info **orig_event_lwp, struct process_info *child_proc; struct lwp_info *child_lwp; struct thread_info *child_thr; - struct target_desc *tdesc; ptid = ptid_t (new_pid, new_pid, 0); @@ -553,9 +552,9 @@ linux_process_target::handle_extended_wait (lwp_info **orig_event_lwp, clone_all_breakpoints (child_thr, event_thr); - tdesc = allocate_target_description (); - copy_target_description (tdesc, parent_proc->tdesc); - child_proc->tdesc = tdesc; + target_desc_up tdesc = allocate_target_description (); + copy_target_description (tdesc.get (), parent_proc->tdesc); + child_proc->tdesc = tdesc.release (); /* Clone arch-specific process data. */ low_new_fork (parent_proc, child_proc); diff --git a/gdbserver/linux-riscv-low.cc b/gdbserver/linux-riscv-low.cc index 1c6e8c4..32f191e 100644 --- a/gdbserver/linux-riscv-low.cc +++ b/gdbserver/linux-riscv-low.cc @@ -88,11 +88,11 @@ riscv_target::low_arch_setup () const riscv_gdbarch_features features = riscv_linux_read_features (lwpid_of (current_thread)); - target_desc *tdesc = riscv_create_target_description (features); + target_desc_up tdesc = riscv_create_target_description (features); if (!tdesc->expedite_regs) - init_target_desc (tdesc, expedite_regs); - current_process ()->tdesc = tdesc; + init_target_desc (tdesc.get (), expedite_regs); + current_process ()->tdesc = tdesc.release (); } /* Collect GPRs from REGCACHE into BUF. */ diff --git a/gdbserver/linux-x86-low.cc b/gdbserver/linux-x86-low.cc index eeaced8..65a0c07 100644 --- a/gdbserver/linux-x86-low.cc +++ b/gdbserver/linux-x86-low.cc @@ -48,9 +48,9 @@ #include "linux-x86-tdesc.h" #ifdef __x86_64__ -static struct target_desc *tdesc_amd64_linux_no_xml; +static target_desc_up tdesc_amd64_linux_no_xml; #endif -static struct target_desc *tdesc_i386_linux_no_xml; +static target_desc_up tdesc_i386_linux_no_xml; static unsigned char jump_insn[] = { 0xe9, 0, 0, 0, 0 }; @@ -899,10 +899,10 @@ x86_linux_read_description (void) /* Don't use XML. */ #ifdef __x86_64__ if (machine == EM_X86_64) - return tdesc_amd64_linux_no_xml; + return tdesc_amd64_linux_no_xml.get (); else #endif - return tdesc_i386_linux_no_xml; + return tdesc_i386_linux_no_xml.get (); } if (have_ptrace_getregset == -1) @@ -2955,7 +2955,7 @@ x86_target::get_ipa_tdesc_idx () return amd64_get_ipa_tdesc_idx (tdesc); #endif - if (tdesc == tdesc_i386_linux_no_xml) + if (tdesc == tdesc_i386_linux_no_xml.get ()) return X86_TDESC_SSE; return i386_get_ipa_tdesc_idx (tdesc); @@ -2971,14 +2971,14 @@ initialize_low_arch (void) /* Initialize the Linux target descriptions. */ #ifdef __x86_64__ tdesc_amd64_linux_no_xml = allocate_target_description (); - copy_target_description (tdesc_amd64_linux_no_xml, + copy_target_description (tdesc_amd64_linux_no_xml.get (), amd64_linux_read_description (X86_XSTATE_SSE_MASK, false)); tdesc_amd64_linux_no_xml->xmltarget = xmltarget_amd64_linux_no_xml; #endif tdesc_i386_linux_no_xml = allocate_target_description (); - copy_target_description (tdesc_i386_linux_no_xml, + copy_target_description (tdesc_i386_linux_no_xml.get (), i386_linux_read_description (X86_XSTATE_SSE_MASK)); tdesc_i386_linux_no_xml->xmltarget = xmltarget_i386_linux_no_xml; diff --git a/gdbserver/tdesc.cc b/gdbserver/tdesc.cc index e639017..b7e6057 100644 --- a/gdbserver/tdesc.cc +++ b/gdbserver/tdesc.cc @@ -95,10 +95,10 @@ init_target_desc (struct target_desc *tdesc, /* See gdbsupport/tdesc.h. */ -struct target_desc * +target_desc_up allocate_target_description (void) { - return new target_desc (); + return target_desc_up (new target_desc ()); } /* See gdbsupport/tdesc.h. */ |