diff options
Diffstat (limited to 'gdb')
| -rw-r--r-- | gdb/ChangeLog | 9 | ||||
| -rw-r--r-- | gdb/NEWS | 5 | ||||
| -rw-r--r-- | gdb/doc/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/doc/gdb.texinfo | 9 | ||||
| -rw-r--r-- | gdb/thread.c | 37 |
5 files changed, 60 insertions, 4 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 8d9e367..767aa2b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,14 @@ 2015-01-22 Jan Kratochvil <jan.kratochvil@redhat.com> + * NEWS (Changes since GDB 7.9): Add 'thread apply all' option + '-ascending'. + * thread.c (tp_array_compar_ascending, tp_array_compar): New. + (thread_apply_all_command): Parse CMD for tp_array_compar_ascending. + Sort tp_array using tp_array_compar. + (_initialize_thread): Extend thread_apply_all_command help. + +2015-01-22 Jan Kratochvil <jan.kratochvil@redhat.com> + * corelow.c (core_open): Call also thread_command. * gdbthread.h (thread_command): New prototype moved from ... * thread.c (thread_command): ... here. @@ -3,6 +3,11 @@ *** Changes since GDB 7.9 +* New options + +* The command 'thread apply all' can now support new option '-ascending' + to call its specified command for all threads in ascending order. + *** Changes in GDB 7.9 * GDB now supports hardware watchpoints on x86 GNU Hurd. diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index 4d2470a..a5d8329 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2015-01-22 Jan Kratochvil <jan.kratochvil@redhat.com> + + * gdb.texinfo (Threads): Describe -ascending for thread apply all. + 2015-01-16 Eli Zaretskii <eliz@gnu.org> * doc/gdb.texinfo (TUI Commands): Document the possible diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index f413e23..277df25 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -2959,14 +2959,17 @@ information on convenience variables. @kindex thread apply @cindex apply command to several threads -@item thread apply [@var{threadno} | all] @var{command} +@item thread apply [@var{threadno} | all [-ascending]] @var{command} The @code{thread apply} command allows you to apply the named @var{command} to one or more threads. Specify the numbers of the threads that you want affected with the command argument @var{threadno}. It can be a single thread number, one of the numbers shown in the first field of the @samp{info threads} display; or it -could be a range of thread numbers, as in @code{2-4}. To apply a -command to all threads, type @kbd{thread apply all @var{command}}. +could be a range of thread numbers, as in @code{2-4}. To apply +a command to all threads in descending order, type @kbd{thread apply all +@var{command}}. To apply a command to all threads in ascending order, +type @kbd{thread apply all -ascending @var{command}}. + @kindex thread name @cindex name a thread diff --git a/gdb/thread.c b/gdb/thread.c index 4bce212..a2a5a9b 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1381,6 +1381,24 @@ make_cleanup_restore_current_thread (void) restore_current_thread_cleanup_dtor); } +/* If non-zero tp_array_compar should sort in ascending order, otherwise in + descending order. */ + +static int tp_array_compar_ascending; + +/* Sort an array for struct thread_info pointers by their NUM, order is + determined by TP_ARRAY_COMPAR_ASCENDING. */ + +static int +tp_array_compar (const void *ap_voidp, const void *bp_voidp) +{ + const struct thread_info *const *ap = ap_voidp; + const struct thread_info *const *bp = bp_voidp; + + return ((((*ap)->num > (*bp)->num) - ((*ap)->num < (*bp)->num)) + * (tp_array_compar_ascending ? +1 : -1)); +} + /* Apply a GDB command to a list of threads. List syntax is a whitespace seperated list of numbers, or ranges, or the keyword `all'. Ranges consist of two numbers seperated by a hyphen. Examples: @@ -1397,6 +1415,14 @@ thread_apply_all_command (char *cmd, int from_tty) int tc; struct thread_array_cleanup ta_cleanup; + tp_array_compar_ascending = 0; + if (cmd != NULL + && check_for_argument (&cmd, "-ascending", strlen ("-ascending"))) + { + cmd = skip_spaces (cmd); + tp_array_compar_ascending = 1; + } + if (cmd == NULL || *cmd == '\000') error (_("Please specify a command following the thread ID list")); @@ -1430,6 +1456,8 @@ thread_apply_all_command (char *cmd, int from_tty) i++; } + qsort (tp_array, i, sizeof (*tp_array), tp_array_compar); + make_cleanup (set_thread_refcount, &ta_cleanup); for (k = 0; k != i; k++) @@ -1738,7 +1766,14 @@ The new thread ID must be currently known."), &thread_apply_list, "thread apply ", 1, &thread_cmd_list); add_cmd ("all", class_run, thread_apply_all_command, - _("Apply a command to all threads."), &thread_apply_list); + _("\ +Apply a command to all threads.\n\ +\n\ +Usage: thread apply all [-ascending] <command>\n\ +-ascending: Call <command> for all threads in ascending order.\n\ + The default is descending order.\ +"), + &thread_apply_list); add_cmd ("name", class_run, thread_name_command, _("Set the current thread's name.\n\ |