aboutsummaryrefslogtreecommitdiff
path: root/binutils
diff options
context:
space:
mode:
Diffstat (limited to 'binutils')
-rw-r--r--binutils/ChangeLog4
-rw-r--r--binutils/strings.c4
2 files changed, 6 insertions, 2 deletions
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 675050b..44467f1 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,7 @@
+2017-05-18 Alan Modra <amodra@gmail.com>
+
+ * strings.c: Don't compare boolean values against TRUE or FALSE.
+
2017-05-15 Jeff Law <law@redhat.com>
* readelf.c (display_arc_attribute): Avoid implicit fallthru.
diff --git a/binutils/strings.c b/binutils/strings.c
index e1511a8..13e2619 100644
--- a/binutils/strings.c
+++ b/binutils/strings.c
@@ -80,7 +80,7 @@
( (c) >= 0 \
&& (c) <= 255 \
&& ((c) == '\t' || ISPRINT (c) || (encoding == 'S' && (c) > 127) \
- || (include_all_whitespace == TRUE && ISSPACE (c))) \
+ || (include_all_whitespace && ISSPACE (c))) \
)
#ifndef errno
@@ -318,7 +318,7 @@ main (int argc, char **argv)
else
{
files_given = TRUE;
- exit_status |= strings_file (argv[optind]) == FALSE;
+ exit_status |= !strings_file (argv[optind]);
}
}
}