aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--gdb/ChangeLog5
-rw-r--r--gdb/xml-support.c4
2 files changed, 7 insertions, 2 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6625a03..aaf0485 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
2017-10-19 Pedro Alves <palves@redhat.com>
+ * xml-support.c (xml_fetch_content_from_file): Check fread's
+ return.
+
+2017-10-19 Pedro Alves <palves@redhat.com>
+
* ser-base.c (ser_base_read_error_fd): Delete the file handler if
async.
(handle_error_fd): New function.
diff --git a/gdb/xml-support.c b/gdb/xml-support.c
index 1f53d7a..2b59180 100644
--- a/gdb/xml-support.c
+++ b/gdb/xml-support.c
@@ -1025,8 +1025,8 @@ xml_fetch_content_from_file (const char *filename, void *baton)
gdb::unique_xmalloc_ptr<char> text ((char *) xmalloc (len + 1));
- fread (text.get (), 1, len, file.get ());
- if (ferror (file.get ()))
+ if (fread (text.get (), 1, len, file.get ()) != len
+ || ferror (file.get ()))
{
warning (_("Read error from \"%s\""), filename);
return NULL;