diff options
| -rw-r--r-- | gdb/ChangeLog | 4 | ||||
| -rw-r--r-- | gdb/remote.c | 19 |
2 files changed, 23 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 165c2a3..5cf8a5f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2016-04-27 Jan Kratochvil <jan.kratochvil@redhat.com> + + * remote.c (remote_start_remote): Detect PACKET_vFile_setfs.support. + 2016-04-27 Martin Galvan <martin.galvan@tallertechnologies.com> * c-valprint.c (c_value_print): Always convert val back to reference diff --git a/gdb/remote.c b/gdb/remote.c index 4c18b4f..1f0d67c 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -4031,6 +4031,25 @@ remote_start_remote (int from_tty, struct target_ops *target, int extended_p) if (packet_support (PACKET_QAllow) != PACKET_DISABLE) remote_set_permissions (target); + /* gdbserver < 7.7 (before its fix from 2013-12-11) did reply to any + unknown 'v' packet with string "OK". "OK" gets interpreted by GDB + as a reply to known packet. For packet "vFile:setfs:" it is an + invalid reply and GDB would return error in + remote_hostio_set_filesystem, making remote files access impossible. + Disable "vFile:setfs:" in such case. Do not disable other 'v' packets as + other "vFile" packets get correctly detected even on gdbserver < 7.7. */ + { + const char v_mustreplyempty[] = "vMustReplyEmpty"; + + putpkt (v_mustreplyempty); + getpkt (&rs->buf, &rs->buf_size, 0); + if (strcmp (rs->buf, "OK") == 0) + remote_protocol_packets[PACKET_vFile_setfs].support = PACKET_DISABLE; + else if (strcmp (rs->buf, "") != 0) + error (_("Remote replied unexpectedly to '%s': %s"), v_mustreplyempty, + rs->buf); + } + /* Next, we possibly activate noack mode. If the QStartNoAckMode packet configuration is set to AUTO, |