diff options
| -rw-r--r-- | gdb/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/symfile.c | 9 | ||||
| -rw-r--r-- | gdb/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/symfile-warn.c | 18 | ||||
| -rw-r--r-- | gdb/testsuite/gdb.base/symfile-warn.exp | 30 |
5 files changed, 61 insertions, 6 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 87575c8..146b181 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,5 +1,10 @@ 2019-06-14 Tom Tromey <tromey@adacore.com> + * symfile.c (add_symbol_file_command): Remove obsolete comment. + Warn if symbol file does not provide any symbols. + +2019-06-14 Tom Tromey <tromey@adacore.com> + * source.c (find_and_open_source): Respect basenames_may_differ. 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com> diff --git a/gdb/symfile.c b/gdb/symfile.c index 26762d2..6f9c81c 100644 --- a/gdb/symfile.c +++ b/gdb/symfile.c @@ -2211,12 +2211,6 @@ set_objfile_default_section_offset (struct objfile *objf, /* This function allows the addition of incrementally linked object files. It does not modify any state in the target, only in the debugger. */ -/* Note: ezannoni 2000-04-13 This function/command used to have a - special case syntax for the rombug target (Rombug is the boot - monitor for Microware's OS-9 / OS-9000, see remote-os9k.c). In the - rombug case, the user doesn't need to supply a text address, - instead a call to target_link() (in target.c) would supply the - value to use. We are now discontinuing this type of ad hoc syntax. */ static void add_symbol_file_command (const char *args, int from_tty) @@ -2358,6 +2352,9 @@ add_symbol_file_command (const char *args, int from_tty) objf = symbol_file_add (filename.get (), add_flags, §ion_addrs, flags); + if (!objfile_has_symbols (objf) && objf->per_bfd->minimal_symbol_count <= 0) + warning (_("newly-added symbol file \"%s\" does not provide any symbols"), + filename.get ()); if (seen_offset) set_objfile_default_section_offset (objf, section_addrs, offset); diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 4d89669..74e6741 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2019-06-14 Tom Tromey <tromey@adacore.com> + * gdb.base/symfile-warn.exp: New file. + * gdb.base/symfile-warn.c: New file. + +2019-06-14 Tom Tromey <tromey@adacore.com> + * gdb.base/annotate-symlink.exp: New file. 2019-06-14 Tom Tromey <tromey@adacore.com> diff --git a/gdb/testsuite/gdb.base/symfile-warn.c b/gdb/testsuite/gdb.base/symfile-warn.c new file mode 100644 index 0000000..38fdd67 --- /dev/null +++ b/gdb/testsuite/gdb.base/symfile-warn.c @@ -0,0 +1,18 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2019 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see <http://www.gnu.org/licenses/>. */ + +/* Empty. */ diff --git a/gdb/testsuite/gdb.base/symfile-warn.exp b/gdb/testsuite/gdb.base/symfile-warn.exp new file mode 100644 index 0000000..1fd9618 --- /dev/null +++ b/gdb/testsuite/gdb.base/symfile-warn.exp @@ -0,0 +1,30 @@ +# Copyright 2019 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see <http://www.gnu.org/licenses/>. + +standard_testfile .c +set ofile [standard_output_file ${testfile}.o] + +if {[gdb_compile "${srcdir}/${subdir}/${srcfile}" \ + $ofile object {debug}] != ""} { + untested "failed to compile" + return -1 +} + +clean_restart + +gdb_test "add-symbol-file $ofile 0" \ + "Reading symbols from .*warning: newly-added symbol file.*does not provide any symbols" \ + "add-symbol-file" \ + "add symbol table from file \".*\" at.*\\(y or n\\) " "y" |