diff options
| -rw-r--r-- | gdb/ChangeLog | 6 | ||||
| -rw-r--r-- | gdb/printcmd.c | 16 | ||||
| -rw-r--r-- | gdb/value.c | 4 |
3 files changed, 11 insertions, 15 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b642ac9..9f9088d 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-02-24 Doug Evans <dje@google.com> + + * value.c (record_latest_value): Fix comment. + * printcmd.c (print_command_1): Remove code to handle -1 return from + record_latest_value. + 2014-02-24 Pedro Alves <palves@redhat.com> * procfs.c (procfs_target): Don't install procfs_xfer_memory as diff --git a/gdb/printcmd.c b/gdb/printcmd.c index 10d3c23..e5fea17 100644 --- a/gdb/printcmd.c +++ b/gdb/printcmd.c @@ -985,16 +985,11 @@ print_command_1 (const char *exp, int voidprint) struct value_print_options opts; int histindex = record_latest_value (val); - if (histindex >= 0) - annotate_value_history_begin (histindex, value_type (val)); - else - annotate_value_begin (value_type (val)); + annotate_value_history_begin (histindex, value_type (val)); - if (histindex >= 0) - printf_filtered ("$%d = ", histindex); + printf_filtered ("$%d = ", histindex); - if (histindex >= 0) - annotate_value_history_value (); + annotate_value_history_value (); get_formatted_print_options (&opts, format); opts.raw = fmt.raw; @@ -1002,10 +997,7 @@ print_command_1 (const char *exp, int voidprint) print_formatted (val, fmt.size, &opts, gdb_stdout); printf_filtered ("\n"); - if (histindex >= 0) - annotate_value_history_end (); - else - annotate_value_end (); + annotate_value_history_end (); } do_cleanups (old_chain); diff --git a/gdb/value.c b/gdb/value.c index 73ba18e..50b0245 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -1642,9 +1642,7 @@ set_value_component_location (struct value *component, /* Access to the value history. */ /* Record a new value in the value history. - Returns the absolute history index of the entry. - Result of -1 indicates the value was not saved; otherwise it is the - value history index of this new item. */ + Returns the absolute history index of the entry. */ int record_latest_value (struct value *val) |