diff options
| -rw-r--r-- | gdb/ChangeLog | 20 | ||||
| -rw-r--r-- | gdb/remote-udi.c | 5 |
2 files changed, 25 insertions, 0 deletions
diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3abb095..e630987 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,23 @@ +Fri Oct 14 10:29:08 1994 Jim Kingdon (kingdon@lioth.cygnus.com) + + * exec.c (map_vmap): Cast return from xmalloc to its proper type, + not to PTR. + + * symfile.c (reread_symbols): Include bfd_errmsg string in error + message if bfd_close fails. + * exec.c (exec_close), solib.c (clear_solib), corelow.c + (core_close), objfiles.c (free_objfile), irix5-nat.c + (clear_solib), remote-utils.c (gr_load_image): + Check for errors from bfd_close. + * solib.c (look_for_base), remote-utils.c (gr_load_image), + remote-udi.c (download), corelow.c (core_open), symfile.c + (symfile_bfd_open), symfile.c (generic_load): Add comment + regarding error from bfd_close. + * remote-udi.c (download), remote-utils.c (gr_load_image): Add + comment about bogus handling of errors from bfd_openr. + * exec.c (exec_close): Add comment regarding memory leak and + dangling reference to vp->name. + Sat Oct 15 03:43:00 1994 Peter Schauer (pes@regent.e-technik.tu-muenchen.de) * eval.c (evaluate_subexp): Make fnptr a LONGEST instead diff --git a/gdb/remote-udi.c b/gdb/remote-udi.c index e57cad0..c2366fd 100644 --- a/gdb/remote-udi.c +++ b/gdb/remote-udi.c @@ -1139,8 +1139,13 @@ download(load_arg_string, from_tty) pbfd = bfd_openr (filename, gnutarget); if (!pbfd) + /* FIXME: should be using bfd_errmsg, not assuming it was + bfd_error_system_call. */ perror_with_name (filename); + /* FIXME: should be checking for errors from bfd_close (for one thing, + on error it does not free all the storage associated with the + bfd). */ make_cleanup (bfd_close, pbfd); QUIT; |