diff options
author | Mike Frysinger <vapier@gentoo.org> | 2016-01-03 21:40:34 -0500 |
---|---|---|
committer | Mike Frysinger <vapier@gentoo.org> | 2016-01-03 22:07:39 -0500 |
commit | 77cf2ef5dc9099501529151921a73be904757466 (patch) | |
tree | afe55fc45fb53886d73ed81e984f83222ab759a7 /sim/sh64 | |
parent | 3726f72c654ab357be5b79c78f238da7a869f9a3 (diff) | |
download | gdb-77cf2ef5dc9099501529151921a73be904757466.zip gdb-77cf2ef5dc9099501529151921a73be904757466.tar.gz gdb-77cf2ef5dc9099501529151921a73be904757466.tar.bz2 |
sim: parse_args: display getopt error ourselves
Fix a long standing todo where we let getopt write directly to stderr
when an invalid option is passed. Use the sim io funcs instead as they
go through the filtered callbacks that gdb wants.
Diffstat (limited to 'sim/sh64')
-rw-r--r-- | sim/sh64/ChangeLog | 4 | ||||
-rw-r--r-- | sim/sh64/sim-if.c | 4 |
2 files changed, 5 insertions, 3 deletions
diff --git a/sim/sh64/ChangeLog b/sim/sh64/ChangeLog index 8ccee76..0ca9814 100644 --- a/sim/sh64/ChangeLog +++ b/sim/sh64/ChangeLog @@ -1,5 +1,9 @@ 2016-01-03 Mike Frysinger <vapier@gentoo.org> + * sim-if.c (sim_open): Update sim_parse_args comment. + +2016-01-03 Mike Frysinger <vapier@gentoo.org> + * sh64-sim.h (GETTWI, SETTWI): Delete unused defines. (sh5_devices): Delete. (struct _device): Delete. diff --git a/sim/sh64/sim-if.c b/sim/sh64/sim-if.c index ba8feb8..907ee06 100644 --- a/sim/sh64/sim-if.c +++ b/sim/sh64/sim-if.c @@ -79,9 +79,7 @@ sim_open (kind, callback, abfd, argv) return 0; } - /* getopt will print the error message so we just have to exit if this fails. - FIXME: Hmmm... in the case of gdb we need getopt to call - print_filtered. */ + /* The parser will print an error message for us, so we silently return. */ if (sim_parse_args (sd, argv) != SIM_RC_OK) { free_state (sd); |