aboutsummaryrefslogtreecommitdiff
path: root/sim/ppc
diff options
context:
space:
mode:
authorTsukasa OI <research_trasio@irq.a4lg.com>2022-10-17 15:47:23 +0000
committerTsukasa OI <research_trasio@irq.a4lg.com>2022-10-29 05:39:52 +0000
commitdd6c5a9217002033149a92bc48999370c451d025 (patch)
treeba00985e941bb4100b9ece07769148e0eb77ea57 /sim/ppc
parentbb94ac4f95dd11c87d84eea533fe4f3218a48583 (diff)
downloadgdb-dd6c5a9217002033149a92bc48999370c451d025.zip
gdb-dd6c5a9217002033149a92bc48999370c451d025.tar.gz
gdb-dd6c5a9217002033149a92bc48999370c451d025.tar.bz2
sim, sim/{m32c,ppc,rl78}: Use getopt_long
Because of a Libiberty hack, getopt on GNU libc (2.25 or earlier) is currently unusable on sim, causing a regression on CentOS 7. This is caused as follows: 1. If HAVE_DECL_GETOPT is defined (getopt declaration with known prototype is detected while configuration), a declaration of getopt in "include/getopt.h" is suppressed. The author started to define HAVE_DECL_GETOPT in sim with the commit 340aa4f6872c ("sim: Check known getopt definition existence"). 2. GNU libc (2.25 or earlier)'s <unistd.h> includes <getopt.h> with a special purpose macro defined to declare only getopt function but due to include path (not tested while configuration), it causes <unistd.h> to include Libiberty's "include/getopt.h". 3. If both 1. and 2. are satisfied, despite that <unistd.h> tries to declare getopt by including <getopt.h>, "include/getopt.h" does not do so, causing getopt function undeclared. Getting rid of "include/getopt.h" (e.g. renaming this header file) is the best solution to avoid hacking but as a short-term solution, this commit replaces getopt with getopt_long under sim/.
Diffstat (limited to 'sim/ppc')
-rw-r--r--sim/ppc/dgen.c6
-rw-r--r--sim/ppc/igen.c9
2 files changed, 10 insertions, 5 deletions
diff --git a/sim/ppc/dgen.c b/sim/ppc/dgen.c
index a1c1d56..caafe07 100644
--- a/sim/ppc/dgen.c
+++ b/sim/ppc/dgen.c
@@ -271,6 +271,7 @@ main(int argc,
{
lf_file_references file_references = lf_include_references;
spreg_table *sprs = NULL;
+ static const struct option longopts[] = { { 0 } };
char *real_file_name = NULL;
int is_header = 0;
int ch;
@@ -284,8 +285,9 @@ main(int argc,
printf("-L Suppress cpp line numbering in output files\n");
}
-
- while ((ch = getopt(argc, argv, "hLsn:r:p:")) != -1) {
+ while ((ch = getopt_long (argc, argv, "hLsn:r:p:", longopts, NULL))
+ != -1)
+ {
#if 0 /* For debugging. */
fprintf(stderr, "\t-%c %s\n", ch, ( optarg ? optarg : ""));
#endif
diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c
index 27b4863..445afb9 100644
--- a/sim/ppc/igen.c
+++ b/sim/ppc/igen.c
@@ -351,6 +351,7 @@ main(int argc,
filter *filters = NULL;
insn_table *instructions = NULL;
table_include *includes = NULL;
+ static const struct option longopts[] = { { 0 } };
char *real_file_name = NULL;
int is_header = 0;
int ch;
@@ -390,9 +391,11 @@ main(int argc,
printf(" -f <output-file> output support functions\n");
}
- while ((ch = getopt(argc, argv,
- "F:EI:RSLJT:CB:H:N:o:k:i:n:hc:d:m:s:t:f:"))
- != -1) {
+ while (
+ (ch = getopt_long (argc, argv, "F:EI:RSLJT:CB:H:N:o:k:i:n:hc:d:m:s:t:f:",
+ longopts, NULL))
+ != -1)
+ {
#if 0 /* For debugging. */
fprintf(stderr, "\t-%c %s\n", ch, (optarg ? optarg : ""));
#endif