diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2016-01-03 21:40:34 -0500 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2016-01-03 22:07:39 -0500 |
| commit | 77cf2ef5dc9099501529151921a73be904757466 (patch) | |
| tree | afe55fc45fb53886d73ed81e984f83222ab759a7 /sim/mips | |
| parent | 3726f72c654ab357be5b79c78f238da7a869f9a3 (diff) | |
| download | gdb-77cf2ef5dc9099501529151921a73be904757466.zip gdb-77cf2ef5dc9099501529151921a73be904757466.tar.gz gdb-77cf2ef5dc9099501529151921a73be904757466.tar.bz2 | |
sim: parse_args: display getopt error ourselves
Fix a long standing todo where we let getopt write directly to stderr
when an invalid option is passed. Use the sim io funcs instead as they
go through the filtered callbacks that gdb wants.
Diffstat (limited to 'sim/mips')
| -rw-r--r-- | sim/mips/ChangeLog | 4 | ||||
| -rw-r--r-- | sim/mips/interp.c | 4 |
2 files changed, 5 insertions, 3 deletions
diff --git a/sim/mips/ChangeLog b/sim/mips/ChangeLog index 47dd1b0..f8ec3e7 100644 --- a/sim/mips/ChangeLog +++ b/sim/mips/ChangeLog @@ -1,5 +1,9 @@ 2016-01-03 Mike Frysinger <vapier@gentoo.org> + * interp.c (sim_open): Update sim_parse_args comment. + +2016-01-03 Mike Frysinger <vapier@gentoo.org> + * configure.ac (SIM_AC_OPTION_HOSTENDIAN): Delete. * configure: Regenerate. diff --git a/sim/mips/interp.c b/sim/mips/interp.c index 843ba94..0801ac1 100644 --- a/sim/mips/interp.c +++ b/sim/mips/interp.c @@ -376,9 +376,7 @@ sim_open (SIM_OPEN_KIND kind, host_callback *cb, struct bfd *abfd, char **argv) sim_add_option_table (sd, NULL, mips_options); - /* getopt will print the error message so we just have to exit if this fails. - FIXME: Hmmm... in the case of gdb we need getopt to call - print_filtered. */ + /* The parser will print an error message for us, so we silently return. */ if (sim_parse_args (sd, argv) != SIM_RC_OK) { /* Uninstall the modules to avoid memory leaks, |