diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2021-04-18 21:01:00 -0400 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2021-04-18 21:07:25 -0400 |
| commit | 3912a8db685f5e19a883d02d66900cdf10a200f0 (patch) | |
| tree | 07104f4906862d7e7c2e121b728ab16658dd1d98 /sim/cr16/configure.ac | |
| parent | 9eab4c18bd39c0dc5b3f41892d80c130b0852e35 (diff) | |
| download | gdb-3912a8db685f5e19a883d02d66900cdf10a200f0.zip gdb-3912a8db685f5e19a883d02d66900cdf10a200f0.tar.gz gdb-3912a8db685f5e19a883d02d66900cdf10a200f0.tar.bz2 | |
sim: cr16: fix build warnings
The printf fix is obvious enough, but the hash one is a real bug:
cr16/interp.c: In function 'sim_open':
cr16/interp.c:560:17: error: 'h' may be used uninitialized in this function [-Werror=maybe-uninitialized]
560 | h = h->next;
| ~~^~~~~~~~~
It happens to not cause a problem currently because the first entry in
the generated table that this loop operates matches a codepath where h
is initialized. Then when later entries don't match, the previous value
is pointing at the end of a valid hash table already, and the rest of
the code does nothing.
With this tidied up, we can delete the SIM_AC_OPTION_WARNINGS(no) call
to get the default common behavior where -Werror is enabled.
Diffstat (limited to 'sim/cr16/configure.ac')
| -rw-r--r-- | sim/cr16/configure.ac | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sim/cr16/configure.ac b/sim/cr16/configure.ac index 5827797..f4dc9c1 100644 --- a/sim/cr16/configure.ac +++ b/sim/cr16/configure.ac @@ -6,6 +6,5 @@ SIM_AC_COMMON SIM_AC_OPTION_ENDIAN(LITTLE) SIM_AC_OPTION_ALIGNMENT(NONSTRICT_ALIGNMENT) -SIM_AC_OPTION_WARNINGS(no) SIM_AC_OUTPUT |