diff options
| author | Ozkan Sezer <sezero@sourceware.org> | 2010-05-26 22:40:24 +0000 |
|---|---|---|
| committer | Ozkan Sezer <sezero@sourceware.org> | 2010-05-26 22:40:24 +0000 |
| commit | 363a6e9f2c3fe1e25f8fa986347948897f189f39 (patch) | |
| tree | 71182a438b05d879f96dc50f3dcd232c29f312cb /sim/common | |
| parent | 9db8dccb1711d06bd180437fcd8c78c5f0981193 (diff) | |
| download | gdb-363a6e9f2c3fe1e25f8fa986347948897f189f39.zip gdb-363a6e9f2c3fe1e25f8fa986347948897f189f39.tar.gz gdb-363a6e9f2c3fe1e25f8fa986347948897f189f39.tar.bz2 | |
2010-05-26 Ozkan Sezer <sezeroz@gmail.com>
gdb/
* ser-tcp.c (net_open): Check error return from socket() call by its
equality to -1 not by it being negative.
(net_close): Likewise.
gdb/gdbserver/
* gdbreplay.c (remote_open): Check error return from socket() call by
its equality to -1 not by it being negative.
* remote-utils.c (remote_open): Likewise.
sim/arm/
* communicate.c (MYread_char): Check error return from accept() call
by its equality to -1 not by it being negative.
(MYread_charwait): Likewise.
* main.c (main): Likewise for both socket() and accept() calls.
sim/common/
* dv-sockser.c (dv_sockser_init): Check error return from socket()
call by its equality to -1 not by it being negative.
(connected_p): Likewise for accept() call.
sim/cris/
* dv-rv.c (hw_rv_init_socket): Check error return from socket() call
by its equality to -1 not by it being negative.
(hw_rv_write): Likewise.
(hw_rv_handle_incoming): Likewise.
(hw_rv_poll_once): Likewise.
* rvdummy.c (setupsocket): Likewise.
(main): Likewise for accept() call as returned from setupsocket().
sim/m32c/
* main.c (setup_tcp_console): Check error return from socket() call
by its equality to -1 not by it being negative.
Diffstat (limited to 'sim/common')
| -rw-r--r-- | sim/common/ChangeLog | 6 | ||||
| -rw-r--r-- | sim/common/dv-sockser.c | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog index 3aa491a..2eebba8 100644 --- a/sim/common/ChangeLog +++ b/sim/common/ChangeLog @@ -1,3 +1,9 @@ +2010-05-26 Ozkan Sezer <sezeroz@gmail.com> + + * dv-sockser.c (dv_sockser_init): Check error return from socket() + call by its equality to -1 not by it being negative. + (connected_p): Likewise for accept() call. + 2010-04-23 Mike Frysinger <vapier@gentoo.org> * sim-fpu.c (sim_fpu_zero, sim_fpu_qnan): Add 0 initializers. diff --git a/sim/common/dv-sockser.c b/sim/common/dv-sockser.c index a8626cd..b09d9c9 100644 --- a/sim/common/dv-sockser.c +++ b/sim/common/dv-sockser.c @@ -166,7 +166,7 @@ dv_sockser_init (SIM_DESC sd) } sockser_listen_fd = socket (PF_INET, SOCK_STREAM, 0); - if (sockser_listen_fd < 0) + if (sockser_listen_fd == -1) { sim_io_eprintf (sd, "sockser init: unable to get socket: %s\n", strerror (errno)); @@ -274,7 +274,7 @@ connected_p (SIM_DESC sd) addrlen = sizeof (sockaddr); sockser_fd = accept (sockser_listen_fd, &sockaddr, &addrlen); - if (sockser_fd < 0) + if (sockser_fd == -1) return 0; /* Set non-blocking i/o. */ |