diff options
| author | Mike Frysinger <vapier@gentoo.org> | 2011-03-24 03:17:14 +0000 |
|---|---|---|
| committer | Mike Frysinger <vapier@gentoo.org> | 2011-03-24 03:17:14 +0000 |
| commit | 9922f80319007ace0ad526d70019b3b5fee72a8d (patch) | |
| tree | 7b6d8f6a4ada526ce0ffbfe49df57c50fd82f1b3 /sim/bfin/dv-bfin_uart2.c | |
| parent | 2d2bab5b21dda6842a044364fc6082722c2befc1 (diff) | |
| download | gdb-9922f80319007ace0ad526d70019b3b5fee72a8d.zip gdb-9922f80319007ace0ad526d70019b3b5fee72a8d.tar.gz gdb-9922f80319007ace0ad526d70019b3b5fee72a8d.tar.bz2 | |
sim: bfin: fix inverted W1C logic
When I originally wrote the w1c helper funcs, I used it in a few places.
Then I forgot how it worked and when I later documented it, I described
the 3rd arg in the exact opposite way it is actually used. This error
propagated to a bunch of devices registers that were not explicitly
tested (a bunch of the devices are stubs which merely exist to say "no
device is connected" to make device drivers happy).
So once the documentation is unscrewed, fix all of the broken call sites.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'sim/bfin/dv-bfin_uart2.c')
| -rw-r--r-- | sim/bfin/dv-bfin_uart2.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sim/bfin/dv-bfin_uart2.c b/sim/bfin/dv-bfin_uart2.c index 5b379bb..facde1c 100644 --- a/sim/bfin/dv-bfin_uart2.c +++ b/sim/bfin/dv-bfin_uart2.c @@ -97,10 +97,10 @@ bfin_uart_io_write_buffer (struct hw *me, const void *source, uart->ier |= value; break; case mmr_offset(ier_clear): - dv_w1c_2 (&uart->ier, value, 0); + dv_w1c_2 (&uart->ier, value, -1); break; case mmr_offset(lsr): - dv_w1c_2 (valuep, value, TEMT | THRE | DR); + dv_w1c_2 (valuep, value, TFI | BI | FE | PE | OE); break; case mmr_offset(rbr): /* XXX: Writes are ignored ? */ |