diff options
author | Mike Frysinger <vapier@gentoo.org> | 2011-03-24 03:17:14 +0000 |
---|---|---|
committer | Mike Frysinger <vapier@gentoo.org> | 2011-03-24 03:17:14 +0000 |
commit | 9922f80319007ace0ad526d70019b3b5fee72a8d (patch) | |
tree | 7b6d8f6a4ada526ce0ffbfe49df57c50fd82f1b3 /sim/bfin/devices.h | |
parent | 2d2bab5b21dda6842a044364fc6082722c2befc1 (diff) | |
download | gdb-9922f80319007ace0ad526d70019b3b5fee72a8d.zip gdb-9922f80319007ace0ad526d70019b3b5fee72a8d.tar.gz gdb-9922f80319007ace0ad526d70019b3b5fee72a8d.tar.bz2 |
sim: bfin: fix inverted W1C logic
When I originally wrote the w1c helper funcs, I used it in a few places.
Then I forgot how it worked and when I later documented it, I described
the 3rd arg in the exact opposite way it is actually used. This error
propagated to a bunch of devices registers that were not explicitly
tested (a bunch of the devices are stubs which merely exist to say "no
device is connected" to make device drivers happy).
So once the documentation is unscrewed, fix all of the broken call sites.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'sim/bfin/devices.h')
-rw-r--r-- | sim/bfin/devices.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sim/bfin/devices.h b/sim/bfin/devices.h index 76854ed..3dc5481 100644 --- a/sim/bfin/devices.h +++ b/sim/bfin/devices.h @@ -81,8 +81,8 @@ static inline void dv_store_4 (void *ptr, bu32 val) dv_store_2 (ptr, val); } -/* Helpers for MMRs where all bits are W1C except for the specified - bits -- those ones are RO. */ +/* Helpers for MMRs where only the specified bits are W1C. The + rest are left unmodified. */ #define dv_w1c(ptr, val, bits) (*(ptr) &= ~((val) & (bits))) static inline void dv_w1c_2 (bu16 *ptr, bu16 val, bu16 bits) { |